正確接管日期以選擇搜索條件

Question

我嘗試通過表單（Periode）上的組合框來讓人們選擇2個日期來在特定時間段內搜索數據。所選日期被用作在數據內搜索的選擇標準。我通過這段代碼：

Private Sub Datumok_Click() 
Dim AA1 As String 
Dim AA2 As String 
Dim AA3 As String 
Dim AA4 As String 
Dim AA5 As String 
Dim AA6 As String 
Dim LastRow As Single 

AA1 = Me.dag1.Value 
AA2 = Me.maand1.Value 
AA3 = Me.jaar1.Value 
AA4 = Me.dag2.Value 
AA5 = Me.maand2.Value 
AA6 = Me.jaar2.Value 

Application.ScreenUpdating = False 

Sheets("Feuil2").Select 
LastRow = Cells(Rows.Count, "a").End(xlUp).Row 
Sheets("Start").Range("F7") = AA2 & "-" & AA1 & "-" & AA3 
Sheets("Start").Range("G7") = AA5 & "-" & AA4 & "-" & AA6 
Sheets("Start").Range("F8") = AA1 & "-" & AA2 & "-" & AA3 
Sheets("Start").Range("G8") = AA4 & "-" & AA5 & "-" & AA6 
Unload Periode 
Sheets("Feuil2").Select 
ActiveSheet.AutoFilterMode = False 
Range(Cells(1, 1), Cells(LastRow, 10)).Select 
Selection.AutoFilter 
ActiveSheet.Range(Cells(2, 3), Cells(LastRow, 3)).AutoFilter Field:=3,      ActiveSheet.Range(Cells(2, 3), Cells(LastRow, 3)).AutoFilter Field:=3, Criteria1:=">=" & Sheets("Start").Range("F8"), Operator:=xlAnd, Criteria2:="<=" & Sheets("Start").Range("G8") 
Cells(1, 1).Select 
Sheets("Start").Select 
Cells(8, 5).Value = "Ok" 

'Wel blad updaten 
Application.ScreenUpdating = True 
End Sub 

有點討厭的代碼也許。選擇放到一個單元格中，這兩個單元格用作選擇標準。 有時候，vba或Excel不會接管日期，但是當我在過濾器中手動執行時，它會工作。有人知道如何改進代碼，它始終有效嗎？

Answer 1

好的第一步是消除所有.Select聲明並直接處理所需的對象。

下一步是刪除代碼中的3個（我認爲）.AutoFitler聲明並僅使用一個聲明。我已經重構了一下你的代碼（並且放了一些註釋，以便我可以顯示我對代碼的解釋）。

Private Sub Datumok_Click() 

Dim AA1 As String 
Dim AA2 As String 
Dim AA3 As String 
Dim AA4 As String 
Dim AA5 As String 
Dim AA6 As String 
Dim sSE As String 
Dim sEE As String 
Dim LastRow As Single 

'start date 
AA1 = Me.dag1.Value 'day 
AA2 = Me.maand1.Value 'month 
AA3 = Me.jaar1.Value 'year 

'end date 
AA4 = Me.dag2.Value 'day 
AA5 = Me.maand2.Value 'month 
AA6 = Me.jaar2.Value 'year 

Application.ScreenUpdating = False 

With Sheets("Start") 
    .Range("F7") = AA2 & "-" & AA1 & "-" & AA3 
    .Range("G7") = AA5 & "-" & AA4 & "-" & AA6 
    .Range("F8") = AA1 & "-" & AA2 & "-" & AA3 
    sSE = .Range("F8").Value2 
    .Range("G8") = AA4 & "-" & AA5 & "-" & AA6 
    sEE = .Range("G8").Value2 
End With 

Unload Periode 

With Sheets("Feuil2") 

    .AutoFilterMode = False 
    LastRow = .Cells(.Rows.Count, "a").End(xlUp).Row 

    'filters columns A(1) through J(10) ... adjust based on your needs 
    .Range(Cells(1, 1), Cells(LastRow, 10)).AutoFilter Field:=3, Criteria1:=">=" & sSE, Operator:=xlAnd, Criteria2:="<=" & sEE 

End With 

With Sheets("Start") 
    .Select 
    .Cells(8, 5).Value = "Ok" 
End With 

'Wel blad updaten 
Application.ScreenUpdating = True 

End Sub