一個函數中的多個IF語句 - OOP

Question

即時通訊想要檢查輸入的三角形是否是等腰，等號等等。第一個if語句有效，但是一旦我介紹第二個，它表示意外的t_else，這裏是代碼...

public function typeOfTriangle() 
{ 
     if ($this->sideOneLength == $this->sideTwoLength && $this->sideTwoLength == $this->baseLength) { 
      echo "<h1>Equilateral Triangle</h1>"; 
     else if ($this->sideOneLength == $this->sideTwoLength OR $this->sideOneLength == $this->baseLength OR $this->sideTwoLength == $this->baseLength) { 
      echo "<h1>Isosceles Triangle</h1>"; 
    } 
} 

有什麼想法嗎？

Answer 1

也許這是連更好？ （基於來自Vlad Preda的示例：

public function getSides() 
{ 
    return array($this->sideOneLength, $this->sideTwoLength, $this->sideThreeLength); 
} 

public function typeOfTriangle() 
{ 
    $uniqueSides = count(array_unique($this->getSides())); 

    switch ($uniqueSides) { 
     case 1: 
     return "Equilateral"; 
     break; 

     case 2: 
     return "Isosceles"; 
     break; 

     default: 
     return "Normal triangle"; 
     break; 
    } 

} 

Answer 2

你有一個語法錯誤：

public function typeOfTriangle() 
{ 
     if ($this->sideOneLength == $this->sideTwoLength && $this->sideTwoLength == $this->baseLength) { 
      echo "<h1>Equilateral Triangle</h1>"; 
     }else if ($this->sideOneLength == $this->sideTwoLength OR $this->sideOneLength == $this->baseLength OR $this->sideTwoLength == $this->baseLength) { 
      echo "<h1>Isosceles Triangle</h1>"; 
     } 
} 

Answer 3

需要一個支柱}

 if ($this->sideOneLength == $this->sideTwoLength && $this->sideTwoLength == $this->baseLength) { 
      echo "<h1>Equilateral Triangle</h1>"; 
     } 
     else if ($this->sideOneLength == $this->sideTwoLength OR $this->sideOneLength == $this->baseLength OR $this->sideTwoLength == $this->baseLength) { 
      echo "<h1>Isosceles Triangle</h1>"; 
     } 

Answer 4

我會建議略有不同，更可讀的辦法：

public function getSides() 
{ 
    return array($this->sideOneLength, $this->sideTwoLength, $this->sideThreeLength); 
} 

public function typeOfTriangle() 
{ 
    $uniqueSides = count(array_unique($this->getSides())); 

    if ($uniqueSides == 1) { 
     return "Equilateral"; 
    } elseif ($uniqueSides == 2) { 
     return "Isosceles"; 
    } else { 
     return "Normal triangle"; 
    } 
}