軌道，當它應該

這可能不是最乾淨的代碼自定義驗證失敗不還，還是很新的紅寶石......軌道，當它應該

我在message.rb模型下面的垃圾郵件檢查方法：

validate :no_spam?, :if => "sender_user_id != nil" 

private 

def no_spam? 
    #first easy spam detection, if the (hidden by css) company field is filled, it is spam for sure 
    if !company.blank? 
    errors.add(:body, I18n.t(:No_spam_allowed)) 
    return false 
    end 

    #Mollom advanced spam detection 
    m = Mollom.new(:private_key => 'xxx', 
       :public_key => 'xxx') 

    #check content in case it is a first submit of the form 
    if captcha_session_id.blank? 
    content = m.check_content(:post_body => body, 
           :author_name => sender_name, 
           :author_mail => sender_email, 
           :author_ip => sender_ip) 
    else 
    #check captcha if the form was resumbitted after an unsure result 
    logger.debug "DEBUG: GOING TO CHECK CAPTCHA" 
    result = m.valid_captcha?(:session_id => captcha_session_id, 
           :solution => captcha_solution.chomp) 
    if result 
     logger.debug "DEBUG: TRUE -> GOOD CAPTCHA" 
     return true 
    else 
     logger.debug "DEBUG: FALSE -> BAD CAPTCHA" 
     return false 
    end 
    end 

    #returning the right values and error messages for different content check outcomes 
    logger.debug "DEBUG: I'M CONTINUING THE METHOD EXECUTION" 
    if content.spam? 
    logger.debug "DEBUG: SPAM DETECTED" 
    errors.add(:body, I18n.t(:No_spam_allowed)) 
    return false 
    elsif content.unsure? 
    logger.debug "DEBUG: MESSAGE UNSURE - FAIL FORM BUT SHOW CAPTCHA" 
    errors.add(:captcha_solution, I18n.t(:Type_the_characters_you_see_in_the_picture_below)) 
    self.captcha_image_url = m.image_captcha(:session_id => content.session_id)["url"] 
    self.captcha_session_id = content.session_id 
    return false 
    else 
    logger.debug "DEBUG: MESSAGE OK!" 
    return true 
    end 
end

development.log

Processing MessagesController#create (for 127.0.0.1 at 2011-08-12 12:01:24) [POST] 
    Parameters: {"commit"=>"Verzend", "action"=>"create", "authenticity_token"=>"xxxxxxxxxxx", "locale"=>"nl", "controller"=>"messages", "message"=>{"sender_email"=>"[FILTERED]", "company"=>"", "body"=>"unsure", "sender_phone"=>"xxxx", "sender_name"=>"Admin ImmoNatie"}} 
    Message Columns (6.0ms) SHOW FIELDS FROM `messages` 
    User Columns (10.0ms) SHOW FIELDS FROM `users` 
    User Load (7.0ms) SELECT * FROM `users` WHERE (`users`.`id` = '1') AND (users.deleted_at IS NULL) LIMIT 1 
    SQL (0.0ms) BEGIN 
    User Update (0.0ms) UPDATE `users` SET `updated_at` = '2011-08-12 10:01:25', `perishable_token` = 'xxxxxxxxxxx', `last_request_at` = '2011-08-12 10:01:25' WHERE `id` = 1 
    SQL (3.0ms) COMMIT 
    SQL (0.0ms) BEGIN 
DEBUG: I'M CONTINUING THE METHOD EXECUTION 
DEBUG: MESSAGE UNSURE - FAIL FORM BUT SHOW CAPTCHA 
    SQL (0.0ms) ROLLBACK 
Rendering template within layouts/application 
Rendering messages/new 
Rendered messages/_form (8.0ms) 
Rendered layouts/_google_analytics (0.0ms) 
Rendered layouts/_login (3.0ms) 
Rendered layouts/_navigation (6.0ms) 
Rendered layouts/_header (12.0ms) 
Rendered about_us/_ten_reasons_9_body (0.0ms) 
    NewsletterEmail Columns (5.0ms) SHOW FIELDS FROM `newsletter_emails` 
Rendered layouts/_footer (41.0ms) 
Completed in 1907ms (View: 70, DB: 40) | 200 OK [http://infinitize.dynalias.com/contact] 
tize.dynalias.com/contact] 
    SQL (0.0ms) SET SQL_AUTO_IS_NULL=0 
    Property Columns (10.0ms) SHOW FIELDS FROM `properties` 


Processing MessagesController#create (for 127.0.0.1 at 2011-08-12 12:01:32) [POST] 
    Parameters: {"commit"=>"Verzend", "action"=>"create", "authenticity_token"=>"xxxxxxxxxxx", "locale"=>"nl", "controller"=>"messages", "message"=>{"sender_email"=>"[FILTERED]", "company"=>"", "body"=>"unsure", "captcha_solution"=>"", "sender_phone"=>"xx", "captcha_session_id"=>"xxxxxxxxxxx", "sender_name"=>"Admin ImmoNatie"}} 
    Message Columns (5.0ms) SHOW FIELDS FROM `messages` 
    User Columns (10.0ms) SHOW FIELDS FROM `users` 
    User Load (0.0ms) SELECT * FROM `users` WHERE (`users`.`id` = '1') AND (users.deleted_at IS NULL) LIMIT 1 
    SQL (0.0ms) BEGIN 
    User Update (0.0ms) UPDATE `users` SET `updated_at` = '2011-08-12 10:01:32', `perishable_token` = 'xxxxxxxxxxx', `last_request_at` = '2011-08-12 10:01:32' WHERE `id` = 1 
    SQL (4.0ms) COMMIT 
    SQL (0.0ms) BEGIN 
DEBUG: GOING TO CHECK CAPTCHA 
DEBUG: FALSE -> BAD CAPTCHA 
    Message Create (0.0ms) INSERT INTO `messages` (`sender_email`, `receiver_user_id`, `receiver_email`, `created_at`, `body`, `opened_by_owner`, `updated_at`, `receiver_name`, `opened_by_sender`, `sender_ip`, `message_thread_id`, `sender_user_id`, `sender_name`) VALUES('[email protected]', 1, '[email protected]', '2011-08-12 10:01:33', 'unsure', NULL, '2011-08-12 10:01:33', 'ImmoNatie', NULL, '127.0.0.1', NULL, 1, 'Admin ImmoNatie') 
    MessageThread Columns (5.0ms) SHOW FIELDS FROM `message_threads` 
    MessageThread Create (1.0ms) INSERT INTO `message_threads` (`last_message_opened_by_sender_id`, `answered`, `initial_sender_user_id`, `created_at`, `initial_sender_email`, `starred`, `updated_at`, `last_message_opened_by_owner_id`, `type_id`, `owner_id`, `property_id`, `first_message_id`, `initial_sender_name`, `initial_sender_phone`, `last_message_id`, `last_message_added_at`) VALUES(213, NULL, 1, '2011-08-12 10:01:33', '[email protected]', 0, '2011-08-12 10:01:33', 0, 174, 1, NULL, 213, 'Admin ImmoNatie', 'xx', 213, '2011-08-12 10:01:33') 
    Message Update (0.0ms) UPDATE `messages` SET `updated_at` = '2011-08-12 10:01:33', `message_thread_id` = 101, `sender_name` = 'Admin ImmoNatie', `created_at` = '2011-08-12 10:01:33', `sender_email` = '[email protected]', `sender_ip` = '127.0.0.1', `sender_user_id` = 1, `receiver_name` = 'ImmoNatie', `receiver_email` = '[email protected]', `body` = 'unsure', `receiver_user_id` = 1 WHERE `id` = 213 
Sent mail to [email protected] 

Date: Fri, 12 Aug 2011 12:01:33 +0200 
From: Notifications <[email protected]> 
To: [email protected] 
Subject: Nieuw contact bericht 
Mime-Version: 1.0 
Content-Type: text/html; charset=utf-8 

Naam: xxxx<br /> 
E-mail: xxxx<br /> 
Telefoon: xxxx<br /> 
<br /> 
Bericht:<br /> 
unsure 
    SQL (3.0ms) COMMIT

在你看，我第一次提交表單（首先創建行動）與「不確定」，在體內援引Mollom一個不確定的結果（這個網站是在development.log開發模式）。

如預期的那樣，第一次創建操作的驗證失敗。

但是當我用空的驗證碼驗證碼重新提交表單時，驗證方法返回false，但驗證沒有，因爲保存是持續的，COMMITTED結束。

爲什麼此驗證不會失敗並中斷（回滾）創建操作？

感謝，邁克爾

來源

2011-08-11 Michael Torfs

return退出該方法。你如何確定它超出了代碼？我沒有看到一個調試聲明...我的猜測是它可能會運行兩次，在後續運行時使用不同的代碼路徑... – DGM

嗨DGM，看起來你是對的。我添加了一些更多的logger.debug行，我還添加了日誌。在日誌中，您看到我首先調用不確定的消息檢測（第一個創建操作），然後用空驗證碼驗證重新調用表單以調用新的失敗。你看到在日誌中檢測到錯誤的驗證碼：'DEBUG：FALSE - > BAD CAPTCHA'，所以它應該返回false。該方法確實退出，但驗證不會失敗。因爲你看到一封郵件正在發送，然後是COMMIT。那麼問題就來了，爲什麼驗證不會破壞記錄的保存？ –

我重寫了這個問題，並在DGM的評論之後更改了標題。 –

發現問題。錯誤的驗證是不夠的。我需要添加一個錯誤：errors.add（：body，「error message」）。這個錯誤與返回錯誤一起完成了這項工作。

來源

2011-08-12 22:02:23

軌道，當它應該

回答

相關問題