如果Else語句語法錯誤

Question

我有以下函數，用文字說明並驗證它們。如果它們有效，則將它們插入到數據庫中。一旦插入，檢查它們是否被成功插入。如果不返回false。如果電子郵件無效，首先返回false。 Eclipse + Aptana插件報告最後一個部分的語法錯誤。當我試圖合理化代碼時，它似乎應該正常運行。我可以確認所有{括號}的是在正確的等級秩序

下面是代碼：

public function storeUser($name, $email, $password) { 
    $uuid = uniqid('', true); 
    $hash = $this->hashSSHA($password); 
    $encrypted_password = $hash["encrypted"]; // encrypted password 
    $salt = $hash["salt"]; // salt 
    if((filter_var($email, FILTER_VALIDATE_EMAIL)) && preg_match('/@.+\./', $email)); { //validate the email 
    $result = mysql_query("INSERT INTO users(unique_id, name, email, encrypted_password, salt, created_at) VALUES('$uuid', '$name', '$email', '$encrypted_password', '$salt', NOW())"); 

    // check for successful store 
    if ($result) { 
     // get user details 
     $uid = mysql_insert_id(); // last inserted id 
     $result = mysql_query("SELECT * FROM users WHERE uid = $uid"); 
     // return user details 
     return mysql_fetch_array($result); 
    } else { 
     return false; //unsuccessful store 
    } 
    else { //THIS IS LINE 45 
     //not a valid email 
     return false; 
    } 
    } 
} 

它返回以下錯誤：

05-23 11:07:10.758: E/JSON(1601): <b>Parse error</b>: syntax error, unexpected T_ELSE in <b>/home/content/40/8529140/html/webapps/projects/functions/DB_Functions.php</b> on line <b>45</b><br /> 
05-23 11:07:10.758: E/JSON Parser(1601): Error parsing data org.json.JSONException: Value <br of type java.lang.String cannot be converted to JSONObject 

Answer 1

你的else聲明對於右花括號是錯誤的。如果您在第二個else之前移動其中一個}，它將起作用。其實也許不會，你也有一個流浪的;，但其他建議仍然存在。

如果您更加一致地縮進您的代碼，您將不會被這類問題困擾。

public function storeUser($name, $email, $password) { 
    $uuid = uniqid('', true); 
    $hash = $this->hashSSHA($password); 
    $encrypted_password = $hash["encrypted"]; // encrypted password 
    $salt = $hash["salt"]; // salt 
    if (//validate the email 
     filter_var($email, FILTER_VALIDATE_EMAIL) && 
     preg_match('/@.+\./', $email) 
     ) { 
     $result = mysql_query (
      "INSERT INTO users(unique_id, name, email, encrypted_password, salt, created_at) VALUES('$uuid', '$name', '$email', '$encrypted_password', '$salt', NOW())" 
     ); 
     if ($result) { // check for successful store 
      // get user details 
      $uid = mysql_insert_id(); // last inserted id 
      $result = mysql_query("SELECT * FROM users WHERE uid = $uid"); 
      // return user details 
      return mysql_fetch_array($result); 
     } else { 
      return false; //unsuccessful store 
     } 
    } else { 
     //not a valid email 
     return false; 
    } 
} 

另外：不要使用mysql_*函數。學習使用PDO和參數化查詢。

Answer 2

if((filter_var($email, FILTER_VALIDATE_EMAIL)) 
     && preg_match('/@.+\./', $email)); { //<<<REMOVE THE ; 

Answer 3

你爲什麼最後有兩塊else {}塊......？你只能有一個。

Answer 4

您沒有正確關閉您的括號和你有外if後多餘的分號：

if((filter_var($email, FILTER_VALIDATE_EMAIL)) && preg_match('/@.+\./', $email)) { //validate the email 
    $result = mysql_query("INSERT INTO users(unique_id, name, email, encrypted_password, salt, created_at) VALUES('$uuid', '$name', '$email', '$encrypted_password', '$salt', NOW())"); 

    // check for successful store 
    if ($result) { 
     // get user details 
     $uid = mysql_insert_id(); // last inserted id 
     $result = mysql_query("SELECT * FROM users WHERE uid = $uid"); 
     // return user details 
     return mysql_fetch_array($result); 
    } else { 
    return false; //unsuccessful store 
    } 
} // close of outer if 
else { 
    //not a valid email 
    return false; 
}  

Answer 5

你看到的這一端小分號？ if((filter_var($email, FILTER_VALIDATE_EMAIL)) && preg_match('/@.+\./', $email));

Answer 6

您錯位了一個支架。試試這個

public function storeUser($name, $email, $password) { 
    $uuid = uniqid('', true); 
    $hash = $this->hashSSHA($password); 
    $encrypted_password = $hash["encrypted"]; // encrypted password 
    $salt = $hash["salt"]; // salt 
    if((filter_var($email, FILTER_VALIDATE_EMAIL)) && preg_match('/@.+\./', $email)) { //validate the email 
    $result = mysql_query("INSERT INTO users(unique_id, name, email, encrypted_password, salt, created_at) VALUES('$uuid', '$name', '$email', '$encrypted_password', '$salt', NOW())"); 

    // check for successful store 
    if ($result) { 
     // get user details 
     $uid = mysql_insert_id(); // last inserted id 
     $result = mysql_query("SELECT * FROM users WHERE uid = $uid"); 
     // return user details 
     return mysql_fetch_array($result); 
    } else { 
     return false; //unsuccessful store 
    } 
    } 
    else { 
     //not a valid email 
     return false; 
    } 

}