如何使用動態表名更新表？

Question

我想更新動態生成的表格列。

我想這

ALTER PROCEDURE [dbo].[spname] 
    @Id INT , 
    @Flag varchar(MAX), 
    @TableName nvarchar(max) , 
AS 
BEGIN  
    IF(@Flag='Process') 
    BEGIN 
    DECLARE @squery nvarchar(max) = '' 

    IF EXISTS(SELECT NAME FROM [DZ_REPO].SYS.TABLES WHERE NAME = @TABLENAME) 
     BEGIN 
      set @squery = 'use [DZ_REPO]' 
      set @squery += 'UPDATE A SET A.cFirstName=B.FN, A.cLastName=B.LN, A.cAddress=B.ADDR, A.cCity=B.CITY, A.cState=B.ST, A.cZIP=B.ZIP, 
      A.cGender=B.GENDER, A.cAge=B.EXACT_AGE, A.cHouseholdIncomeCode=B.HH_INCOME FROM [dbo].['+@TableName+'] as A, [Consumer].[dbo].[CONSUMERDB] as B 
      WHERE A.Email=B.Email AND A.AccountId =('+ @Id+')'   
      print (@squery) 

      set @squery += 'UPDATE A SET A.cGender=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cGender=B.[Key] AND B.[Column]=N'Gender' AND A.AccountId = ('+@Id+') 

      UPDATE A SET A.cHouseholdIncome=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cHouseholdIncomeCode=B.[Key] AND B.[Column]=('+HouseholdIncome+') AND A.AccountId = ('+@Id+') 

      UPDATE A SET A.cPresenceOfChild=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cPresenceOfChild=B.[Key] AND B.[Column]=('+PresenceOfChild+') AND A.AccountId = ('+@Id+')' 
     END 
    END 
END 

但它給錯誤，指出

Msg 156, Level 15, State 1, Procedure spFileProcess, Line 6 Incorrect syntax near the keyword 'AS'. Msg 102, Level 15, State 1, Procedure spFileProcess, Line 26 Incorrect syntax near 'Gender'. Msg 102, Level 15, State 1, Procedure spFileProcess, Line 48 Incorrect syntax near 'False'

我編輯通過

ALTER PROCEDURE [dbo].[spname] 
    @Id INT = 1 , 
    @Flag varchar(MAX) = 'Process', 
    @TableName nvarchar(max) = 'SONY' 
AS 
BEGIN  
    IF(@Flag='Process') 
    BEGIN 
    DECLARE @squery nvarchar(max) = '' 
    print ('call') 
    IF EXISTS(SELECT NAME FROM [DZ_REPO].SYS.TABLES WHERE NAME = @TABLENAME) 
     BEGIN 
      set @squery = 'use [DZ_REPO]' 
      print (@squery) 
      set @squery += 'UPDATE A SET A.cFirstName=B.FN, A.cLastName=B.LN, A.cAddress=B.ADDR, A.cCity=B.CITY, A.cState=B.ST, A.cZIP=B.ZIP, 
      A.cGender=B.GENDER, A.cAge=B.EXACT_AGE, A.cHouseholdIncomeCode=B.HH_INCOME FROM [dbo].['+@TableName+'] as A, [Consumer].[dbo].[CONSUMERDB] as B 
      WHERE A.Email=B.Email AND A.AccountId =('+ @Id+')'   
      print (@squery) 

      set @squery += 'UPDATE A SET A.cGender=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cGender=B.[Key] AND B.[Column]=N'Gender' AND A.AccountId = ('+@Id+') 

      UPDATE A SET A.cHouseholdIncome=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cHouseholdIncomeCode=B.[Key] AND B.[Column]=('+HouseholdIncome+') AND A.AccountId = ('+@Id+') 

      UPDATE A SET A.cPresenceOfChild=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cPresenceOfChild=B.[Key] AND B.[Column]=('+PresenceOfChild+') AND A.AccountId = ('+@Id+')' 
     END 
    END 
END 

，但沒有一個打印是通話和錯誤拋folling

消息207，級別16，狀態1，過程spFileProcess，第28行 列名稱'Gender'無效。 消息207，級別16，狀態1，過程spFileProcess，行30 無效的列名稱'HouseholdIncome'。 消息207，級別16，狀態1，過程spFileProcess，行32 無效的列名稱'PresenceOfChild'。

雖然這coumn已經在MT表

任何解決方案？

Answer 1

您需要在第一個更新語句和第二個更新語句之間有空格。

...A.AccountId =('+ @Id+')' and set @squery += 'UPDATE A.... 

應改爲

...A.AccountId =('+ @Id+')' and set @squery += ' UPDATE A... 

這將是容易調試，如果你print的dynamic Sql execution之前。您正在中間打印@squery，即使在您添加更新語句之後，所以更好的爲print，並在追加所有update statements後進行檢查。

varchar列值也應該包含single quotes。

確保你通過值所有variables否則你@squery將NULL

set @squery = 'use [DZ_REPO]' 

set @squery += 'UPDATE A SET A.cFirstName=B.FN, A.cLastName=B.LN, A.cAddress=B.ADDR, A.cCity=B.CITY, A.cState=B.ST, A.cZIP=B.ZIP, 
      A.cGender=B.GENDER, A.cAge=B.EXACT_AGE, A.cHouseholdIncomeCode=B.HH_INCOME FROM [dbo].['+@TableName+'] as A, [Consumer].[dbo].[CONSUMERDB] as B 
      WHERE A.Email=B.Email AND A.AccountId =('+ @Id+')'   
      print (@squery) 

set @squery += 'UPDATE A SET A.cGender=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B 
       WHERE A.cGender=B.[Key] 
       AND B.[Column]=N'''Gender''' --Here 
       AND A.AccountId = ('+@Id+') 

UPDATE A SET A.cHouseholdIncome=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B 
WHERE A.cHouseholdIncomeCode=B.[Key] 
AND B.[Column]=('''+HouseholdIncome+''') 
AND A.AccountId = ('+@Id+') 

UPDATE A SET A.cPresenceOfChild=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B 
WHERE A.cPresenceOfChild=B.[Key] 
AND B.[Column]=('''+PresenceOfChild+''') --here 
AND A.AccountId = ('+@Id+')' 

Answer 2

我覺得你需要增加空間在你的查詢字符串這樣

set @squery = 'use [DZ_REPO] ' 
set @squery += 'UPDATE A SET A.cFirstName......' 

和刪除， @TableName nvarchar(max)

Answer 3

First E rror：從@TableName nvarchar（max）變量的末尾刪除逗號（，）。 第二個錯誤：如果您傳遞一些動態值，則需要聲明Gender，HouseholdIncome，HouseholdIncome，PresenceOfChild。或者如果這是列名，那麼從中刪除+（加號）。

ex： AND B.[專欄] =（HouseholdIncome）

Answer 4

檢查此SQL與評論（這是你的第一個SQL後）：

ALTER PROCEDURE [dbo].[spname] 
    @Id INT , 
    @Flag varchar(MAX), 
    @TableName nvarchar(max), --remove comma from here 
AS 
BEGIN  
    IF(@Flag='Process') 
    BEGIN 
    DECLARE @squery nvarchar(max) = '' 

    IF EXISTS(SELECT NAME FROM master.SYS.TABLES WHERE NAME = @TABLENAME) 
     BEGIN 
      set @squery = 'use [DZ_REPO]' 
      set @squery += 'UPDATE A SET A.cFirstName=B.FN, A.cLastName=B.LN, A.cAddress=B.ADDR, A.cCity=B.CITY, A.cState=B.ST, A.cZIP=B.ZIP, 
      A.cGender=B.GENDER, A.cAge=B.EXACT_AGE, A.cHouseholdIncomeCode=B.HH_INCOME FROM [dbo].['+@TableName+'] as A, [Consumer].[dbo].[CONSUMERDB] as B 
      WHERE A.Email=B.Email AND A.AccountId =('+ @Id+')'   
      print (@squery) 

      --if 'Gender' id your fixed column then give as below with double comma 
      --HouseholdIncome - where you define this variable and assign it 
      --PresenceOfChild - where you define this variable and assign it 
      set @squery += 'UPDATE A SET A.cGender=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cGender=B.[Key] AND B.[Column]=N''Gender'' AND A.AccountId = ('+@Id+') 

      UPDATE A SET A.cHouseholdIncome=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cHouseholdIncomeCode=B.[Key] AND B.[Column]=('+HouseholdIncome+') AND A.AccountId = ('+@Id+') 

      UPDATE A SET A.cPresenceOfChild=B.[Value] FROM [dbo].['+@TableName+'] as A, [dbo].[abc] as B WHERE A.cPresenceOfChild=B.[Key] AND B.[Column]=('+PresenceOfChild+') AND A.AccountId = ('+@Id+')' 
     END 
    END 
END