需要簡化JavaScript功能（也使用jQuery）

Question

我有一個長期的上傳照片功能，使用隱藏的iFrames，它工作很好，一切都好，這是很多雜亂的代碼，我想使一個乾淨的函數，只有幾行或更少的代碼才能處理。

function fileUpload(form, action_url) 
{ 
// Create the iframe... 
var iframe = document.createElement("iframe"); 
iframe.setAttribute("id","upload_iframe"); 
iframe.setAttribute("name","upload_iframe"); 
iframe.setAttribute("width","0"); 
iframe.setAttribute("height","0"); 
iframe.setAttribute("border","0"); 
iframe.setAttribute("style","width: 0; height: 0; border: none;"); 

// Add to document... 
form.parentNode.appendChild(iframe); 
window.frames['upload_iframe'].name="upload_iframe"; 

iframeId = document.getElementById("upload_iframe"); 

// Add event... 
var eventHandler = function() { 

if (iframeId.detachEvent) 
iframeId.detachEvent("onload", eventHandler); 
else 
iframeId.removeEventListener("load", eventHandler, false); 

// Message from server... 
if (iframeId.contentDocument) { 
content = iframeId.contentDocument.body.innerHTML; 
} else if (iframeId.contentWindow) { 
content = iframeId.contentWindow.document.body.innerHTML; 
} else if (iframeId.document) { 
content = iframeId.document.body.innerHTML; 
} 
if(content) 
{ 
/* THIS CODE SHOULD BE DEFINED IN NEW FUNCTION, AND PLACED HER AUTOMATICALLY- onSuccess() 
$('img.profile-picture').attr("src","photos/"+content+"_200.jpg"); 
$('.post-photo'+cookie('login')).attr("src","photos/"+content+"_55.jpg"); 
$(".add-photo-loading").fadeOut("fast"); 
*/ 
} 
else 
{ 
/*THIS SHOULD ALSO BE DEFINED IN THE NEW FUNCTION - onError() 
$(".add-photo-loading").html("Invalid Filetype"); 
$(".add-photo-loading").attr("class","upload-error"); 
*/ 
} 
// Del the iframe... 
setTimeout('iframeId.parentNode.removeChild(iframeId)', 250); 
} 

if (iframeId.addEventListener) 
iframeId.addEventListener("load", eventHandler, true); 
if (iframeId.attachEvent) 
iframeId.attachEvent("onload", eventHandler); 

// Set properties of form... 
form.setAttribute("target","upload_iframe"); 
form.setAttribute("action", action_url); 
form.setAttribute("method","post"); 
form.setAttribute("enctype","multipart/form-data"); 
form.setAttribute("encoding","multipart/form-data"); 

// Submit the form... 
form.submit(); 
/*THIS SHOULD BE FIRED IMMEDIATELY WHEN THIS FUNCTION IS CALLED BUT THIS CODE SHOULD ALSO BE FIRED ELSEWHERE 
$(".upload-error").attr("class","add-photo-loading"); 
$(".add-photo-loading").html("Uploading..."); 
$(".add-photo-loading").css({"display":"block"}); 
*/ 
} 

好了，所以有代碼在這裏的幾行應該在新的功能來定義，我有/ ** /代碼塊，與是該塊的動作周圍評論。

Answer 1

在這裏你去：

function fileUpload(a, b) { 
var c = document.createElement("iframe"); 
c.setAttribute("id", "upload_iframe"), c.setAttribute("name", "upload_iframe"), c.setAttribute("width", "0"), c.setAttribute("height", "0"), c.setAttribute("border", "0"), c.setAttribute("style", "width: 0; height: 0; border: none;"), a.parentNode.appendChild(c), window.frames.upload_iframe.name = "upload_iframe", iframeId = document.getElementById("upload_iframe"); 
var d = function() { 
    iframeId.detachEvent ? iframeId.detachEvent("onload", d) : iframeId.removeEventListener("load", d, !1), iframeId.contentDocument ? content = iframeId.contentDocument.body.innerHTML : iframeId.contentWindow ? content = iframeId.contentWindow.document.body.innerHTML : iframeId.document && (content = iframeId.document.body.innerHTML), setTimeout("iframeId.parentNode.removeChild(iframeId)", 250) 
}; 
iframeId.addEventListener && iframeId.addEventListener("load", d, !0), iframeId.attachEvent && iframeId.attachEvent("onload", d), a.setAttribute("target", "upload_iframe"), a.setAttribute("action", b), a.setAttribute("method", "post"), a.setAttribute("enctype", "multipart/form-data"), a.setAttribute("encoding", "multipart/form-data"), a.submit() 
} 

Answer 2

一種可能性是使基類具有其中的所有常用功能，然後再創建一個新的類，該類中包含更具體的功能。

例如http://ejohn.org/blog/simple-javascript-inheritance/

Answer 3

Iframe方法它是「不推薦」int 2.0網絡時代。

請忘記innerHTML和其他不標準的方法。

如果你打算使用jquery，這個任務可以讓我更簡單高效。

在這裏，你可以看到它看到這個演示 Jquery Upload File Demo

在這裏，你得到的參考和如何渡 Jquery Upload Documentation