2013-03-01 254 views
3

我使用* .asc文件打開,重新格式化,然後另存爲與原始文件同名的Excel文件(帶有xls擴展名)。將* .asc文件保存爲Excel文件

我用宏記錄器和我在網上找到的代碼打開個別文件並根據需要重新格式化它們。代碼的那部分起作用。

我無法保存爲Excel文件。它給了我Run Time error of 1004 Method ‘SaveAs’ of object ‘_Workbook’ failed。我嘗試了很多我在網上找到的不同代碼(仍然在那裏,只是註釋掉了),但都沒有工作。

兩個問題:

  1. 你能提供的建議來解決問題另存爲?

  2. 您能否提供關於如何自動打開和保存一個文件夾中所有文件的建議?

這裏是我的代碼:

Sub OpenFormatSave() 
' 
' OpenFormatSave Macro 
' 

Dim StrFileName As String 
Dim NewStrFileName As String 
    ChDir _ 
     "C:\Users\Owner\Documents\work_LLRS\GoM\NASA_data\Satellite_files_GoM_3Dec2012" 
    StrFileName = Application.GetOpenFilename("NASA Files (*.asc), *.asc") 
    If TypeName(StrFileName) <> "Boolean" Then 
     Workbooks.OpenText Filename:=StrFileName, _ 
     Origin:=437, StartRow:=1, DataType:=xlDelimited, TextQualifier:= _ 
     xlDoubleQuote, ConsecutiveDelimiter:=True, Tab:=True, Semicolon:=False, _ 
     Comma:=False, Space:=True, Other:=False, FieldInfo:=Array(Array(1, 1), _ 
     Array(2, 1), Array(3, 1), Array(4, 1), Array(5, 1), Array(6, 1), Array(7, 1), Array(8, 1), _ 
     Array(9, 1), Array(10, 1)), TrailingMinusNumbers:=True 
    End If 
    Rows("1:1").Select 
    Selection.Insert Shift:=xlDown, CopyOrigin:=xlFormatFromLeftOrAbove 
    Range("A1").Select 
    ActiveCell.FormulaR1C1 = "Year" 
    Range("B1").Select 
    ActiveCell.FormulaR1C1 = "Day_of_Year" 
    Range("C1").Select 
    ActiveCell.FormulaR1C1 = "Longitude" 
    Range("D1").Select 
    ActiveCell.FormulaR1C1 = "Latitude" 
    Range("E1").Select 
    ActiveCell.FormulaR1C1 = "Chla_mg_m-3" 
    Range("F1").Select 
    ActiveCell.FormulaR1C1 = "POC_mmolC_m-3" 
    Range("G1").Select 
    ActiveCell.FormulaR1C1 = "SPM_g_m-3" 
    Range("H1").Select 
    ActiveCell.FormulaR1C1 = "aCDOM355_m-1" 
    Range("I1").Select 
    ActiveCell.FormulaR1C1 = "DOC_mmolC_m-3" 
    Range("J1").Select 
    ActiveCell.FormulaR1C1 = "L2_flags" 

    Columns("A:B").Select 
    Selection.NumberFormat = "0" 
    Columns("C:D").Select 
    Selection.NumberFormat = "0.0000" 
    Columns("E:E").Select 
    Selection.NumberFormat = "0.000" 
    Columns("F:F").Select 
    Selection.NumberFormat = "0.0" 
    Columns("G:H").Select 
    Selection.NumberFormat = "0.000" 
    Columns("I:I").Select 
    Selection.NumberFormat = "0.0" 
    Columns("J:J").Select 
    Selection.NumberFormat = "0.00E+00" 



'Mid(StrFileName, 1, InStrRev(StrFileName, ".")) = "xlsm" 

'With ActiveWorkbook 
    'NewStrFileName = Replace(.StrFileName, ".asc", ".xls") 
    ' .SaveAs Filename:=FullName, FileFormat:=xlsx, AddToMRU:=False 
    ' .Close SaveChanges:=True 
'End With 

StrFileName = ThisWorkbook.Name 
GetName: 
StrFileName = Application.GetSaveAsFilename(NewStrFileName, _ 
    fileFilter:="(*.xlsm), *.xlsm, (*.xlsx), *.xlsx,(*.xls), *.xls") 

' FileMonth is the Workbook name, filter options to save a older version file 
'If Dir(NewStrFileName) = "" Then 
' ActiveWorkbook.SaveAs NewStrFileName 
'Else 
' If MsgBox("That file exists. Overwrite?", vbYesNo) = vbNo Then GoTo GetName 
    ' Application.DisplayAlerts = False 
    ' ActiveWorkbook.SaveAs Filename:=NewStrFileName, FileFormat:=xlsx, AddToMRU:=False 
    'Application.DisplayAlerts = True 
'End If 
    'ActiveWorkbook.Close SaveChanges:=True 


ActiveWorkbook.SaveAs Filename:=NewStrFileName, FileFormat:=xlsx, CreateBackup:=False 

'With ThisWorkbook 
    'FullName = Replace(.StrFileName, ".asc", ".xlsx") 
    '.Save 
    '.SaveAs StrFileName, FileFormat:=xlsx 
    '.Close 
    'SaveChanges:=True 
'End With 



'StrFileName = Split(ActiveWorkbook.FullName, ".xls")(0) 

'ActiveWorkbook.SaveAs Filename:="...", FileFormat:=xlsx, AddToMRU:=False 
'ActiveWorkbook.Close SaveChanges:=True 

'ActiveWorkbook.Save 
End Sub 

回答

3

更改你的另存爲的方法來此的FileFormat部分:

FileFormat:=xlOpenXMLWorkbook, CreateBackup:=False 
0

要通過的所有文件夾中的迭代,你有兩個選擇。

  1. 使用built-in VBA Dir function
  2. 使用方法FileSystemObject

我將給出一個Dir的例子,因爲它不需要在你的VBA項目中添加一個引用。不幸的是,Dir界面比FileSystemObject更不直觀,也不現代。

Dim path As String 

path = Dir("C:\Users\example\Documents\AscFiles\*.asc") 
Do 
    If path = vbNullString Then Exit Do 

    ' do something with path here 
    Debug.Print path 

    path = Dir 
Loop 
0

你有兩個變量StrFileName(大概是打算作爲當前文件名)和NewStrFileName(大概意欲在新的文件名)。

在這段代碼:

StrFileName = Application.GetSaveAsFilename(NewStrFileName, _ 
    fileFilter:="(*.xlsm), *.xlsm, (*.xlsx), *.xlsx,(*.xls), *.xls") 

已全面使用這些變量走錯了路。 「另存爲」對話框打開時的建議文件名基於NewStrFileName,但從未給出該值,因此爲空字符串""。然後由用戶選擇的值保存到StrFileName

當你保存文件與此代碼:

ActiveWorkbook.SaveAs Filename:=NewStrFileName, FileFormat:=xlsx, _ 
    CreateBackup:=False 

NewStrFileName變量仍然包含"",因此您要保存文件不給它是一個明顯產生錯誤的名稱。

對於一個簡單的修復,只是交換的呼叫中的兩個變量來GetSaveAsFilename

NewStrFileName = Application.GetSaveAsFilename(StrFileName, _ 
    fileFilter:="(*.xlsm), *.xlsm, (*.xlsx), *.xlsx,(*.xls), *.xls") 

這是不是達到你想要什麼是最好的方式,但它至少應該工作