有沒有更好的方法，然後使用多個條件？

Question

我有一個php類的方法，它確定是否一個類屬性有任何價值。如果它包含任何值，那麼它將驗證並迭代$ this-> error類屬性。這裏是我正在使用的類方法。

public function validate() { 
    if(!empty($this->name)) { 
     if(!preg_match('/^[a-zA-z ]{3,50}$/',$this->name)) { 
      $this->error['name'] = 'Name should be valid letters and should be between 3 and 25 characters'; 
     } 
    } 
    if(!empty($this->email)) { 
     if(!filter_var($this->email,FILTER_VALIDATE_EMAIL)) { 
      $this->error['invalidEmail'] = 'Invalid email address'; 
     } 
     if(empty($this->userId) && $this->emailCount($this->email)) { 
      $this->error['emailExist'] = 'Email already exist'; 
     } 
    } 
    if(empty($this->userId) && !empty($this->password)) { 
     if(strlen($this->password) < 5 || strlen($this->password > 40)) { 
      $this->error['password'] = 'Password length should be between 5 and 40 characters'; 
     } 
    } 
    if(!empty($this->userId) && !empty($this->newPassword)) { 
     if(strlen($this->newPassword) < 5 || strlen($this->newPassword > 40)) { 
      $this->error['password'] = 'Password length should be between 5 and 40 characters'; 
     } 
    } 
    if(!empty($this->pPhone)) { 
     if(!preg_match('/^[0-9]{5,10}$/',$this->pPhone)) { 
      $this->error['invalidpPhone'] = 'Invalid primary phone number'; 
     } 
    } 
    if(!empty($this->sPhone)) { 
     if(!preg_match('/^[0-9]{5,10}$/',$this->sPhone)) { 
      $this->error['invalidsPhone'] = 'Invalid secondary phone number'; 
     } 
    } 
    return (empty($this->error)) ? true : false;  
} 

我已經使用很多，如果在這裏，我認爲情況不是很好，還有沒有其他的辦法可以判斷上述條件並以更更好的方式重寫代碼？

Answer 1

您可以使用變量變量並循環遍歷代碼。但是，這意味着你必須拿出某種標準化的驗證方案，爲您的代碼

$validateFields = array('email', 'username', 'userId'); //list of fields to validate 
$rules = array(
    'username' => array('type'=> 'regex', 'rule' => '/^[a-zA-z ]{3,50}$/'), 
    'email' => array('type' => 'filter', 'rule' => 'FILTER_VALIDATE_EMAIL') 
); 

foreach ($validateFields as $field) { 
    if (isset($rules[$field])) { 
     switch ($rules[$field]['type']) { 
      case 'regex' : 
       if(!preg_match($rules[$field]['type']['rule'],$this->$field)) { 
        $this->error[$field] = ucfirst($field) . ' should be valid letters and should be between 3 and 25 characters'; 
       } 
       break; 

      case 'filter' : 
       if(!filter_var($this->$field, $rules[$field]['type']['rule'])) { 
        $this->error[$field] = 'Invalid email address'; 
       } 
       break 

      //more cases 
     } 
    } 
} 
return (empty($this->error)) ? true : false; 

本例僅使用每場一個規則，但你應該能夠很容易地擴展它使用每多個規則領域。

您最初必須設置所有規則，但驗證不會因爲您將另一個屬性添加到您的類中而增大。

Answer 2

，如果你想LES用的，如果條件可以使用選擇的情況下與if塊

線 情況1 如果塊

情況下2 如果塊

如果將幫助您在更好的方法

Answer 3

我不認爲你可以用更好的方式重寫這個特定的代碼。

但是，從更大的圖片看有可能的改進。看看類變量，這可能是某種形式的類或模型實例，並且您在保存數據之前試圖驗證數據。您可以在單獨的類中概括並抽象驗證邏輯。爲了獲得靈感，請看看各種PHP框架（例如Symphony，CakePHP）如何處理表單和模型驗證。

Answer 4

我不認爲你可以避免這個多重If If Statements，因爲我看到這個是你驗證字段。

爲multimple其他替代if語句是SWTICH聲明，

我不知道這是針對這種情況可行的，因爲你逝去的字符串作爲參數，其中作爲開關不會採取字符串作爲參數，它只需要整數作爲輸入

Answer 5

下面是一個更加整潔的代碼解決方案的樣機，我沒有編譯它，因爲..這不是我的生活的工作，但它絕對是你想要採取的路徑，因爲你有太多的重複自己在你的代碼中。

但是，這與您現在正在做的非常接近，我只是丟失了一些ID檢查和其他各種代碼，您必須重新實施。

另外，我的假設，這是一個類中已經這樣做了，並且你所訪問類變量$this->name

<?php 

public function validate() { 
    //You can place your simple ID checks around these wherever they're supposed to go, I lost them ;P. 
    //This code probably won't compile without errors, but it's to give you a much neater idea. 
    //Never ever repeat code !!! Your life becomes so much better :] 
    $this->validate_name($this->name); 
    $this->validate_email($this->email); // I didn't complete this one.. but this is just all for an idea 


    $this->validate_phone_number($this->pPhone,'Primary'); 
    $this->validate_phone_number($this->sPhone,'Secondary'); 

    return (empty($this->error)) ? true : false;  
} 

function validate_password($password){ 
    !empty($password)) { 
     if(strlen($password) < 5 || strlen($password > 40)) { 
      $this->error['password'] = 'Password length should be between 5 and 40 characters'; 
     } 
} 

function validate_name($name){ 
     if(!preg_match('/^[a-zA-z ]{3,50}$/',$name)) { 
      $this->error['name'] = 'Name should be valid letters and should be between 3 and 25 characters'; 
     } 
} 

function validate_phone_number($number,$type){ 
    if(!preg_match('/^[0-9]{5,10}$/',number)) { 
      $this->error['invalidsPhone'] = "Invalid $type phone number"; 
     } 
} 

Answer 6

首先，你應該提取你的錯誤字符串轉換爲定義，或更好，類常量。

define('ERR_BAD_NAME','Name should be valid letters and should be between 3 and 25 characters'); 
define('ERR_BAD_EMAIL','Invalid email address'); 
define('ERR_EMAIL_IN_USE','Email already exist'); 
define('ERR_BAD_PASSWD','Password length should be between 5 and 40 characters'); 
define('ERR_BAD_PRIMARY_PHONE','Invalid primary phone number'); 
define('ERR_BAD_SECONDARY_PHONE','Invalid primary phone number'); 

public function validate() { 
    if(!empty($this->name)) { 
     if(!preg_match('/^[a-zA-z ]{3,50}$/',$this->name)) { 
      $this->error['name'] = ERR_BAD_NAME; 
     } 
    } 
    if(!empty($this->email)) { 
     if(!filter_var($this->email,FILTER_VALIDATE_EMAIL)) { 
      $this->error['invalidEmail'] = ERR_BAD_EMAIL; 
     } 
     if(empty($this->userId) && $this->emailCount($this->email)) { 
      $this->error['emailExist'] = ERR_EMAIL_IN_USE; 
     } 
    } 
    if(empty($this->userId) && !empty($this->password)) { 
     if(strlen($this->password) < 5 || strlen($this->password > 40)) { 
      $this->error['password'] = ERR_BAD_PASSWD; 
     } 
    } 

    if(!empty($this->pPhone)) { 
     if(!preg_match('/^[0-9]{5,10}$/',$this->pPhone)) { 
      $this->error['invalidpPhone'] = ERR_BAD_PRIMARY_PHONE; 
     } 
    } 
    if(!empty($this->sPhone)) { 
     if(!preg_match('/^[0-9]{5,10}$/',$this->sPhone)) { 
      $this->error['invalidsPhone'] = ERR_BAD_PRIMARY_PHONE; 
     } 
    } 
    return (empty($this->error)) ? true : false;  
} 

第二步是重構測試爲單獨的私有方法和擺脫如果塊：

private function validate_name($name) { 
    return = empty($name) || preg_match('/^[a-zA-z ]{3,50}$/',$name); 
} 

private function validate_phone($phone) { 
    return empty($phone) || preg_match('/^[0-9]{5,10}$/',$phone); 
} 

private function validate_email($email) { 
    return empty($email)) || filter_var($email,FILTER_VALIDATE_EMAIL); 
} 

private function emailInUse($email, $userId) { 
    if(!empty($email)) { 
     if(empty($this->userId) && $this->emailCount($this->email)) { 
      $this->error['emailExist'] = ERR_EMAIL_IN_USE; 
     } 
    } 
} 

private function validate_userPassword($userId, $password) { 
    $passwordLen=strlen($this->password); 
    return (empty($this->userId) && !empty($this->password)) || 
      (5 <= $passwordLen) && (40 >= $passwordLen); 
} 

private function lor_error($type, $message) { 
    $this->error[$type] = $message; 
    return false; 
} 

public function validate() { 
    $isValid = true; 
    $isValid &= $this->validate_name($this->name) || 
       $this->logError('name',ERR_BAD_NAME); 
    $isValid &= $this->validate_email($this->email) || 
       $this->logError('invalidEmail',ERR_BAD_EMAIL); 
    $isValid &= $this->emailInUse($this->userId, $this->email) || 
       $this->logError('emailExist',ERR_EMAIL_IN_USE); 
    $isValid &= $this->validateUserPassword($this->userId, $this->password) || 
       $this->log('password', ERR_BAD_PASSWD); 
    $isValid &= $this->validate_phone($this->pPhone) || 
       $this->log('invalidpPhone',ERR_BAD_PRIMARY_PHONE); 
    $isValid &= $this->validate_phone($this->sPhone) || 
       $this->log('invalidsPhone',ERR_BAD_SECONDARY_PHONE); 
    return $isValid; 
} 

在第三重構階段，你應該提取validate_ *方法爲驗證器類從主類中分離驗證任務。後一階段顯然取決於你（作爲定義適當日誌類的負擔）。