用貓鼬保存數組數據的清潔代碼

Question

我創建了一個函數來將數據保存到下面的邏輯中的mongoDB，但我真的很難重構代碼並使其更清潔，有太多令人討厭的代碼重複，我該怎麼辦DRY原則？

邏輯： 1.傳遞一個標誌來決定在結束時是否關閉數據庫連接。 2.根據傳入的returnedArray創建不同的mongoDB模型並保存到數據庫中。

var saveArrayToDB = function(returnedArray, flagToCloseDBConnection) { 
    var objectToSave, 
     object, 
     type = returnedArray[0].type, 
     arrayToSave = []; 

    if (type === 'user') { 
     for (var i = 0; i < returnedArray.length; i++) { 
      object = returnedArray[i]; 
      objectToSave = new User({ 
       fullName: object['full_name'], 
       activatedAt: object['activated_at'], 
       location: object['location'], 
       timezone: object['timezone'], 
       imageURL: object['mugshot_url'], 
       stats: object['stats'] 
      }); 
      arrayToSave.push(objectToSave); 
     } 

     User.create(arrayToSave, function(err) { 
      if (err) { 
       console.log('err ' + err); 
      } 
      if(flagToCloseDBConnection) { 
       mongoose.connection.close(); 
      } 
     }); 
    } else if (type === 'group') { 
     for (var j = 0; j < returnedArray.length; j++) { 
      object = returnedArray[j]; 
      objectToSave = new Group({ 
       fullName: object['full_name'], 
       createdAt: object['created_at'], 
       stats: object['stats'], 
       url: object['web_url'] 
      }); 
      arrayToSave.push(objectToSave); 
     } 

     Group.create(arrayToSave, function(err) { 
      if (err) { 
       console.log('err ' + err); 
      } 
      if(flagToCloseDBConnection) { 
       mongoose.connection.close(); 
      } 
     }); 
    } else { 
     objectToSave = null; 
     console.log('ERROR: unrecognized type in data. Not saved.'); 
    } 

}; 

Answer 1

只是爲了添加到什麼評論了你的問題@JohnnyHK，如果你把你的貓鼬連接您的應用程序生命週期中打開它，將是最好的。除此之外，你可以使用一些JavaScript功能，如map()初始化數組，確定共同的回調函數，你可以在這兩個重用創建和映射方法：

var saveArrayToDB = function(returnedArray, flagToCloseDBConnection) { 
    var type = returnedArray[0].type, 
     arrayToSave = []; 

    var callback = function(err) { 
     if (err) { console.log('err ' + err); } 
    }; 

    var newUser = function(u){ 
     return new User({ 
      fullName: u['full_name'], 
      activatedAt: u['activated_at'], 
      location: u['location'], 
      timezone: u['timezone'], 
      imageURL: u['mugshot_url'], 
      stats: u['stats'] 
     }); 
    }; 

    var newGroup = function(g){ 
     return new Group({ 
      fullName: g['full_name'], 
      createdAt: g['created_at'], 
      stats: g['stats'], 
      url: g['web_url'] 
     }); 
    }; 


    if (type === 'user') {  
     arrayToSave = returnedArray.map(newUser);  
     User.create(arrayToSave, callback); 
    } else if (type === 'group') { 
     arrayToSave = returnedArray.map(newGroup); 
     Group.create(arrayToSave, callback); 
    } else { 
     console.log('ERROR: unrecognized type in data. Not saved.'); 
    } 

}; 

Answer 2

無需關閉連接。下面是一個已經大爲改善的版本：

var factories = { 
    'user': { 
     method: function(object){ 
      return { 
       fullName: object['full_name'], 
       activatedAt: object['activated_at'], 
       location: object['location'], 
       timezone: object['timezone'], 
       imageURL: object['mugshot_url'], 
       stats: object['stats'] 
      }; 
     }, 
     model: User 
    }, 
    'group': { 
     method: function(object){ 
      return { 
       fullName: object['full_name'], 
       createdAt: object['created_at'], 
       stats: object['stats'], 
       url: object['web_url'] 
      }; 
     }, 
     model: Group 
    } 
} 

var saveArrayToDB = function(returnedArray) { 
    var saveQueue=[], 
     factory = factories[returnedArray[0].type]; 
    if(!factory){ 
     return console.log('ERROR: unrecognized type in data. Not saved.'); 
    } 

    returnedArray.forEach(function(item){ 
     saveQueue.push(factory.method(item)); 
    }); 

    factory.model.create(saveQueue, function(err){ 
     if(err){ 
      console.log('err ' + err); 
     } 
    }); 
}; 

（你並不需要通過文件的情況下，普通的對象是不夠好Model.create）