2011-11-08 59 views
0

如果語句表現怪異。由於某種原因,如果在IF語句中if (choosePositionX)轉到另一個告訴用戶其他玩家已經進行了移動,則它將進入下一個,如果if (choosePositionO)並打印出其中的其他玩家。我該如何做到這一點,一旦它發生在其他任何一方,如果它只是發生並繼續下去。看起來break;不起作用。如果跳轉語句

基本上,第一次使用的其他部分在第二次if語句中轉到第二秒。爲什麼?

#include <iostream> 
using namespace std; 

// Initialize Array to 9 elements. 
// Set array elements 1 to 9 to specify locations for placement of X and O. 
char ticTacBoard[9] = {'1', '2', '3', '4', '5', '6', '7', '8', '9'}; 

// gameState will return 1 to 4. #1. Player X has won, #2. Player Y has won, #3. Draw, #4. Game Not Finished. 
int gameState = 0; 
int choosePositionX = 0; 
int choosePositionO = 0; 
int totalMoves = 0; 

// Functions declared to run game. 
// Checks for winners, draw and if game should continue. 
int checkGameState (int gameState); 
// Takes in users moves. 
void makeMove(); 
// Resets board when game finished. 
void reset(); 
// Prints the board to the user. 
void printBoard(); 


int main() 
{ 
    cout << "Welcome to Tic Tac Toe!" << endl << endl 
     << "The goal of Tic Tac Toe is to be the first player to get three in a row on the grid." << endl << endl 
     << "Please select 1 through 9 to select placement for your turn."<< endl << endl; 

    int gameState = 4; 

    printBoard(); 

    while (gameState == 4) 
    { 
     cout << "Player X please choose a position: "; 
     cin >> choosePositionX; 
     cout << endl; 
     makeMove(); 
     totalMoves = totalMoves + 1; 
     printBoard(); 
     gameState = checkGameState(gameState); 
     if (gameState != 4) 
     { 
      if (gameState == 1) 
      { 
       cout << "Player X has won the game!" << endl << endl; 
       break; 
      } 
      if (gameState == 2) 
      { 
       cout << "Player Y has won the game!" << endl << endl; 
       break; 
      } 
      if (gameState == 3) 
      { 
       cout << "The game is a DRAW!" << endl << endl; 
       break; 
      } 
     } 
     cout << "Player O please choose a position: "; 
     cin >> choosePositionO; 
     cout << endl; 
     makeMove(); 
     totalMoves = totalMoves + 1; 
     printBoard(); 
     gameState = checkGameState(gameState); 
     if (gameState != 4) 
     { 
      if (gameState == 1) 
      { 
       cout << "Player X has won the game!" << endl << endl; 
       break; 
      } 
      if (gameState == 2) 
      { 
       cout << "Player Y has won the game!" << endl << endl; 
       break; 
      } 
      if (gameState == 3) 
      { 
       cout << "The game is a DRAW!" << endl << endl; 
       break; 
      } 
     } 
    } 

    char playAgain; 

    cout << "Would you like to play again? y/n: "; 
    cin >> playAgain; 
    cout << endl; 

    if (playAgain == 'y') 
    { 
     reset(); 
    } 
    else if (playAgain == 'n') 
    { 
     cout << endl; 
     cout << "Thanks for playing!!"; 
     return 0; 
    } 

    return 0; 
} 

void reset() 
{ 
    for (int i = 0; i < 9; i++) 
    { 
     ticTacBoard[i] = 49 + i; 
    } 

    gameState = 0; 
    choosePositionX = 0; 
    choosePositionO = 0; 
    totalMoves = 0; 

    main(); 
} 

int checkGameState(int gameState) 
{ 

////////////// CHECK FOR X ///////////////// 

    // Check Rows 
    if(ticTacBoard[0] == 'X' && ticTacBoard[1] == 'X' && ticTacBoard[2] == 'X') 
    { 
     return 1; 
    } 
    if(ticTacBoard[3] == 'X' && ticTacBoard[4] == 'X' && ticTacBoard[5] == 'X') 
    { 
     return 1; 
    } 
    if(ticTacBoard[6] == 'X' && ticTacBoard[7] == 'X' && ticTacBoard[8] == 'X') 
    { 
     return 1; 
    } 

    // Check Columns 
    if(ticTacBoard[0] == 'X' && ticTacBoard[3] == 'X' && ticTacBoard[6] == 'X') 
    { 
     return 1; 
    } 
    if(ticTacBoard[1] == 'X' && ticTacBoard[4] == 'X' && ticTacBoard[7] == 'X') 
    { 
     return 1; 
    } 
    if(ticTacBoard[2] == 'X' && ticTacBoard[5] == 'X' && ticTacBoard[8] == 'X') 
    { 
     return 1; 
    } 

    // Check Diagonally 
    if(ticTacBoard[0] == 'X' && ticTacBoard[4] == 'X' && ticTacBoard[8] == 'X') 
    { 
     return 1; 
    } 
    if(ticTacBoard[2] == 'X' && ticTacBoard[4] == 'X' && ticTacBoard[6] == 'X') 
    { 
     return 1; 
    } 

////////////// CHECK FOR O ///////////////// 

    // Check Rows 
    if(ticTacBoard[0] == 'O' && ticTacBoard[1] == 'O' && ticTacBoard[2] == 'O') 
    { 
     return 2; 
    } 
    if(ticTacBoard[3] == 'O' && ticTacBoard[4] == 'O' && ticTacBoard[5] == 'O') 
    { 
     return 2; 
    } 
    if(ticTacBoard[6] == 'O' && ticTacBoard[7] == 'O' && ticTacBoard[8] == 'O') 
    { 
     return 2; 
    } 

    // Check Columns 
    if(ticTacBoard[0] == 'O' && ticTacBoard[3] == 'O' && ticTacBoard[6] == 'O') 
    { 
     return 2; 
    } 
    if(ticTacBoard[1] == 'O' && ticTacBoard[4] == 'O' && ticTacBoard[7] == 'O') 
    { 
     return 2; 
    } 
    if(ticTacBoard[2] == 'O' && ticTacBoard[5] == 'O' && ticTacBoard[8] == 'O') 
    { 
     return 2; 
    } 

    // Check Diagonally 
    if(ticTacBoard[0] == 'O' && ticTacBoard[4] == 'O' && ticTacBoard[8] == 'O') 
    { 
     return 2; 
    } 
    if(ticTacBoard[2] == 'O' && ticTacBoard[4] == 'O' && ticTacBoard[6] == 'O') 
    { 
     return 2; 
    } 

    // After 9 moves we call a Draw. Since we should have a winner before that. 
    if (totalMoves >= 9) 
    { 
     return 3; 
    } 

    // Otherwise CONTINUE 
    else 
     return 4; 
} 

void makeMove() 
{ 
    if (choosePositionX) 
    { 
     if (ticTacBoard[choosePositionX - 1] != 'X' && ticTacBoard[choosePositionX - 1] != 'O') 
     { 
      ticTacBoard[choosePositionX - 1] = 'X'; 
     } 
     else 
     { 
      cout << "Player O has already made this move" << endl << endl; 
      // keep same moves for counter draw 
      totalMoves = totalMoves - 1 + 1; 
     } 
    } 

    if (choosePositionO) 
    { 
     if (ticTacBoard[choosePositionO - 1] != 'X' && ticTacBoard[choosePositionO - 1] != 'O') 
     { 
      ticTacBoard[choosePositionO - 1] = 'O'; 
     } 
     else 
     { 
      cout << "Player X has already made this move" << endl << endl; 
      // keep same moves for counter draw 
      totalMoves = totalMoves - 1 + 1; 
     } 
    } 
} 

void printBoard() 
{ 
    for (int y = 0; y < 3; y++) 
    { 
     for (int x = 0; x < 3; x++) 
     { 
      cout << ticTacBoard[3 * y + x] << " "; 
     } 

     cout << endl; 
    } 
    cout << endl; 
} 
+0

爲什麼'choosePositionX'和'choosePositionO'在同一真時間? –

+0

我想通了,我不得不把某些東西設置爲0. – mystycs

+0

@mystycs - 那是因爲choosePositionX總是如此。您應該嘗試將其設置爲false。 –

回答

7

您忘記了連接兩個if s的else。您需要使用:

else if (choosePositionO) 
+1

用於在速度輪中首先擊中蜂鳴器的+1號 – Lou

+3

用於理解問題的+1號 – Mranz

+0

現在它根本不選擇或進入choosePositionO。 – mystycs

4

使用else if

if (condition1) 
{ 
    if (subcond1) { /* ... */ } 
    else { /* ... */ } 
} 
else if (condition2) 
{ 
    if (subcond2) { /* ... */ } 
    else { /* ... */ } 
} 
else 
{ 
    // ... 
} 
+0

然後條件2不適合我在這 – mystycs

+0

沒有 - 我以爲你不想要它?你能更確切地說你想要什麼嗎? –

1

使第二個ifelse if,所以如果choosePositionX是真實的checkPositionO將不檢查。

它看起來像你可以只使用一個變量,如果它們是互斥的。甚至更好的與enum

enum Player { 
    PlayerX 
    , PlayerO 
}; 

enum Player choosePosition; 
1

使第二個如果(choosePosition)

else if(choosePositionO) 

,那麼你可以把一個破