Valgrind調試日誌：無效的讀取大小爲8

Question

最近我決定用valgrind調試我的應用程序。 我解決了很多錯誤，但不能這個。我的代碼

==12205== Invalid read of size 8 
==12205== at 0x37E1864C40: std::_Rb_tree_increment(std::_Rb_tree_node_base*) (in /usr/lib64/libstdc++.so.6.0.8) 
==12205== by 0x40393C: readConfig(std::string) (stl_tree.h:257) 
==12205== by 0x4058BE: main (application.cpp:42) 
==12205== Address 0x5589b88 is 24 bytes inside a block of size 48 free'd 
==12205== at 0x4A05A33: operator delete(void*) (vg_replace_malloc.c:346) 
==12205== by 0x4067AD: std::_Rb_tree<std::string, std::pair<std::string const, std::string>, std::_Select1st<std::pair<std::string const, std::string> >, std::less<std::string>, std::allocator<std::pair<std::string const, std::string> > >::erase(std::_Rb_tree_iterator<std::pair<std::string const, std::string> >, std::_Rb_tree_iterator<std::pair<std::string const, std::string> >) (new_allocator.h:94) 
==12205== by 0x406841: std::_Rb_tree<std::string, std::pair<std::string const, std::string>, std::_Select1st<std::pair<std::string const, std::string> >, std::less<std::string>, std::allocator<std::pair<std::string const, std::string> > >::erase(std::string const&) (stl_tree.h:1215) 
==12205== by 0x403934: readConfig(std::string) (stl_map.h:461) 
==12205== by 0x4058BE: main (application.cpp:42) 

部分：

string config_file; 
if (strlen(getParam("config") . c_str()) > 0) 
{ 
    config_file = getParam("config"); 
} 
else 
    config_file = string("default.conf"); 
if (access(config_file . c_str(), 0) == -1) 
{ 
    printf("Config file \"%s\" not exists\n", config_file . c_str()); 
    exit(1); 
} 
if (!readConfig(config_file)) 
{ 
    printf("Application error: read config file\n"); 
    exit(1); 
} 

串＃42：

if (!readConfig(config_file)) 

請儘量幫助我。

在此先感謝！

更新＃1：

我這麼大的功能:(

bool readConfig(string filename) 
{ 
time_t rawtime; 
struct tm * timeinfo; 
time (&rawtime); 
timeinfo = localtime (&rawtime); 
map<string,string> tmp_buff; 

    ifstream ifs(filename.c_str()); 
    string temp,tmp; 
    int i; 
    unsigned int MAX_MATCH = 40; 
    regex_t re; 
    char *pattern = "([^=]+)=(.+)"; 

    const char* s; 
    map<int,string> matches_tmp; 
    map<string,string>::const_iterator it; 
    char s1[1024]; 
    size_t rm; 
    regmatch_t pmatch[MAX_MATCH]; 
    regcomp(&re, pattern, REG_ICASE|REG_EXTENDED|REG_NOSUB); 
    if ((rm = regcomp (&re, pattern, REG_EXTENDED)) != 0) 
    { 
     printf("Invalid expression:'%s'\n",pattern); 
     return false; 
    } 
    int start[2]={0},end[2]={0},current[2]={0}; 
    char * b; 
    string substr; 
    bool start_time=false,inside_time=false,error=false; 

    while(getline(ifs, temp)) 
    { 
     tmp=trim(temp); 
     tmp=temp; 
     if(strlen(tmp.c_str())==0) continue; 
     s=tmp.c_str(); 


     if(!regexec(&re, s, MAX_MATCH, pmatch, 0)) 
     { 
     for(i=1;i<=2;i++) 
     { 
      strncpy (s1, s + pmatch[i].rm_so, pmatch[i].rm_eo - pmatch[i].rm_so); 
      s1[pmatch[i].rm_eo - pmatch[i].rm_so] = '\0'; 
      matches_tmp[i]=trim((string)s1); 
     } 

     if(matches_tmp[1]==string("start-time")) 
     { 
      substr=matches_tmp[2].substr(0,2); 
      b=new char[substr.length()+1]; 
      strcpy(b, substr.c_str()); 


      if(strlen(b)!=2) continue; 
      start[0]=atoi(b); 
      //free(b); 

      substr=matches_tmp[2].substr(3,2); 
      b=new char[substr.length()+1]; 
      strcpy(b, substr.c_str()); 

      if(strlen(b)!=2) continue; 
      start[1]=atoi(b); 
      start_time=true; 
      continue; 
     } 

     if(matches_tmp[1]==string("end-time")) 
     { 
      start_time=false; 

      substr=matches_tmp[2].substr(0,2); 
      b=new char[substr.length()+1]; 
      strcpy(b, substr.c_str()); 


      if(strlen(b)!=2) error=true; 
      end[0]=atoi(b); 

      substr=matches_tmp[2].substr(3,2); 
      b=new char[substr.length()+1]; 
      strcpy(b, substr.c_str()); 

      if(strlen(b)!=2) error=true; 
      end[1]=atoi(b); 


      if(error) 
      { 
       printf("ERROR1\n"); 
       error=false; 
       continue; 
      } 

      current[0]=timeinfo->tm_hour; 
      current[1]=timeinfo->tm_min; 

      if(end[0]<start[0]) 
      { 
       if(
        (current[0]<start[0] && current[0]>end[0]) || 
        (current[0]==start[0] && current[1]<start[1]) || 
        (current[0]==end[0] && current[1]>end[1]) 
       ) 
       { 
        error=true; 
       } 
      }else 
      { 
       if(
        (current[0]<start[0]) || 
        (current[0]>start[0] && current[0]>end[0]) || 
        (current[0]==start[0] && current[1]<start[1]) || 
        (current[0]==end[0] && current[1]>end[1]) 
       ) 
       { 
        error=true; 
       } 
      } 

      if(error) 
      { 
       error=false; 
       continue; 
      } 

      for (it = tmp_buff.begin(); it != tmp_buff.end(); ++it) 
      { 
       if(config.find(it->first) != config.end()) config.erase(it->first); 
       config[it->first]=it->second; 
       tmp_buff.erase(it->first); 
      } 

     } 
     if(strlen(matches_tmp[1].c_str())==0) continue; 
     if(start_time) 
     { 
      tmp_buff[matches_tmp[1]]=matches_tmp[2]; 
     } 
     else 
      config[matches_tmp[1]]=matches_tmp[2]; 
     } 
    } 
} 

Answer 1

我想你增加一個無效的std::set或std::map迭代道歉這種不正確的程序生成一個類似的valgrind錯誤：

#include <set> 

int main() { 
    std::set<int> s; 
    s.insert(1); 
    s.insert(2); 
    s.insert(3); 

    for(std::set<int>::iterator it = s.begin(); it != s.end(); ++it) { 
    if(*it == 2) s.erase(it); 
    } 
} 

---

編輯：是的，你在做什麼我說：

 for (it = tmp_buff.begin(); it != tmp_buff.end(); ++it) 
    { 
     if(config.find(it->first) != config.end()) config.erase(it->first); 
     config[it->first]=it->second; 
     tmp_buff.erase(it->first); 
    } 

到tmp_buff.erase(it->first)呼叫無效it。但是，你隨後增加它：++it。這是不允許的。

此外，沒有理由撥打config.erase。在config中的條目在下一行被覆蓋時將被隱含銷燬。嘗試：？

 for (it = tmp_buff.begin(); it != tmp_buff.end(); ++it) 
    { 
     config[it->first]=it->second; 
    } 
    tmp_buff.clear();