添加列到存儲過程有條件

Question

我有以下（簡化的）存儲過程：

CREATE FUNCTION [dbo].[UDF_FulfilmentBatch](@FulfilmentID INT) RETURNS 
    @Result TABLE (
      [sequence] INT, 
      membershipid BIGINT, 
      membershipNo VARCHAR(255) 
    ) 
    AS 
    BEGIN 

    DECLARE @_sequence INT 
    DECLARE @_membershipid BIGINT 
    DECLARE @_membershipNo VARCHAR(255) 

    SET @_sequence = 1 

    IF @FulfilmentID = 4 
    BEGIN 
     DECLARE FulfilCursor CURSOR FAST_FORWARD FOR 
      SELECT * from VW_FulfilmentExtract_HH 
    END 
IF @FulfilmentID = 3 
    BEGIN 
     DECLARE FulfilCursor CURSOR FAST_FORWARD FOR 
      SELECT * from VW_FulfilmentExtract_ID 
    END 
    ELSE IF @FulfilmentID = 2 
    BEGIN 
     DECLARE FulfilCursor CURSOR FAST_FORWARD FOR 
      SELECT * from VW_FulfilmentExtract_Art 
    END 
    ELSE 
     DECLARE FulfilCursor CURSOR FAST_FORWARD FOR 
      SELECT * from VW_FulfilmentExtract_Tha 

    OPEN FulfilCursor 

    FETCH NEXT FROM FulfilCursor INTO @_membershipid, @_membershipNo 

    WHILE @@FETCH_STATUS = 0 BEGIN 

     INSERT INTO @Result 
     VALUES (@_sequence, @_membershipid, @_membershipNo) 

     SET @_sequence = @_sequence + 1 

     FETCH NEXT FROM FulfilCursor INTO @_membershipid, @_membershipNo 
    END 

    CLOSE FulfilCursor 
    DEALLOCATE FulfilCursor 

    RETURN 

    END 




    GO 

我的問題是，當FulfilmentID = 4，I灣添加一個額外的場 - 「投放」

如果已經嘗試了以下內容：

CREATE FUNCTION [dbo].[UDF_FulfilmentBatch](@FulfilmentID INT) RETURNS 
     @Result TABLE (
       [sequence] INT, 
       membershipid BIGINT, 
       membershipNo VARCHAR(255) 
     IF @FulfilmentID = 4 
     BEGIN 
     ,Delivery VARCHAR(255) 
     END 
     ) 
     AS 
     BEGIN 

     DECLARE @_sequence INT 
     DECLARE @_membershipid BIGINT 
     DECLARE @_membershipNo VARCHAR(255) 
IF @FulfilmentID = 4 
     BEGIN 
     DECLARE @_Delivery VARCHAR(255) 
     END 

     SET @_sequence = 1 

     IF @FulfilmentID = 4 
     BEGIN 
      DECLARE FulfilCursor CURSOR FAST_FORWARD FOR 
       SELECT * from VW_FulfilmentExtract_HH 
     END 
    IF @FulfilmentID = 3 
     BEGIN 
      DECLARE FulfilCursor CURSOR FAST_FORWARD FOR 
       SELECT * from VW_FulfilmentExtract_ID 
     END 
     ELSE IF @FulfilmentID = 2 
     BEGIN 
      DECLARE FulfilCursor CURSOR FAST_FORWARD FOR 
       SELECT * from VW_FulfilmentExtract_Art 
     END 
     ELSE 
      DECLARE FulfilCursor CURSOR FAST_FORWARD FOR 
       SELECT * from VW_FulfilmentExtract_Tha 

     OPEN FulfilCursor 

     FETCH NEXT FROM FulfilCursor INTO @_membershipid, @_membershipNo 

     WHILE @@FETCH_STATUS = 0 BEGIN 

      INSERT INTO @Result 
      VALUES (@_sequence, @_membershipid, @_membershipNo IF @FulfilmentID=4 BEGIN @_Delivery ) 

      SET @_sequence = @_sequence + 1 

      FETCH NEXT FROM FulfilCursor INTO @_membershipid, @_membershipNo 
     END 

     CLOSE FulfilCursor 
     DEALLOCATE FulfilCursor 

     RETURN 

     END 




     GO 

但這並沒有工作（請原諒任何語法錯誤，這是這麼一個粗略的打字）

表單搜索網頁似乎沒有太多關於此。可以做到嗎？

Answer 1

有很多的問題，在你的代碼：

• 使用SELECT *
• 使用光標
• ...

最後，這是過於複雜，看着很多像應用程序代碼（C＃，JAVA，...）

你想做的事情應該做一個單一的選擇（即在一個集數據的）。列名稱也應列在SELECT和FROM之間。

一種選擇是：

CREATE FUNCTION [dbo].[UDF_FulfilmentBatch](@FulfilmentID INT) RETURNS TABLE 
AS 
RETURN (
    SELECT sequence = ROW_NUMBER() Over(Order By (Select 1)) 
     , _membershipid, membershipNo, delivery 
    FROM VW_FulfilmentExtract_HH 
    WHERE @FulfilmentID = 4 

    UNION ALL 

    SELECT sequence = ROW_NUMBER() Over(Order By (Select 1)) 
     , _membershipid, membershipNo, delivery = NULL 
    FROM VW_FulfilmentExtract_ID 
    WHERE @FulfilmentID = 3 

    UNION ALL 

    SELECT sequence = ROW_NUMBER() Over(Order By (Select 1)) 
     , _membershipid, membershipNo, delivery = NULL 
    FROM VW_FulfilmentExtract_Art 
    WHERE @FulfilmentID = 2 

    UNION ALL 

    SELECT sequence = ROW_NUMBER() Over(Order By (Select 1)) 
     , _membershipid, membershipNo, delivery = NULL 
    FROM VW_FulfilmentExtract_Tha 
    WHERE @FulfilmentID = not in (2, 3, 4) 
); 

這裏我用ROW_NUMBER生成您的序列號。

我添加了遞送列，並在不需要時將其設置爲NULL。

您必須更新列名稱。我只是猜測他們。

順便說一句，這不是一個存儲過程，但一個Inline User-Defined Functions