2015-09-27 31 views
-4

有沒有辦法讓生成我的按鈕的代碼更短?有人可以告訴我該怎麼做嗎?有任何想法嗎?縮短代碼或使代碼對我的計算器更簡潔?

Clear = Button(buttons, bg="snow", text="C", width=7, height=1, command=self.clear, relief=RAISED) 
    Clear.grid(padx=2, pady=2, column=3, row=0) 
    Equals = Button(buttons, bg="snow", text="=", width=7, height=1, command=self.equals, relief=RAISED) 
    Equals.grid(padx=2, pady=2, column=4, row=3) 
    All_clear = Button(buttons, bg="snow", text="AC", width=7, height=1, command=self.all_clear, relief=RAISED) 
    All_clear.grid(padx=2, pady=2, column=4, row=0) 
    Bracket_one = Button(buttons, bg="snow", text="(", width=7, height=1, command=self.bracket_one, relief=RAISED) 
    Bracket_one.grid(padx=2, pady=2, column=2, row=3) 
    Bracket_two = Button(buttons, bg="snow", text=")", width=7, height=1, command=self.bracket_two, relief=RAISED) 
    Bracket_two.grid(padx=2, pady=2, column=3, row=3) 
    Zero = Button(buttons, bg="snow", text="0", width=7, height=1, command=self.zero, relief=RAISED) 
    Zero.grid(padx=2, pady=2, column=0, row=3) 
    Decimal_point = Button(buttons, bg="snow", text=".", width=7, height=1, command=self.decimal_point, relief=RAISED) 
    Decimal_point.grid(padx=2, pady=2, column=1, row=3) 
    Multiplication = Button(buttons, bg="red", text="x", width=7, height=1, command=self.multiplication, relief=RAISED) 
    Multiplication.grid(padx=2, pady=2, column=3, row=1) 
    Division = Button(buttons, bg="powder blue", text="/", width=7, height=1, command=self.division, relief=RAISED) 
    Division.grid(padx=2, pady=2, column=4, row=1) 
    Addition = Button(buttons, bg="yellow", text="+", width=7, height=1, command=self.addition, relief=RAISED) 
    Addition.grid(padx=2, pady=2, column=3, row=2) 
    Subtraction = Button(buttons, bg="green", text="-", width=7, height=1, command=self.subtraction, relief=RAISED) 
    Subtraction.grid(padx=2, pady=2, column=4, row=2) 
+0

如果這是**工作代碼**,您認爲可以改進,請考慮[codereview.se] – jonrsharpe

回答

1

使用帶有參數列表:

buttons = [ 
    dict(column=3, row=0, text="C", command=self.clear), 
    dict(column=4, row=3, text="=", command=self.equals), 
    dict(column=4, row=0, text="AC", command=self.all_clear), 
    dict(column=2, row=3, text="(", command=self.bracket_one), 
    dict(column=3, row=3, text=")", command=self.bracket_two), 
] 
for data in buttons: 
    button = Button(buttons, bg="snow", text=data['text'], width=7, height=1, command=data['command'], relief=RAISED) 
    button.grid(padx=2, pady=2, column=data['column'], row=data['row']) 
+1

爲什麼不用'**'解壓每個'dict'? – TigerhawkT3

+0

這可能不是一個好主意,因爲它看起來是OP的Button按鈕網格的根部件。 –

+0

@ TigerhawkT3:因爲有些字段需要傳遞給'Button'構造函數,有些字段需要傳遞給按鈕的'.grid'方法。 –

0

作爲修改的替代丹尼爾的解決方案:

buttons = [ 
    ({'text':"C", 'command':self.clear}, {'column':3, 'row':0}), 
    ({'text':"=", 'command':self.equals}, {'column':4, 'row':3}), 
    ({'text':"AC", 'command':self.all_clear}, {'column':4, 'row':0}), 
    ({'text':"(", 'command':self.bracket_one}, {'column':2, 'row':3}), 
    ({'text':")", 'command':self.bracket_two}, {'column':3, 'row':3}) 
] 
for data in buttons: 
    button = Button(buttons, width=7, height=1, relief=RAISED, **data[0]) 
    button.grid(padx=2, pady=2, **data[1]) 

這將抓住適當的字典並解壓其內容爲關鍵字參數。其中一個好處是,您可以將一個bitmap添加到其中一個按鈕,而無需將其中一個添加到其他按鈕中。