Refactor Rails ActiveRecord根據條件

Question

我有以下幾點。如何以最佳方式重構它：

def self.search(search, organization_id, is_admin) 
    if is_admin == false 
     where("record_no LIKE ?", "%#{search}%"). 
     where("organization_id = ?", organization_id) 
    else 
     where("record_no LIKE ?", "%#{search}%") 
    end 
    end 

基本上這意味着，我想讓它顯示沒有organization_id所有記錄時，用戶是管理員。

Answer 1

你可以試試這種方式。

search_criteria = where("record_no LIKE ?", "%#{search}%") 
search_criteria.where("organization_id = ?", organization_id) unless is_admin 

Answer 2

讓合併的條件where

def self.search(search, organization_id, is_admin) 
    where("record_no LIKE ? AND (? OR organization_id = ?)", "%#{search}%", is_admin, organization_id) 
end 

Answer 3

試試這個：

if !is_admin 
    where(["record_no LIKE ? and organization_id = ?", "%#{search}%", organization_id]) 
else 
    where("record_no LIKE ?", "%#{search}%") 
end 

Answer 4

它可以是這樣的：

def self.search(search, organization_id, is_admin) 
    criteria = where("record_no LIKE ?", "%#{search}%") 
    criteria = criteria.where("organization_id = ?", organization_id) unless is_admin 
    criteria 
end