將一個字符串複製到另一個

Question

我將文本傳遞給結構成員時出現問題。 這裏是我的代碼

#include <stdio.h> 
#include <string.h> 


typedef struct { 
    char *name; 
    int rank; 
    int weapons; 

}player; 

player create_player(char name[], int rank, int weapons); 
void display_player(player data); 

int main (int argc, const char * argv[]) 
{ 
    player tmp = create_player("First", 3, 3); 
    display_player(tmp); 
} 

player create_player(char name[], int rank, int weapons) 
{ 
    player newobj; 
    char *tmp = malloc(strlen(name) + 1); 

    strcpy(newobj.name, tmp); 
    newobj.rank = rank; 
    newobj.weapons = weapons; 
    free(tmp); 
    return newobj; 
} 

void display_player(player data) 
{ 
    printf("Player name %s\n", data.name); 
    printf("Player rang %d\n", data.rank); 
    printf("Player weapons %d", data.weapons); 
} 

這裏是輸出

Player name 
Player rang 3 
Player weapons 3 

正如你所看到的「表演者姓名」的結果是空的。 也可以給我更優雅的方式來設置文本到newobj.name？ 我想念什麼？

Answer 1

代碼中的strcpy錯誤（它將未初始化的數據複製到未分配的內存中）。你可能想：

newobj.name = malloc(strlen(name) + 1); 
strcpy(newobj.name, name); 

或者更簡單地說，如果你有strdup：

newobj.name = strdup(name);