我該如何改進我的python代碼while while循環

Question

有人可以看看我的代碼，並告訴我一些方法可以使我的代碼更有效或更短。我的程序基本上生成1到6之間的2個數字並且獲得它們的總和。如果總和等於3,7,11，程序會說「你贏了」。如果總數是一個奇數，它會說「你輸了」。如果總數是偶數，則表示「繪製」。最後顯示贏得的比賽數量和贏得比賽的比例。如何讓用戶如果想再次發揮更高的效率，我該如何製作這部分？（仍然是python的新手）。謝謝

import random 
random.seed(1234) 

GamesPlayed=0 
Won=0 

print "DICE ROLLING GAME" 
print 

while True: 
    #generates 2 numbers from 1 to 6 
    num1=random.randint(1,6) 
    num2=random.randint(1,6) 

    total=num1+num2 

    #This part checks to see if that total is equal to 3,7, or 11. it will say you win 
    if total==3 or total==7 or total==11: 
     print "I just rolled %d and %d." % (num1, num2) 
     GamesPlayed+=1 
     Won+=1 
     print "You Win!" 
     print 
     #next part ask user if they would like to play again 
     user=raw_input("Would you like to try again (y/n): ") 
     if user=="N" or user=="n": 
      break 
     elif user=="Y" or user=="y": 
      continue 
    #next part checks to see if the two random numbers are odd numbers, if so, it displays "you lose"  
    elif total % 2==1: 
     print "I just rolled %d and %d." % (num1, num2) 
     print "Lose!" 
     GamesPlayed+=1 
     print 
     #ask if the user would want to go again 
     user=raw_input("Would you like to try again (y/n): ") 
     if user=="N" or user=="n": 
      break 
     elif user=="Y" or user=="y": 
      continue 
    #If the total is an even number, it say "draw" 
    elif total % 2==0: 
     print "I just rolled %d and %d." % (num1, num2) 
     print "Draw" 
     GamesPlayed+=1 
     print 
     user=raw_input("Would you like to try again (y/n): ") 
     if user=="N" or user=="n": 
      break 
     elif user=="Y" or user=="y": 
      continue  

#displays how many games the user won out of the number of games they played, also displays the percentage of the amount they won 
print "You won %d out of %d games, or %.0f%%." % (Won, GamesPlayed, (float(Won)/GamesPlayed) * 100) 

Answer 1

你在if/elif重複相同的代碼，但你可以做一次。

您可以使用lower()，然後您不必與上面的N進行比較。您可以使用strip()，因爲有時候人們可以將空間放入答案中，而不會看到這一點。可以使用if total in (3, 7, 11):。
類似，你可以使用ie。 if user in ('n', 'no', 'quit'):

見PEP 8 -- Style Guide for Python Code

• 使用變量lower_case名
• 逗號後

代碼添加空格周圍=，==，+=等

添加空間：

import random 
import time 

random.seed(time.time()) 

games_played = 0 
won = 0 

print "DICE ROLLING GAME" 
print 

while True: 
    games_played += 1 

    num1 = random.randint(1, 6) 
    num2 = random.randint(1, 6) 

    total = num1 + num2 

    print "I just rolled %d and %d (total: %d)." % (num1, num2, total) 

    if total in (3, 7, 11): 
     print "You Win!" 
     won += 1 
    elif total % 2 == 1: 
     print "Lose!" 
    #elif total % 2 == 0: 
    else: 
     print "Draw" 

    print 

    answer = raw_input("Would you like to try again (y/n): ") 
    answer = answer.strip().lower() 

    if answer == "n": 
     break 

    print 

print "You won %d out of %d games, or %.0f%%." % (won, games_played, (float(won)/games_played) * 100) 

並使用一些隨機值作爲種子（即。當前時間戳），因爲seed(1234)總是給出相同的結果。