1. 首頁
  2. 問答
  3. 爲什麼當我更改框架時，我的應用程序偶爾會崩潰？

爲什麼當我更改框架時，我的應用程序偶爾會崩潰？

2013-08-30 32 views
1

我有一個自定義的UISegmentedControl，當我初始化它時，它有時會崩潰。這種情況很少見，大約有1％的時間（僅僅通過蘋果的「嚴格的」應用程序測試），儘管我在其他三個視圖中使用完全相同的代碼，但它只在其中一個特定的代碼上崩潰。爲什麼當我更改框架時，我的應用程序偶爾會崩潰？

代碼：

NSArray *providers = [[NSArray alloc] initWithObjects:@"All", @"Soon", @"Attn", @"Late",  @"Done", nil]; //categories for segmented control 
FancySegmentedControl *fancy = [[FancySegmentedControl alloc] initWithItems:providers]; 
fancy.backgroundColor = [UIColor clearColor]; //change bg color 
fancy.frame = CGRectMake(11, 86, 263, 29); //lldb crashes here 
[fancy setBackgroundColor:[UIColor colorWithRed:42/255.0f 
              green:82/255.0f 
              blue:164/255.0f alpha:1] forState:UIControlStateNormal];

所以，我的症狀是：

-crash不會發生的大部分時間。

- 僅在四個視圖控制器中的一個發生刷新 - 即使代碼相同。

-Crash只在模擬器中被注意到（與此有關的任何事情??）這可能只是因爲在模擬器中測試比在設備上發生的更多。

- 我的項目使用ARC。

爲FancySegmentedControl的代碼如下：

@interface FancySegmentedControl : UISegmentedControl 
{ 
    UIColor *bgNotSelected; 
    UIColor *bgSelected; 
    UIColor *barNotSelected; 
    UIColor *barSelected; 
} 

-(void)setBackgroundColor:(UIColor *)color forState:(UIControlState)state; 

-(void)setBarColor:(UIColor *)color forState:(UIControlState)state; 

-(void)setTextAttributes:(NSDictionary *)attrs forState:(UIControlState) state; 

@end 

@implementation FancySegmentedControl 

- (id)initWithItems:(NSArray *)items 
{ 
    self = [super initWithItems:items]; 
    bgSelected = [UIColor blueColor]; 
    bgNotSelected = [UIColor whiteColor]; 
    barNotSelected = [UIColor lightGrayColor]; 
    barSelected = [UIColor orangeColor]; 
    self.selectedSegmentIndex = 0; 
    if (self) { 
     //change text stuff 
     NSDictionary *attributes = [NSDictionary dictionaryWithObjectsAndKeys: 
            [UIFont boldSystemFontOfSize:17], UITextAttributeFont, 
            [UIColor blackColor], UITextAttributeTextColor, 
            nil]; 
     [self setTitleTextAttributes:attributes forState:UIControlStateNormal]; 
     NSDictionary *highlightedAttributes = [NSDictionary dictionaryWithObject:[UIColor whiteColor] forKey:UITextAttributeTextColor]; 
     [self setTitleTextAttributes:highlightedAttributes forState:UIControlStateHighlighted]; 

     //set all dividers to nothing 
     UIView *yourView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 1, 30)]; 
     UIGraphicsBeginImageContext(yourView.bounds.size); 
     [yourView.layer renderInContext:UIGraphicsGetCurrentContext()]; 
     UIImage *image = UIGraphicsGetImageFromCurrentImageContext(); 
     UIGraphicsEndImageContext(); 
     [self setDividerImage:image 
      forLeftSegmentState:UIControlStateNormal 
      rightSegmentState:UIControlStateNormal 
        barMetrics:UIBarMetricsDefault]; 
     [self setDividerImage:image 
      forLeftSegmentState:UIControlStateSelected 
      rightSegmentState:UIControlStateNormal 
        barMetrics:UIBarMetricsDefault]; 
     [self setDividerImage:image 
      forLeftSegmentState:UIControlStateNormal 
      rightSegmentState:UIControlStateSelected 
        barMetrics:UIBarMetricsDefault]; 


     yourView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 40, 30)]; 
     yourView.backgroundColor = bgNotSelected; 
     UIView *barView = [[UIView alloc] initWithFrame:CGRectMake(0, yourView.frame.size.height - 3, 40, 3)]; 
     barView.backgroundColor = barNotSelected; 
     [yourView addSubview:barView]; 
     UIGraphicsBeginImageContext(yourView.bounds.size); 
     [yourView.layer renderInContext:UIGraphicsGetCurrentContext()]; 
     image = UIGraphicsGetImageFromCurrentImageContext(); 
     UIGraphicsEndImageContext(); 

     UIImage *normalBackgroundImage = image; 
     [self setBackgroundImage:normalBackgroundImage 
         forState:UIControlStateNormal 
         barMetrics:UIBarMetricsDefault]; 

     yourView.backgroundColor = bgSelected; 
     barView = [[UIView alloc] initWithFrame:CGRectMake(0, yourView.frame.size.height - 3, 40, 3)]; 
     barView.backgroundColor = barSelected; 
     [yourView addSubview:barView]; 
     UIGraphicsBeginImageContext(yourView.bounds.size); 
     [yourView.layer renderInContext:UIGraphicsGetCurrentContext()]; 
     image = UIGraphicsGetImageFromCurrentImageContext(); 
     UIGraphicsEndImageContext(); 
     UIImage *selectedBackgroundImage = image; 
     [self setBackgroundImage:selectedBackgroundImage 
         forState:UIControlStateSelected 
         barMetrics:UIBarMetricsDefault]; 
    } 
    return self; 
} 

-(void)setBackgroundColor:(UIColor *)color forState:(UIControlState)state 
{ 
    UIColor *barColor; 
    if (state == UIControlStateSelected) 
    { 
     bgSelected = color; 
     barColor = barSelected; 
    } 
    else 
    { 
     bgNotSelected = color; 
     barColor = barNotSelected; 
    } 
    UIView *yourView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 40, 30)]; 
    yourView.backgroundColor = color; 
    UIView *barView = [[UIView alloc] initWithFrame:CGRectMake(0, yourView.frame.size.height - 3, 40, 3)]; 
    barView.backgroundColor = barColor; 
    [yourView addSubview:barView]; 
    UIGraphicsBeginImageContext(yourView.bounds.size); 
    [yourView.layer renderInContext:UIGraphicsGetCurrentContext()]; 
    UIImage *image = UIGraphicsGetImageFromCurrentImageContext(); 
    UIGraphicsEndImageContext(); 

    [self setBackgroundImage:image 
        forState:state 
        barMetrics:UIBarMetricsDefault]; 
} 

-(void)setBarColor:(UIColor *)color forState:(UIControlState)state 
{ 
    UIColor *bgColor; 
    if (state == UIControlStateSelected) 
    { 
     barSelected = color; 
     bgColor = bgSelected; 
    } 
    else 
    { 
     barNotSelected = color; 
     bgColor = bgNotSelected; 
    } 
    UIView *yourView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, 40, 30)]; 
    yourView.backgroundColor = bgColor; 
    UIView *barView = [[UIView alloc] initWithFrame:CGRectMake(0, yourView.frame.size.height - 3, 40, 3)]; 
    barView.backgroundColor = color; 
    [yourView addSubview:barView]; 
    UIGraphicsBeginImageContext(yourView.bounds.size); 
    [yourView.layer renderInContext:UIGraphicsGetCurrentContext()]; 
    UIImage *image = UIGraphicsGetImageFromCurrentImageContext(); 
    UIGraphicsEndImageContext(); 

    [self setBackgroundImage:image 
        forState:state 
        barMetrics:UIBarMetricsDefault]; 
} 

-(void)setTextAttributes:(NSDictionary *)attrs forState:(UIControlState) state 
{ 
    if (state == UIControlStateSelected) 
    { 
     //in case user mistakes the states 
     state = UIControlStateHighlighted; 
    } 
    [self setTitleTextAttributes:attrs forState:state]; 
} 


/* 
// Only override drawRect: if you perform custom drawing. 
// An empty implementation adversely affects performance during animation. 
- (void)drawRect:(CGRect)rect 
{ 
    // Drawing code 
} 
*/ 

@end

完整的錯誤消息：

* thread #1: tid = 0x1f03, 0x0134609b libobjc.A.dylib`objc_msgSend + 15, stop reason =  EXC_BAD_ACCESS (code=2, address=0xb0000008) 
frame #0: 0x0134609b libobjc.A.dylib`objc_msgSend + 15 
frame #1: 0x0059bcd5 UIKit`-[UISegmentedControl _setBackgroundImage:forState:barMetrics:] + 148 
frame #2: 0x0059bd69 UIKit`-[UISegmentedControl setBackgroundImage:forState:barMetrics:] + 73 
frame #3: 0x0004f9f5 Services`-[FancySegmentedControl setBarColor:forState:](self=0x0ea5d740, _cmd=0x000518fd, color=0x08db4630, state=0x00000004) + 1141 at FancySegmentedControl.m:135 
frame #4: 0x0000538c Services`-[ServicesViewController fixSearchBar](self=0x07f791a0, _cmd=0x0005170b) + 1132 at ServicesViewController.m:174 
frame #5: 0x00003f38 Services`-[ServicesViewController viewDidLoad](self=0x07f791a0, _cmd=0x017fe1dd) + 616 at ServicesViewController.m:49 
frame #6: 0x0056964e UIKit`-[UIViewController view] + 184 
frame #7: 0x00569941 UIKit`-[UIViewController contentScrollView] + 36 
frame #8: 0x0057b47d UIKit`-[UINavigationController _computeAndApplyScrollContentInsetDeltaForViewController:] + 36 
frame #9: 0x0057b66f UIKit`-[UINavigationController _layoutViewController:] + 43 
frame #10: 0x0057b93b UIKit`-[UINavigationController _startTransition:fromViewController:toViewController:] + 303 
frame #11: 0x0057c3df UIKit`-[UINavigationController _startDeferredTransitionIfNeeded] + 288 
frame #12: 0x0057c561 UIKit`-[UINavigationController __viewWillLayoutSubviews] + 33 
frame #13: 0x006984ca UIKit`-[UILayoutContainerView layoutSubviews] + 222 
frame #14: 0x004e2301 UIKit`-[UIView(CALayerDelegate) layoutSublayersOfLayer:] + 145 
frame #15: 0x019b8e72 CoreFoundation`-[NSObject performSelector:withObject:] + 66 
frame #16: 0x003c292d QuartzCore`-[CALayer layoutSublayers] + 266 
frame #17: 0x003cc827 QuartzCore`CA::Layer::layout_if_needed(CA::Transaction*) + 231 
frame #18: 0x00352fa7 QuartzCore`CA::Context::commit_transaction(CA::Transaction*) + 377 
frame #19: 0x00354ea6 QuartzCore`CA::Transaction::commit() + 374 
frame #20: 0x00354580 QuartzCore`CA::Transaction::observer_callback(__CFRunLoopObserver*, unsigned long, void*) + 80 
frame #21: 0x0198b9ce CoreFoundation`__CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 30 
frame #22: 0x01922670 CoreFoundation`__CFRunLoopDoObservers + 384 
frame #23: 0x018ee4f6 CoreFoundation`__CFRunLoopRun + 1174 
frame #24: 0x018eddb4 CoreFoundation`CFRunLoopRunSpecific + 212 
frame #25: 0x018edccb CoreFoundation`CFRunLoopRunInMode + 123 
frame #26: 0x01b49879 GraphicsServices`GSEventRunModal + 207 
frame #27: 0x01b4993e GraphicsServices`GSEventRun + 114 
frame #28: 0x004a3a9b UIKit`UIApplicationMain + 1175 
frame #29: 0x000036d0 Services`main(argc=1, argv=0xbffff214) + 80 at main.m:16 
frame #30: 0x000025e5 Services`start + 53

來源

2013-08-30 Lugubrious

+0

看起來你有你自己的自定義類的分段控制。你能包括它的代碼嗎？ – LuisCien

+0

我不認爲代碼與它有任何關係，因爲它不會死在任何其他的VC上。 – Lugubrious

+0

如果您必須知道，代碼託管在gitHub上：https://github.com/mkeehan/MySegmentedControl – Lugubrious

回答

2

UIControlState是一個枚舉。你正在傳遞一個指向一個應該是UIControlState的值的指針，但實際上指針的值是直接使用的，甚至不被解引用。

從簽名中的UIControlState參數中刪除指針，您將會確定。然後

-(void)setBarColor:(UIColor *)color forState:(UIControlState)state

這將滿足UISegmentedControl的方法簽名：

-(void)setBackgroundImage:(UIImage *)backgroundImage forState:(UIControlState)state barMetrics:(UIBarMetrics)barMetrics

來源

2013-08-30 22:08:16 allprog

+0

我以我認爲正確的方式編輯了代碼，錯誤仍在發生。我編輯是否正確？ – Lugubrious

+0

它是一樣的錯誤嗎？或者它發生在別的地方？這個改變應該至少解決原始問題。 – allprog

+0

我清理了內部版本（修復內存錯誤後發現它是一個非常好的修復程序），讓我看看它是否仍然發生。如果在接下來的一個小時左右沒有出現，我會接受你的回答。謝謝！ – Lugubrious

0

您是否嘗試過運行這個殭屍是否打開？

EXC_BAD_ACCESS主要發生是因爲您正嘗試使用已釋放的內存以及現在存在的垃圾進行操作。

它看起來像在你的代碼：

frame #1: 0x0059bcd5 UIKit`-[UISegmentedControl _setBackgroundImage:forState:barMetrics:] + 148

是我們看到你有這樣的錯誤之前的最後一件事。

將斷點在這裏，並檢查PARAMS是真實的，等等。或者

你只看到這之所以崩潰，有時可能有與內存使用情況有關。你的代碼中的其他東西，模擬器，設備等都會導致內存清理並重新使用。無論出於何種原因，釋放器大部分時間都不會被調用，因此即使根據程序中的語義，它對該塊內存的指針仍然有效，但它不一定非要。在其他更強調的情況下，可能是內存被回收，釋放器運行，現在系統知道內存已經返回到系統的分配堆，因此當您試圖擺弄它時拋出異常。

來源

2013-08-30 21:45:35 Jeb

+0

我用NSZombies運行它，它發生的方式完全相同，沒有任何變化。此外，我正在使用ARC來管理內存。 – Lugubrious

相關問題

 相關問題