2011-03-01 149 views
0

我有一組需要電子郵件或FTPed(從配置讀取)的文件。在做這些之前,我需要對文件進行一些常見的操作,比如更改文件名,完整性檢查等等。OOP設計建議

 package Class::Foo::Partners; 

    use Carp; 
    use Data::Dumper; 
    # Sanity check and Blessing 
    sub new ($) { 
     my $class = shift; 
     my %attr = @_; 
     Carp::confess('Config undefined') unless defined $attr{cfg}; 
     my $self = bless({}, $class); 
     %$self = @_; 
     return $self; 
    } 

    sub process { 
     my $self = shift; 

     my %filestoupload =(); 
     if ($self->{dbh}->sql($sql, \%filestoupload)) { 
      my $stats; 
      if (defined $self->{cfg}->{$self->{section}}->{pdf_email_rcpt}) { 
       $stats = Class::Foo::Email->new(section => $self->{cfg}->{$self->{section}}, filestoupload => \%filestoupload); 
       $stats->sendfiles; 
      } else { 
       $stats = Class::Foo::FTP->new(section => $self->{cfg}->{$self->{section}}, filestoupload => \%filestoupload); 
       $stats->sendfiles; 
      } 
     } elsif ($self->{dbh}->{_error}) { 
      Carp::confess($self->{dbh}->{_error}); 
     } else { 
      print "NO FILES"; 
     } 
    } 


    package Class::Foo::FTP; 

    use Carp; 
    use Data::Dumper; 
    use POSIX qw(strftime); 
    use File::Temp qw (tempdir) ; 
    use File::Copy; 
    use Net::FTP; 

    # Sanity check and Blessing 
    sub new ($) { 
     my $class = shift; 
     my %attr = @_; 
     Carp::confess('Section undefined') unless defined $attr{section}; 
     Carp::confess('undefined ftp_host') unless defined $attr{section}->{ftp_host}; 


     my $self = bless({}, $class); 
     %$self = @_; 

     return $self; 
    } 

    sub sendfiles { 
     my $self = shift; 
     return unless(keys %{$self->{filestoupload}}); 
     #DO SOME COMMON TASK 
     .. 
     $self->ftp_connect(); 
     .. 
     .. 
    } 

    package Class::Foo::Email; 

    use Data::Dumper; 
    use Mail::Sender; 
    use POSIX qw(strftime); 
    use File::Temp qw (tempdir) ; 
    use File::Copy; 

    sub new ($) { 
     my $class = shift; 
     my %attr = @_; 
     Carp::confess('Config: undefined pdf_email_subject') unless defined $attr{section}->{pdf_email_subject}; 
     Carp::confess('Config: undefined pdf_email_from') unless defined $attr{section}->{pdf_email_from}; 
     my $self = bless({}, $class); 
     %$self = @_; 

     return $self; 
    } 

    sub sendfiles { 
     my $self = shift; 
     return unless(keys %{$self->{filestoupload}}); 
     #DO SOME COMMON TASK 
     .. 
     my $mailrcpt = $self->{section}->{pdf_email_rcpt}; 
     my $sender = new Mail::Sender {smtp => 'localhost', from => $self->{section}->{pdf_email_from}}; 
     $sender->MailFile({ to => $mailrcpt, 
          subject => $self->{section}->{pdf_email_subject}, 
          msg => "Attached is A1 of today's WSJE. ", 
          ctype => 'application/pdf', 
          file => @files }); 

     $self->{uploaded_count} = @files; 
    } 

在哪裏可以進行常見操作以及何時以及如何調用各自的子類?

我應該使用抽象嗎?

感謝您的幫助

+0

我認爲你需要更詳細地解釋你正在嘗試做什麼。 OOP的哪些方面有問題?你有沒有寫過任何代碼? – 2011-03-01 20:09:11

回答