重構複雜FlagsAttribute按位檢查

Question

如果之前曾詢問過，請致歉;我甚至用正確的術語來解決問題/目標。

我Person對象...

public class Person 
{ 
    public string FullName { get; set; } 
    public HeroAbilities Abilities { get; set; } 
    public SuperHero Hero { get; set; } 
} 

...每個Person有一系列的能力，使他們潛在的超級英雄：

[FlagsAttribute()] 
public enum HeroAbilities : long 
{ 
    None = 0, 
    Strong = 1, 
    Fly = 2, 
    WarpSpeed = 4, 
    Crazy = 8 
} 

一旦我知道他們的能力是，我可以讓他們成爲一個合適的英雄：

public class SuperHero 
{ 
    public string Name { get; set; } 
} 

對於e xample，這裏是我聲明瞭兩個Person對象，檢查每一個：

// Simple check: person should travel at warp speed 
var p1 = new Person() { FullName = "Barry Allen", Abilities = HeroAbilities.Strong | HeroAbilities.WarpSpeed }; 
if(p1.Abilities.HasFlag(HeroAbilities.WarpSpeed)) 
{ 
    p1.Hero = new SuperHero() { Name = "The Flash" }; 
} 

// Complex check: person should either be crazy, or be strong AND can fly 
var p2 = new Person() { FullName = "Mr F. Bar", Abilities = HeroAbilities.None }; 
if (p2.Abilities.HasFlag(HeroAbilities.Crazy) || p2.Abilities.HasFlag(HeroAbilities.Strong) && p2.Abilities.HasFlag(HeroAbilities.Fly)) 
{ 
    p2.Hero = new SuperHero() { Name = "SuperFooB" }; 
} 

的目標是採取檢查一個Person是否適合是英雄的邏輯，並把它的每個各自SuperHero類中，所以我可以做這樣的事情：

var sh = new SuperHero() { ... }; 
var p = new Person() { .... }; 
if(sh.PersonSuitable(p)) { p.Hero = sh }; 

我真的很掙扎的部分是，一些檢查是複雜的（例如， X or (Y and Z)），所以[Enum.HasFlag][1]不足。我處於我的相當有限的面向對象的經驗的極限，所以也許錯過了一些簡單的東西。

Answer 1

確實非常有趣的問題！恕我直言，你可以在這裏創建超級英雄檔案，這將定義一組能力和關聯到超級英雄類的一個實例。一旦被定義，你應該能夠用人的能力攔截它並檢測完美的匹配，但是記住你可能最終會有更多的一場比賽））。

聲明：該代碼可能無法按預期執行，因爲它被放在一起以僅將問題的概念性解決方案可視化。

using System; 
using System.Collections.Generic; 
using System.Linq; 
using Microsoft.VisualStudio.TestTools.UnitTesting; 

namespace UnitTestProject4 
{ 
    [TestClass] 
    public class UnitTest2 
    { 
     [TestMethod] 
     public void TestMethod1() 
     { 
      var superHeroFactory = new SuperHeroFactory(); 

      var p1 = new Person {FullName = "Barry Allen", Abilities = {new Strong(), new WarpSpeed()}}; 
      p1.Hero = superHeroFactory.Create(p1); 

      var p2 = new Person {FullName = "Mr F. Bar", Abilities = {new Crazy(), new Strong(), new CanFly()}}; 
      p2.Hero = superHeroFactory.Create(p2); 
     } 
    } 

    public class SuperHeroFactory 
    { 
     private readonly List<Tuple<SuperHero, List<Ability>>> _profiles = 
      new List<Tuple<SuperHero, List<Ability>>> 
      { 
       new Tuple<SuperHero, List<Ability>>(
        new SuperHero {Name = "The Flash"}, new List<Ability> {new WarpSpeed()}), 
       new Tuple<SuperHero, List<Ability>>(
        new SuperHero {Name = "SuperFooB"}, new List<Ability> {new Crazy()}), 
       new Tuple<SuperHero, List<Ability>>(
        new SuperHero {Name = "SuperFooB"}, new List<Ability> {new Strong(), new CanFly()}) 
      }; 

     public SuperHero Create(Person person) 
     { 
      // you may end up with more then one match here)).. 

      return _profiles.FirstOrDefault(
       profile => !person.Abilities.Except(profile.Item2).Any())?.Item1; 
     } 
    } 

    public class Person 
    { 
     public string FullName { get; set; } 
     public ICollection<Ability> Abilities { get; } = new List<Ability>(); 
     public SuperHero Hero { get; set; } 
    } 

    public class SuperHero 
    { 
     public string Name { get; set; } 
    } 

    public abstract class Ability { } 
    public class Strong : Ability { } 
    public class CanFly : Ability { } 
    public class WarpSpeed : Ability { } 
    public class Crazy : Ability { } 
}