2015-06-15 124 views
0

我有代碼循環瀏覽文件夾以打開文件並通過搜索標題和打印所有信息從名稱「HOLDER」和「CUTTING TOOL」列中獲取重要信息在這個頭文件中放入一個excel文件,masterfile。它也打印文件名到第4列和「加工數據表」到第1列VBA - 通過工作簿中的多個工作表循環

的名字,我有一些代碼設置

'(1) 
    For Each objFile In objFolder.Files 
     With WB 
'(2) 
      For Each ws In .Worksheets 
     ... 
     ''''''''''''''''code for all info I need to get from opened file''''''''''''''''' 
     ... 
      Next ws 
'(6) 
     End With 
    Next objFile 

問題是,它會遍歷ws我在Workbook中,但它不會切換到下一個工作表。例如,如果打開的文件中的第一個工作表的值爲1 2 3,第二個工作表的值爲5 7,第三個工作表的值爲8 9 10,則它將打印到我的主文件1 2 3,然後是1 2 3,然後是1 2 3 因此,它只打開第一個,並通過它打開工作表中的號碼,該工作表包含在打開的文件中,但不是通過工作表本身。任何想法解決這個問題?我卡住了。

全碼

Option Explicit 

Sub LoopThroughDirectory() 

    Const ROW_HEADER As Long = 10 

    Dim objFSO As Object 
    Dim objFolder As Object 
    Dim objFile As Object 
    Dim dict As Object 
    Dim MyFolder As String 
    Dim f As String 
    Dim StartSht As Worksheet, ws As Worksheet 
    Dim WB As Workbook 
    Dim i As Integer 
    Dim LastRow As Integer, erow As Integer 
    Dim Height As Integer 
    Dim FinalRow As Long 
    Dim hc As Range, hc1 As Range, hc2 As Range, hc3 As Range, hc4 As Range, d As Range 
    Dim TDS As Range 
    Dim hc12 As Range 

    Dim n As Range 

    Set StartSht = Workbooks("masterfile.xlsm").Sheets("Sheet1") 

    'turn screen updating off - makes program faster 
    Application.ScreenUpdating = False 

    'location of the folder in which the desired TDS files are 
    MyFolder = "C:\Users\trembos\Documents\TDS\progress\2\" 

    'find the headers on the sheet 
    Set hc1 = HeaderCell(StartSht.Range("B1"), "HOLDER") 
    Set hc2 = HeaderCell(StartSht.Range("C1"), "CUTTING TOOL") 
    Set hc4 = HeaderCell(StartSht.Range("A1"), "TOOLING DATA SHEET (TDS):") 

    'create an instance of the FileSystemObject 
    Set objFSO = CreateObject("Scripting.FileSystemObject") 
    'get the folder object 
    Set objFolder = objFSO.GetFolder(MyFolder) 
    i = 2 

    'loop through directory file and print names 
'(1) 
    For Each objFile In objFolder.Files 
     If LCase(Right(objFile.Name, 3)) = "xls" Or LCase(Left(Right(objFile.Name, 4), 3)) = "xls" Then 

'(2) 
      'Open folder and file name, do not update links 
      Set WB = Workbooks.Open(FileName:=MyFolder & objFile.Name, UpdateLinks:=0) 
      Set ws = WB.ActiveSheet 

      With WB 
       For Each ws In .Worksheets 


'   If Not Range("A1:A24").Find(What:="TOOL NUM", LookAt:=xlWhole, LookIn:=xlValues) Is Nothing Then 
'    Set n = ws.Cells(Rows.count, 1).End(xlUp) 
'(3) 
       'find CUTTING TOOL on the source sheet' 
       If Not Range("A1:M15").Find(What:="CUTTING TOOL", LookAt:=xlWhole, LookIn:=xlValues) Is Nothing Then 
       Set hc = Range("A1:M15").Find(What:="CUTTING TOOL", LookAt:=xlWhole, LookIn:=xlValues) 
'    Set n = ws.Cells(Rows.count, 1).End(xlUp) 
'    Set hc = HeaderCell(ws.Cells(ROW_HEADER, 1), "CUTTING TOOL") 
'    If Not hc Is Nothing Then 
        Set dict = GetValues(hc.Offset(1, 0), "SplitMe") 
        If dict.count > 0 Then 
        'add the values to the master list, column 3 
         Set d = StartSht.Cells(Rows.count, hc2.Column).End(xlUp).Offset(1, 0) 
         d.Resize(dict.count, 1).Value = Application.Transpose(dict.items) 
        Else 
         'StartSht.Cells(Rows.count, hc2.Column).End(xlUp).Offset(1, 0) = "2" 
        End If 
       Else ' find TOOL CUTTER on sheet 
        'StartSht.Cells(Rows.count, hc2.Column).End(xlUp).Offset(1, 0) = "NO CUTTING TOOLS PRESENT" 
        If Not Range("A1:M15").Find(What:="TOOL CUTTER", LookAt:=xlWhole, LookIn:=xlValues) Is Nothing Then 
        Set hc = Range("A1:M15").Find(What:="TOOL CUTTER", LookAt:=xlWhole, LookIn:=xlValues) 
         Set dict = GetValues(hc.Offset(1, 0), "SplitMe") 
         If dict.count > 0 Then 
         'add the values to the master list, column 3 
          Set d = StartSht.Cells(Rows.count, hc2.Column).End(xlUp).Offset(1, 0) 
          d.Resize(dict.count, 1).Value = Application.Transpose(dict.items) 
         Else 
          'StartSht.Cells(Rows.count, hc2.Column).End(xlUp).Offset(1, 0) = "2" 
         End If 
        End If 
       End If 
'(4) 
       'find HOLDER on the source sheet 


       Set hc3 = HeaderCell(ws.Cells(ROW_HEADER, 1), "HOLDER") 
       If Not hc3 Is Nothing Then 

'    If Not Range("A1:M15").Find(What:="HOLDER", LookAt:=xlWhole, LookIn:=xlValues) Is Nothing Then 
'     Set hc3 = Range("A1:M15").Find(What:="HOLDER", LookAt:=xlWhole, LookIn:=xlValues) 
         Set dict = GetValues(hc3.Offset(1, 0)) 
         'If InStr(ROW_HEADER, "HOLDER") <> "" Then 
         If dict.count > 0 Then 
         'add the values to the master list, column 2 
          Set d = StartSht.Cells(Rows.count, hc1.Column).End(xlUp).Offset(1, 0) 
          d.Resize(dict.count, 1).Value = Application.Transpose(dict.items) 
        Else 
         'StartSht.Cells(Rows.count, hc1.Column).End(xlUp).Offset(1, 0) = "none" 
        End If 
       ' find "TOOL HOLDER" on sheet 
       ElseIf Not Range("A1:M15").Find(What:="TOOL HOLDER", LookAt:=xlWhole, LookIn:=xlValues) Is Nothing Then 
        Set hc = Range("A1:M15").Find(What:="TOOL HOLDER", LookAt:=xlWhole, LookIn:=xlValues) 
         Set dict = GetValues(hc.Offset(1, 0), "SplitMe") 
         If dict.count > 0 Then 
         'add the values to the master list, column 3 
          Set d = StartSht.Cells(Rows.count, hc1.Column).End(xlUp).Offset(1, 0) 
          d.Resize(dict.count, 1).Value = Application.Transpose(dict.items) 
         Else 
          'StartSht.Cells(Rows.count, hc2.Column).End(xlUp).Offset(1, 0) = "2" 
         End If 
       'End If 

       Else 
        If hc3 Is Nothing Then 
         StartSht.Range(StartSht.Cells(i, 2), StartSht.Cells(GetLastRowInColumn(StartSht, "C"), 1)) = "NO HOLDERS PRESENT!" 
        End If 
       End If 
'(5) 

        'print the file name to Column 4 
        StartSht.Cells(i, 4) = objFile.Name 

        With ws 
        'Print TDS name by searching for header 
         If Not Range("A1:K1").Find(What:="TOOLING DATA SHEET (TDS):", LookAt:=xlWhole, LookIn:=xlValues) Is Nothing Then 
          Set TDS = Range("A1:K1").Find(What:="TOOLING DATA SHEET (TDS):", LookAt:=xlWhole, LookIn:=xlValues).Offset(, 1) 
          StartSht.Range(StartSht.Cells(i, 1), StartSht.Cells(GetLastRowInColumn(StartSht, "C"), 1)) = TDS 
         Else 
          'print the file name wihtout the extension 
          StartSht.Range(StartSht.Cells(i, 1), StartSht.Cells(GetLastRowInColumn(StartSht, "C"), 1)) = GetFilenameWithoutExtension(objFile.Name) 
         End If 
         i = GetLastRowInSheet(StartSht) + 1 
        End With 

       Next ws 

'(6) 
       'close, do not save any changes to the opened files 
       .Close SaveChanges:=False 
      End With 
     End If 
'(7) 
    'move to next file 
    Next objFile 
    'turn screen updating back on 
    Application.ScreenUpdating = True 
    ActiveWindow.ScrollRow = 1 'brings the viewer to the top of the masterfile 
End Sub 

'(8) 
'get all unique column values starting at cell c 
Function GetValues(ch As Range, Optional vSplit As Variant) As Object 
    Dim dict As Object 
    Dim rng As Range, c As Range 
    Dim v 
    Dim spl As Variant 

    Set dict = CreateObject("scripting.dictionary") 

    For Each c In ch.Parent.Range(ch, ch.Parent.Cells(Rows.count, ch.Column).End(xlUp)).Cells 
     v = Trim(c.Value) 
      If Not dict.exists(v) Then 
       If Len(v) > 0 Then 

      'exclude any info after ";" 
      If Not IsMissing(vSplit) Then 
       spl = Split(v, ";") 
       v = spl(0) 
      End If 

      'exclude any info after "," 
      If Not IsMissing(vSplit) Then 
       spl = Split(v, ",") 
       v = spl(0) 
      End If 
     End If 
     dict.Add c.Address, v 
    End If 

     If Len(v) = 0 Then 
      v = "none" 
     End If 

'  If Len(v) = "" Then 
'   v = "" 
'  End If 

    Next c 
    Set GetValues = dict 
End Function 

'(9) 
'find a header on a row: returns Nothing if not found 
Function HeaderCell(rng As Range, sHeader As String) As Range 
    Dim rv As Range, c As Range 
    For Each c In rng.Parent.Range(rng, rng.Parent.Cells(rng.Row, Columns.count).End(xlToLeft)).Cells 
     'copy cell value if it contains some string "holder" or "cutting tool" 
     If Trim(c.Value) = sHeader Then 
     'If InStr(c.Value, sHeader) <> 0 Then 
      Set rv = c 
      Exit For 
     End If 
    Next c 
    Set HeaderCell = rv 
End Function 

'(10) 
Function GetLastRowInColumn(theWorksheet As Worksheet, col As String) 
    With theWorksheet 
     GetLastRowInColumn = .Range(col & .Rows.count).End(xlUp).Row 
    End With 
End Function 

'(11) 
Function GetLastRowInSheet(theWorksheet As Worksheet) 
Dim ret 
    With theWorksheet 
     If Application.WorksheetFunction.CountA(.Cells) <> 0 Then 
      ret = .Cells.Find(What:="*", _ 
          After:=.Range("A1"), _ 
          LookAt:=xlPart, _ 
          LookIn:=xlFormulas, _ 
          SearchOrder:=xlByRows, _ 
          SearchDirection:=xlPrevious, _ 
          MatchCase:=False).Row 
     Else 
      ret = 1 
     End If 
    End With 
    GetLastRowInSheet = ret 
End Function 

'(12) 
'get the file name without the extension 
Function GetFilenameWithoutExtension(ByVal FileName) 
    Dim Result, i 
    Result = FileName 
    i = InStrRev(FileName, ".") 
    If (i > 0) Then 
    Result = Mid(FileName, 1, i - 1) 
    End If 
    GetFilenameWithoutExtension = Result 
End Function 

回答

1

當您使用RangeCells方法,總是完全與工作表和工作簿資格。因此,您的代碼如下所示:

 With WB 
      For Each ws In .Worksheets 

       'find CUTTING TOOL on the source sheet' 
       If Not Range("A1:M15").Find(What:="CUTTING TOOL", LookAt:=xlWhole, LookIn:=xlValues) Is Nothing Then 
       Set hc = Range("A1:M15").Find(What:="CUTTING TOOL", LookAt:=xlWhole, LookIn:=xlValues) 

最後兩行沒有指出範圍所屬的工作表。因此,而不是使用:

 With WB 
      For Each ws In .Worksheets 

       'find CUTTING TOOL on the source sheet' 
       If Not ws.Range("A1:M15").Find(What:="CUTTING TOOL", LookAt:=xlWhole, LookIn:=xlValues) Is Nothing Then 
        Set hc = ws.Range("A1:M15").Find(What:="CUTTING TOOL", LookAt:=xlWhole, LookIn:=xlValues) 

事實上,你可以進一步細化這一點,因爲你不需要使用Find方法兩次。

 With WB 
      For Each ws In .Worksheets 

       'find CUTTING TOOL on the source sheet' 
       Set hc = ws.Range("A1:M15").Find(What:="CUTTING TOOL", LookAt:=xlWhole, LookIn:=xlValues) 
       If Not (hc Is Nothing) Then 

有在你的代碼的其他地方,你需要將工作表限定符添加到RangeCells方法。

+0

謝謝你的幫助!我遇到了一個小問題,而且我想知道你是否也可以提供幫助? http://stackoverflow.com/questions/30868395/vba-do-not-grab-header-in-range @ChipsLetten – Taylor

相關問題