添加一個檢查到PHP函數？

Question

我有如下這個基本功能：

function buy() 
    { 
     $item_id = (int)$this->uri->segment(3); 
     if ($item_id > '0') 
     { 
      $item = $this->db->where('shop_id', $item_id)->get('shop')->row(); 
      if ($item) 
      { 
       $player = $this->user->info($this->user->id()); 

        if ($player->users_money >= $item->shop_req_money && $player->users_credits >= $item->shop_req_credits) 
        { 

        $this->db->update('users_items', array('users_id' => $this->user->id(), 'users_motors_id' => '0'), array('users_items_id' => $item->users_items_id)); 
        $this->db->update('users', array('users_money' => $player->users_money - $item->shop_req_money, 'users_credits' => $player->users_credits - $item->shop_req_credits), array('users_id' => $this->user->id())); 
        $this->db->query('UPDATE users SET users_money=users_money+' . $item->shop_req_money . ', users_credits=users_credits+' . $item->shop_req_credits . ' WHERE users_id=' . $this->db->escape($item->shop_users_id)); 
        $this->db->delete('shop', array('shop_id' => $item->shop_id)); 
        $this->session->set_flashdata('success', true); 

       } 
       else 
        $this->session->set_flashdata('error', true); 
      } 
     } 
     header('Location: ' . $_SERVER['HTTP_REFERER']); 
    } 

，我編輯它像添加額外的檢查，如果REG IP是不一樣的另外一個如果是設置一個錯誤信息。

function buy() 
{ 
    $item_id = (int)$this->uri->segment(3); 
    if ($item_id > '0') 
    { 
     $item = $this->db->where('shop_id', $item_id)->get('shop')->row(); 
     if ($item) 
     { 
      $player = $this->user->info($this->user->id()); 
      $players = $this->user->info($item->shop_users_id); 


       if ($players->users_reg_ip === $player->users_reg_ip) 
       { 
       $this->session->set_flashdata('errorip', true); 
       } 
       elseif ($player->users_money >= $item->shop_req_money && $player->users_credits >= $item->shop_req_credits) 
       { 

       $this->db->update('users_items', array('users_id' => $this->user->id(), 'users_motors_id' => '0'), array('users_items_id' => $item->users_items_id)); 
       $this->db->update('users', array('users_money' => $player->users_money - $item->shop_req_money, 'users_credits' => $player->users_credits - $item->shop_req_credits), array('users_id' => $this->user->id())); 
       $this->db->query('UPDATE users SET users_money=users_money+' . $item->shop_req_money . ', users_credits=users_credits+' . $item->shop_req_credits . ' WHERE users_id=' . $this->db->escape($item->shop_users_id)); 
       $this->db->delete('shop', array('shop_id' => $item->shop_id)); 
       $this->session->set_flashdata('success', true); 

      } 
      else 
       $this->session->set_flashdata('error', true); 
     } 
    } 
    header('Location: ' . $_SERVER['HTTP_REFERER']); 
} 

它的工作原理事情是這樣的，但基本上我問如果多數民衆贊成這樣做，還是應該有這一點，但更好的別的東西，我可以做similiar的正確方法是什麼？如果對我的問題有任何意見，我會非常感激。提前致謝！

Answer 1

是的，你可以在條件塊中包含它。像這樣：

if ($players->users_reg_ip === $player->users_reg_ip) { 
    // trying to buy from the same IP 
    $this->session->set_flashdata('errorip', true); 
} 

elseif ($player->users_money < $item->shop_req_money && $player->users_credits < $item->shop_req_credits) { 
    // if user has not enough money and user credits is less than shop requirement credits 
    // or maybe you mean OR || 
    $this->session->set_flashdata('error', true); 

} 
else { 
    $this->db->update('users_items', 
     array('users_id' => $this->user->id(), 'users_motors_id' => '0'), 
     array('users_items_id' => $item->users_items_id) 
    ); 

    $this->db->update('users', 
     array('users_money' => $player->users_money - $item->shop_req_money, 
      'users_credits' => $player->users_credits - $item->shop_req_credits 
     ), 
     array('users_id' => $this->user->id()) 
    ); 

    $this->db->query('UPDATE users SET users_money=users_money+' . $item->shop_req_money . ', users_credits=users_credits+' . $item->shop_req_credits . ' WHERE users_id=' . $this->db-> escape( $item->shop_users_id)); 

    $this->db->delete('shop', array('shop_id' => $item->shop_id)); 
    $this->session->set_flashdata('success', true); 
} 

// instead of using referrer why not 
// redirect('controller/method'); ?