正確清理System.ServiceModel.ServiceHost

Question

我有點困惑清理ServiceHost的最佳方法。由於Visual Studio代碼分析器的CA1001警告提示我爲我的類實現了IDisposable接口，我意識到了代碼中的問題。

我已閱讀關於IDisposable的討論，並熟悉典型用例，但發現自己在這種情況下感到困惑。確保ServiceHost被處置並可能滿足CA1001的正確方法是什麼？謝謝。

我的代碼看起來像下面這樣：

public class MyClass 
{ 
    private ServiceHost host = null; 

    public void StartListening(...) 
    { 
     // make sure we are not already listening for connections 
     if (host != null && host.State != CommunicationState.Closed) 
      StopListening(); 

     // create service host instance 
     host = new ServiceHostWithData(typeof(ServiceHandler), address); 

     // do a bunch of configuration stuff on the host 

     host.Open(); 
    } 

    public void StopListening() 
    { 
     // if we are not closed 
     if ((host != null) && (host.State != CommunicationState.Closed)) 
     { 
      host.Close(); 
      host = null; 
     } 
     else // we are null or closed 
     { 
      host = null; // if it isn't null, and it is already closed, then we set it to null 
     } 
    } 
} 

Answer 1

你的類應該實現IDisposable。基於從MSDN頁面的例子：

public class MyClass : IDisposable 
{ 
    private bool disposed = false; 
    private ServiceHost host = null; 

    public void StartListening(...) 
    { 
     // .... 
    } 

    public void StopListening() 
    { 
     // ... 
    } 

    public void Dispose() 
    { 
     Dispose(true); 
     GC.SuppressFinalize(this); 
    } 

    protected virtual void Dispose(bool disposing) 
    { 
     if(!this.disposed) 
     { 
      if(disposing) 
      { 
       this.StopListening(); 
      } 

      disposed = true; 
     } 
    } 

    ~MyClass() 
    { 
     Dispose(false); 
    } 
}