Rspec的方法被稱爲2X，但無法找到第二次

Question

這裏是我的控制器規格

before do 
    @order = Order.new 
end 
it "should call find & assign_attributes & test delivery_start methods" do 
    Order.should_receive(:find).with("1").and_return(@order) 
    Order.any_instance.should_receive(:assign_attributes).with({"id"=>"1", "cancel_reason" => "random"}).and_return(@order) 
    Order.any_instance.should_receive(:delivery_start).and_return(Time.now) 
    post :cancel, order: {id:1, cancel_reason:"random"} 
end 

失敗是這樣的：

Failure/Error: Unable to find matching line from backtrace 
    (#<Order:0x007fdcb03836e8>).delivery_start(any args) 
     expected: 1 time with any arguments 
     received: 2 times with any arguments 
# this backtrace line is ignored 

但我不知道爲什麼delivery_start是基於這個控制器動作被稱爲兩次：

def cancel 
    @order = Order.find(cancel_params[:id]) 
    @order.assign_attributes(cancel_params) 
    if (@order.delivery_start - Time.now) > 24.hours 
     if refund 
      @order.save 
      flash[:success] = "Your order has been successfully cancelled & refunded" 
      redirect_to root_path 
     else 
      flash[:danger] = "Sorry we could not process your cancellation, please try again" 
      render nothing: true 
     end 
    else 
     @order.save 
     flash[:success] = "Your order has been successfully cancelled" 
     redirect_to root_path 
    end 
end 

Answer 1

我會建議更多的期望，並返回true或取決於您的使用。考慮以下更改

class SomeController < ApplicationController 
    def cancel 
    ... 
    if refundable? 
     ... 
    end 
    end 

    private 

    def refundable? 
    (@order.delivery_start - Time.now) > 24.hours 
    end 
end 

# spec/controllers/some_controller_spec.rb 
describe SomeController, type: :controller do 
    describe '#cancel' do 
    context 'when refundable' do 
     it 'cancels and refunds order' do 
     order = double(:order) 
     params = order: {id: '123', cancel_reason: "random"} 
     expect(Order).to receive(:find).with('123').and_return(order) 
     expect(order).to receive(:assign_attributes).with(params[:order]).and_return(order) 
     expect(controller).to receive(:refundable?).and_return(true) 
     expect(controller).to receive(:refund).and_return(true) 
     expect(order).to receive(:save).and_return(true) 
     post :cancel, params 
     expect(response).to redirect_to '/your_root_path' 
     expect(session[:flash]['flashes']).to eq({'success'=>'Your order has been successfully cancelled & refunded'}) 
     expect(assigns(:order)).to eq order 
     end 
    end 
    end 
end 

Answer 2

我建議您測試的行爲，而不是實施。雖然在某些情況下，您想要在控制器中標出數據庫，但是由於您正在測試控制器和模型層之間的集成，因此規範並不是一個好主意。

此外，您的測試只是測試您的控制器如何執行其工作 - 而不是其實際完成。

describe SomeController, type: :controller do 

    let(:order){ Order.create } # use let not ivars. 

    describe '#cancel' do 

    let(:valid_params) do 
     { order: {id: '123', cancel_reason: "random"} } 
    end 

    context 'when refundable' do 
     before { post :cancel, params } 
     it 'cancels the order' do 
     expect(order.reload.cancel_reason).to eq "random" 
     # although you should have a model method so you can do this: 
     # expect(order.cancelled?).to be_truthy 
     end 

     it 'redirects and notifies the user' do 
     expect(response).to redirect_to root_path 
     expect(flash[:success]).to eq 'Your order has been successfully cancelled & refunded' 
     end 
    end 
    end 
end 

Answer 3

對不起，這是一個非常不理想的答案，但我重新啓動我的電腦，並通過規範...

有一件事情一直討厭我之前，我已經忘記保存代碼，即測試運行的代碼的舊版本，稱爲delivery_start兩次。但在這種情況下，我確定檢查了我已經救了。我不知道爲什麼重新啓動修復它...