從Oracle中的觸發器調用過程時出現錯誤

Question

我有以下代碼片段，它將使用觸發器和存儲過程將數據插入到三個表中，以便由觸發器調用。觸發器和過程都成功編譯。

CREATE OR REPLACE TRIGGER trigger_insert_attr AFTER 
    INSERT ON BSCS_WORK_SYNC_INFO FOR EACH ROW BEGIN 
    bscs_rateplan_sync(:new.project_id , :new.tmcode); 
    update BSCS_WORK_SYNC_INFO set comp_date=SYSDATE where 
    project_id=:new.project_id; 
    END trigger_insert_attr; 
/


    CREATE OR REPLACE 
    PROCEDURE bscs_rateplan_sync 
    (
    tmcode_list IN VARCHAR2, 
    project_id IN VARCHAR2 
) 
    AS 
    BEGIN 
    EXECUTE IMMEDIATE 'delete from ecm_mpulktm1 where 
    project_id='||project_id ; 
    EXECUTE IMMEDIATE 'delete from ecm_mpulktm2 where 
    project_id='||project_id ; 
    EXECUTE IMMEDIATE 'delete from ecm_fup_tariff_work where 
    project_id='||project_id ; 
    EXECUTE immediate 'insert into ecm_mpulktm1 select '||project_id||' , m1.* 
    from sysadm.mpulktm1@to_bscsprd_rpt m1 where tmcode in 
    ('||tmcode_list||')' 
    ; 
    EXECUTE immediate 'insert into ecm_mpulktm2 select '||project_id||' , m1.* 
    from sysadm.mpulktm2@to_bscsprd_rpt m1 where tmcode in 
    ('||tmcode_list||')' 
    ; 
    EXECUTE immediate 'insert into ecm_fup_tariff_work select '||project_id||' 
, m1.* from sysadm.fup_tariff_work@to_bscsprd_rpt m1 where tmcode in 
('||tmcode_list||')' ; 
    END; 
/

但是當數據被插入到表BSCS_WORK_SYNC_INFO我得到 以下錯誤：

SQL Error: ORA-00933: SQL command not properly ended ORA-06512: at "ECMREPORT.BSCS_RATEPLAN_SYNC", line 6 ORA-06512: at "ECMREPORT.TRIGGER_INSERT_ATTR", line 2 ORA-04088: error during execution of trigger 'ECMREPORT.TRIGGER_INSERT_ATTR'

有人可以幫助解決這個錯誤嗎？我對PL/SQL相對較新，因此會請求幫助解決上述錯誤。表BSCS_WORK_SYNC_INFO中的數據將由Web服務填充。在執行過程後，表中的數據也將被更新。

Answer 1

「快速和骯髒的」 修復

CREATE OR REPLACE TRIGGER trigger_insert_attr 
    AFTER INSERT ON BSCS_WORK_SYNC_INFO FOR EACH ROW 
BEGIN 
    bscs_rateplan_sync(:new.project_id, :new.tmcode); 
    update bscs_work_sync_info set comp_date = SYSDATE where project_id = :new.project_id; 
END trigger_insert_attr; 
/

CREATE OR REPLACE 
PROCEDURE bscs_rateplan_sync 
    (tmcode_list IN VARCHAR2 
    , project_id IN VARCHAR2) 
AS 
BEGIN 
    delete from ecm_mpulktm1 where project_id = bscs_rateplan_sync.project_id; 
    delete from ecm_mpulktm2 where project_id = bscs_rateplan_sync.project_id; 
    delete from ecm_fup_tariff_work where project_id = bscs_rateplan_sync.project_id; 

    execute immediate ' 
     insert into ecm_mpulktm1 
     select :project_id, m1.* 
     from sysadm.mpulktm1@to_bscsprd_rpt m1 
     where tmcode in ('||nvl(bscs_rateplan_sync.tmcode_list,'null')||')' 
    using in bscs_rateplan_sync.project_id; 

    execute immediate ' 
     insert into ecm_mpulktm2 
     select :project_id, m1.* 
     from sysadm.mpulktm2@to_bscsprd_rpt m1 
     where tmcode in ('||nvl(bscs_rateplan_sync.tmcode_list,'null')||')' 
    using in bscs_rateplan_sync.project_id; 

    execute immediate ' 
     insert into ecm_fup_tariff_work 
     select :project_id, m1.* 
     from sysadm.fup_tariff_work@to_bscsprd_rpt m1 
     where tmcode in ('||nvl(bscs_rateplan_sync.tmcode_list,'null')||')' 
    using in bscs_rateplan_sync.project_id; 
END; 
/

一個適當的修復

...將

• 通過解析名單完全消除動態SQL bscs_rateplan_sync.tmcode_list中的值轉換爲集合並將集合綁定到靜態SQL，
• 將bscs_work_sync_info.comp_date的更新移動到更新bscs_work_sync_info()存儲過程，並聲明觸發器調用存儲過程而不是匿名PLSQL塊。