在IF語句中填充Viewmodel？

Question

我試圖根據querystring的值填充一個viewmodel。我的繼承人控制器：

public ViewResult Index(int? ShiftStatusID) 
{ 
    //Get logged in User 
    User user = _accountService.GetUser(_formsAuthService.GetLoggedInUserID()); 

    if (ShiftStatusID == null) // Get all shifts 
    { 
     ViewModelShiftList viewModel = new ViewModelShiftList 
     { 
      Shifts = _shiftService.GetShifts(user.organisationID.Value).ToList() 
     }; 
    } 
    else // Get shifts by status id 
    { 
     ViewModelShiftList viewModel = new ViewModelShiftList 
     { 
      Shifts = _shiftService.GetShiftsByStatus(user.organisationID.Value, ShiftStatusID).ToList() 
     }; 
    } 

    return View(viewModel); 
} 

所以它不會讓我的視圖模型迴歸的觀點，稱「視圖模型並不在當前的背景下存在」。它不會讓我在if語句之外聲明視圖模型。這應該怎麼做？

Answer 1

試着移出你的viewresult中的if語句。 這裏是一個要做工精細代碼示例：

public ViewResult Index(int? ShiftStatusID) 
{ 
     //Get logged in User 
     User user = _accountService.GetUser(_formsAuthService.GetLoggedInUserID()); 
     var viewModel = new ViewModelShiftList(); 

     if (ShiftStatusID.HasValue)// Get shifts by status id 
     { 
      viewModel.Shifts = _shiftService.GetShifts(user.organisationID.Value).ToList(); 
     } 
     else // Get all shifts 
     { 
      viewModel.Shifts = _shiftService.GetShiftsByStatus(user.organisationID.Value, ShiftStatusID).ToList(); 
     } 

    return View(viewModel); 

} 

Answer 2

清理你的代碼，刪除重複的行：

public ViewResult Index(int? ShiftStatusID) 
{ 
    //Get logged in User 
    User user = _accountService.GetUser(_formsAuthService.GetLoggedInUserID()); 

    List<Shift> shifts; 

    if(ShiftStatusID == null) 
     shifts = _shiftService.GetShifts(user.organisationID.Value).ToList(); 
    else 
     shifts = _shiftService.GetShiftsByStatus(user.organisationID.Value, ShiftStatusID).ToList(); 

    var viewModel = new ViewModelShiftList 
    { 
     Shifts = shifts 
    }; 

    return View(viewModel); 
}