重構醜陋的if/else語句在Rails視圖

Question

我有這個討厭的，如果在鐵軌/ else語句查看：

  <% if question.field_type == "text_area" %> 
      <%= f.text_area :content, :class=>"form-control question-field", :data => {:question => question.id, :filter=> @filter}, :value=> question.answer(@assessment).try(:content) %> 
      <% elsif question.field_type == "date" %> 
      <%= f.date_select :content, { :order => [:year, :month, :day], :prompt => { :day => 'day', :month => 'month', :year=> "year" }, :end_year=> Date.today.year, :start_year => Date.today.year - 2 }, {:class => "question-field", :data => {:question => question.id, :filter=> @filter}, :value=> question.answer(@assessment).try(:content)} %> 
      <% elsif question.field_type == "text_field" %> 
      <%= f.text_field :content, :class=>"form-control question-field", :value=> question.answer(@assessment).try(:content), :data => {:question => question.id, :filter=> @filter} %> 
     <% elsif question.field_type == "dropdown" %> 
      <%= f.select :content, options_for_select(question.options), { :prompt => "Choose One..." }, :class=>"form-control question-field", :value=> question.answer(@assessment).try(:content), :data => {:question => question.id, :filter=> @filter} %> 
      <% elsif question.field_type == "number" %> 
      <%= f.select :content, options_for_select(1..10), {:include_blank=> true}, :class=>"form-control question-field", :value=> question.answer(@assessment).try(:content), :data => {:question => question.id, :filter=> @filter} %> 
      <% elsif question.field_type == "percentage" %> 
      <h2>100%</h2> 
      <%= f.range_field :content, :value=> get_percentage(question), :class=> "question-field percentage", :data => {:question => question.id, :filter=> @filter}, :step => 25, :in => 0..100 %> 
      <% end %> 

是否有這個重構，使之更好的好辦法？這段代碼是在每一個領域：

:class=>"form-control question-field", :value=> question.answer(@assessment).try(:content), :data => {:question => question.id, :filter=> @filter} 

我是否重構成輔助方法或部分？

Answer 1

有時模板只是混亂，你只能清理細節。重構到參數化的部分將有所幫助。爲了善良，請使用case。並考慮切換到HAML。它消除了很多視覺混亂。

<%= render 'question_field', f: f, type: question.field_type %> 

然後在_question_field.erb，

<%= case type %> 
    <% when 'text_area' %> 
    <% f.text_area :content, class: 'form-control question-field', %> 
     <% data: { question: question.id, filter: @filter }, %> 
     <% value: question.answer(@assessment).try(:content) %> 
    <% when ... %> 
<% end %> 

注意常見的工業實踐是選擇一個最大的線路長度，並堅持下去：100和120都是很常見的。另外，對散列使用新的符號鍵符號。舊的鉤子和箭頭太吵了。

在HAML：

= case type 
    - when 'text_area' 
    - f.text_area :content, class: 'form-control question-field', 
     data: { question: question.id, filter: @filter }, 
     value: question.answer(@assessment).try(:content) 
    - when ... 

Answer 2

我將完全通過創建單獨的部分爲每一種可能性，擺脫如果的，當的，那麼你就這樣結束了：

<%= render question.field_type, locals: {question: question} %> 

還是要使它更清潔器查看使幫助方法和只打電話

<%= question_field(question) %> 

和這種方法會l有點像

def question_field(question) 
    return render question.field_type, locals: {question: question} 
    # raise when no partial found, or do something elese 
end