如何使此代碼更好地組織

Question

這裏是代碼...我的if，else語句很長...如何區分它？任何建議？謝謝。

public function receiveMsg(aMsg){ 
    if($aMsg instanceof LoginMsg){ 
     $this->callingSomeMethod();   //should I separate this code into other class/ object? 
     $this->callingAnotherMethod(); //should I separate this code into other class/ object? 

     $aMsg = new RespondLoginMsg(); //should I separate this code into other class/ object? 
     $this->sendMsg($aMsg);   //should I separate this code into other class/ object? 

    }else if(aMsg instanceof LogoutMsg){ 
     $this->callingSomeMethod();  //should I separate this code into another class/ object? 

     $aMsg = new RespondLogoutMsg();  //should I separate this code into another class/ object? 
     $this->sendMsg($aMsg);    //should I separate this code into another class/ object? 


    }else if/*****bababab***/ 

    /*****many else if here (up to 200 msg+ , just upload 2 here.)***/ 


} 

Answer 1

我沒有看到任何根本錯誤的長if/else語句，如果這就是所謂的。

如果你發現它是一個眼睛，爲什麼不直接定義每個if/else塊的內容作爲它自己的函數呢？

你也可以考慮消除重做。如果它們全都以

 $aMsg = new RespondLoginMsg(); 
    $this->sendMsg($aMsg); 

那麼就不需要在每個塊中重複它。

Answer 2

也許一個開關更容易閱讀？而SENDMSG可能被移出它無論哪種方式，只是使用您的馬桶蓋設置$ AMSG對象/如果..

$strMessageClass=get_class($aMsg); 
switch ($strMessageClass) { 
    case 'LoginMsg': 
     $this->callingSomeMethod(); 
     $aMsg = new RespondLoginMsg(); 
    case 'RespondLogoutMsg': 
     $this->callingAnotherMethod(); 
     $aMsg = RespondLogoutMsg(); 
    default: 
     // If you have any.. 
} 
$this->sendMsg($aMsg); 

Answer 3

除了擺脫過度間距和換行的我沒有看到這裏的問題是什麼。你需要檢查一個項目是否是一個實例的多少個不同的類？在我看來，這裏的名單會相當有限。如果您沒有超過3個或4個if/else語句，那麼只需將其保留爲if/else即可。否則使用開關或循環。

你可以更具體地說明你正在努力完成什麼？

這是一個稍微更清晰的代碼版本。

public function receiveMsg(aMsg) { 
    if ($aMsg instanceof LoginMsg) { 
    $this->callingSomeMethod(); 
    $this->callingAnotherMethod(); 

    $aMsg = new RespondLoginMsg(); 
    $this->sendMsg($aMsg); 
    } 
    else if (aMsg instanceof LogoutMsg) { 
    $this->callingSomeMethod(); 

    $aMsg = new RespondLogoutMsg(); 
    $this->sendMsg($aMsg); 
    } 
    else if { /*****bababab***/ 

    } 
    /*****many else if here***/ 
}