不在指定時間範圍內返回項目的方法

Question

試圖找出爲什麼此方法不會返回我在某些DateTime變量中指定的時間範圍內的項目。我確實得到了一個結果，但它沒有任何意義，並提供了不正確的值。

該方法應該從昨天（過去24小時）返回所有暢銷書。但是，該方法似乎會返回自一開始就銷售的所有暢銷產品。在數據庫中有一個名爲「CreatedOnUtc」的列，它提供了一個日期，猜測這可以用作測試日期，但我不知道如何訪問它，因爲它在另一個類中。

public IList<BestsellersReportLine> DailyBestsellersReport() 
     { 
      int recordsToReturn = 5; int orderBy = 1; int groupBy = 1; 
      var yesterDay = DateTime.Now.Subtract(new TimeSpan(1, 0, 0, 0)); 
      var earliest = new DateTime(yesterDay.Year, yesterDay.Month, yesterDay.Day, 0, 0, 0); 
      var latest = earliest.Add(new TimeSpan(1, 0, 0, 0, -1)); 
      var currentDay = DateTime.Now; 
      var dayBefore = DateTime.Now.AddDays(-1); 


       var query1 = from opv in _opvRepository.Table 
         where earliest <= currentDay && latest >= dayBefore 
         join o in _orderRepository.Table on opv.OrderId equals o.Id 
         join pv in _productVariantRepository.Table on opv.ProductVariantId equals pv.Id 
         join p in _productRepository.Table on pv.ProductId equals p.Id 
         select opv; 


       var query2 = groupBy == 1 ? 
        //group by product variants 
         from opv in query1 
         where earliest <= currentDay && latest >= dayBefore 
         group opv by opv.ProductVariantId into g 
         select new 
         { 
          EntityId = g.Key, 
          TotalAmount = g.Sum(x => x.PriceExclTax), 
          TotalQuantity = g.Sum(x => x.Quantity), 
         } 
         : 
        //group by products 
         from opv in query1 
         where earliest <= currentDay && latest >= dayBefore 
         group opv by opv.ProductVariant.ProductId into g 
         select new 
         { 
          EntityId = g.Key, 
          TotalAmount = g.Sum(x => x.PriceExclTax), 
          TotalQuantity = g.Sum(x => x.Quantity), 
         } 
         ; 

       switch (orderBy) 
       { 
        case 1: 
         { 
          query2 = query2.OrderByDescending(x => x.TotalQuantity); 
         } 
         break; 
        case 2: 
         { 
          query2 = query2.OrderByDescending(x => x.TotalAmount); 
         } 
         break; 
        default: 
         throw new ArgumentException("Wrong orderBy parameter", "orderBy"); 
       } 

       if (recordsToReturn != 0 && recordsToReturn != int.MaxValue) 
        query2 = query2.Take(recordsToReturn); 

       var result = query2.ToList().Select(x => 
       { 
        var reportLine = new BestsellersReportLine() 
        { 
         EntityId = x.EntityId, 
         TotalAmount = x.TotalAmount, 
         TotalQuantity = x.TotalQuantity 
        }; 
        return reportLine; 
       }).ToList(); 



       return result; 

     } 

有一個類似的方法至極已經規定開始時間和結束時間，我相信它會搜索時間記錄在數據庫中。 Allthough此方法顯示在文本框中的可選startDate/endDate視圖中。不過，我需要在代碼中指定DailyBestsellersReport的時間記錄，因爲這將是在後臺運行的進程。

下面是一個類似的時期有日期時間parameteers：

public virtual IList<BestsellersReportLine> BestSellersReport(DateTime? startTime, 
DateTime? endTime,int recordsToReturn = 5, int orderBy = 1, int groupBy = 1) 
{ 
    some code... 
} 

有什麼想法？

Answer 1

where earliest <= currentDay && latest >= dayBefore 

這是無用的條件，它是真的。 如果你想過濾你的數據庫記錄，你需要從數據庫測試一些'時間'字段。

更新
我suposed，你已經在_orderRepository.Table 訂購日期列比你代碼片段可以轉化爲類似波紋管：

var currentTime = DateTime.Now; 
var today = new DateTime(currentTime.Year, currentTime.Month, currentTime.Day, 0, 0, 0); 
var yesterDay = today.Subtract(new TimeSpan(1, 0, 0, 0)); 

//suppose, that we gather all data for yesterday 
var query1 = from opv in _opvRepository.Table 
       join o in _orderRepository.Table on opv.OrderId equals o.Id 
       join pv in _productVariantRepository.Table on opv.ProductVariantId equals pv.Id 
       join p in _productRepository.Table on pv.ProductId equals p.Id 
       where yesterDay <= o.OrderDate && today >= o.OrderDate 
       select opv; 

var query2 = groupBy == 1 ? 
    //group by product variants 
     from opv in query1 
     group opv by opv.ProductVariantId into g 
     select new 
     { 
      EntityId = g.Key, 
      TotalAmount = g.Sum(x => x.PriceExclTax), 
      TotalQuantity = g.Sum(x => x.Quantity), 
     } 
     : 
    //group by products 
     from opv in query1 
     group opv by opv.ProductVariant.ProductId into g 
     select new 
     { 
      EntityId = g.Key, 
      TotalAmount = g.Sum(x => x.PriceExclTax), 
      TotalQuantity = g.Sum(x => x.Quantity), 
     } 
     ;