我可以用什麼來代替＃sql表中的sql函數

Question

這是我的sql查詢。

CREATE FUNCTION UF_GetOrderProducts 
(
    @OrderId int 
) 
RETURNS VARCHAR(500) 
AS 
BEGIN 
    SELECT Identity(int,1,1) ID, ProductId INTO #Temp FROM OrderProduct WHERE OrderId = @OrderId 

Declare @Id int, 
     @Count int, 
     @LoopCount int, 
     @ProductList VARCHAR(500), 
     @ProductListTemp VARCHAR(500) 

SET @Count = (Select Count(*) From #Temp) 

SET @LoopCount = 1 
SET @ProductList = '' 
WHILE @LoopCount <= @Count 
BEGIN 



    SET @ProductListTemp =(SELECT Name FROM Product WHERE ProductId =(Select ProductId from #Temp Where ID = @LoopCount)) 
     SET @ProductList +=@ProductListTemp + '<br/>' 
     Set @LoopCount=@LoopCount + 1   


END 
DROP TABLE #Temp 

RETURN @ProductList 

END 
GO 

我必須在#Temp表中循環。你有什麼其他的建議？

Answer 1

除了臨時表，您可以使用表變量。

declare @Temp TABLE (ID int identity, ProductId int) 

insert into @Temp(ProductId) 
select ProductId 
from OrderProduct 
where OrderId = @OrderId 

但是你可以重寫你的函數沒有循環。

像這樣的東西應該做你想做的。

create function IF_GetOrderProducts 
(
    @OrderId int 
) 
returns varchar(500) 
as 
begin 
    return 
    (
    select Name+'<br/>' 
    from Product as P 
     inner join OrderProduct as OP 
     on P.ProductId = OP.ProductId 
    where OP.OrderId = @OrderId 
    for xml path(''), type 
    ).value('.', 'varchar(500)') 
end