服務層和控制器

Question

我是新來的Rails。我正在使用服務層來保持我的控制器精簡。我所有的服務層文件位於app/services/domain，app/services/application，app/services/infrastructure。例如這裏是我公司的服務：

class CompanyService 

    def self.create(params) 
    company = Company.new(params) 
    rst = true 
    ActiveRecord::Base.transaction do 
     begin 
     company.save! 
     rescue ActiveRecord::RecordInvalid 
     rst = false 
     rescue ActiveRecord::StatementInvalid 
     rst = nil 
     end 
    end 
    return company, rst 
    end 

    def self.update(params) 
    company = get_company(params[:id]) 
    rst = true 
    ActiveRecord::Base.transaction do 
     begin 
     company.old_category_ids = company.category_ids 
     company.assign_attributes(params[:company]) 

     decrease_category_ids = company.old_category_ids-company.category_ids 
     decrease_counters(decrease_category_ids) 

     increase_category_ids = company.category_ids-company.old_category_ids 
     increase_counters(increase_category_ids) 

     company.save! 
     rescue ActiveRecord::RecordInvalid 
     rst = false 
     rescue ActiveRecord::StatementInvalid 
     rst = nil 
     end 
    end 
    return company, rst 
    end # end update 

這裏是公司負責人：

def create 
     @company, rst = CompanyService.create(params[:company]) 
     if rst == true 
     redirect_to(admin_companies_url, notice: "Company was successfully created.") 
     elsif rst == false 
     render active_admin_template('new.html.erb') 
     else 
     redirect_to admin_companies_url, notice: "Something went wrong. Please try again." 
     end 
    end 

    def update 
     @company, rst = CompanyService.update(params) 
     if rst 
     redirect_to admin_company_url(company), notice: "Company was successfully updated." 
     elsif rst == false 
     render active_admin_template('edit.html.erb') 
     elsif rst == nil 
     redirect_to admin_companies_url, notice: "Something went wrong. Please try again." 
     end 
    end 

    def destroy 
     CompanyService.destroy(params[:id]) 
     redirect_to admin_companies_url 
    end 

所以我有兩個問題：

1. 我知道我的控制器代碼不好。如何改進？
2. 我的服務不會自動加載在生產和開發環境。爲什麼？

對不起，我英文不好。感謝您的每一個建議和幫助。

Answer 1

有沒有什麼不理由希望通過服務使用的模型和抽象模型互動？

自動加載你的服務，你應該包括你的config/application.rb中

您也有不良記錄（invlid記錄或無效的語句）的雙重檢查，你的用戶體驗在裏面自動加載config.autoload_paths服務路徑將不變，爲什麼記錄沒有保存，所以沒有理由嵌套ifs。你的控制器應該知道這個動作是否成功