針對相同條件的多個值

Question

有沒有其他方法可以優化下面的代碼？我覺得下面的代碼對於它所執行的操作來說是巨大的。

if ((currentElement == null || 
    (firstGridRow["Low"].ToString() == string.Empty || 
    firstGridRow["High"].ToString() == string.Empty || 
    firstGridRow["Mean"].ToString() == string.Empty || 
    firstGridRow["StdDev"].ToString() == string.Empty))) 
{ 
    continue; 
} 

if (newRow.Length != 0) 
{ 
    AddColorList(currentElement, opid, currentLow, "Low", newRow, listCollectionLow); 
    AddColorList(currentElement, opid, currentHigh, "High", newRow, listCollectionHigh); 
    AddColorList(currentElement, opid, currentMean, "Mean", newRow, listCollectionMean); 
    AddColorList(currentElement, opid, currentStdDev, "StdDev", newRow, listCollectionStdDev); 
} 

Answer 1

您可以使用LINQ，像這樣：

private static readonly string[] AllKeys = new[] {"Low", "High", "Mean", "StdDev"}; 


if (currentElement == null || ALlKeys.Any(k => gridRow[k].ToString() == string.Empty)) { 
    ... 
} 
if (newRow.Length != 0) { 
    foreach (var key in AllKeys) { 
     AddColorList(currentElement, opid, currentLow, key, newRow, listCollectionLow); 
    } 
}