註冊用戶腳本不驗證密碼

Question

好吧，我的用戶註冊腳本的一個小問題，由於某種原因，它沒有檢查表單字段pass1和pass2是相同的，儘管它在代碼中，任何想法？我將在下面詳細填寫註冊碼以供審查。我對PHP很新，所以任何建議將不勝感激，謝謝你的幫助。 :-)

註冊腳本。

<?php 
ob_start(); // Start output buffering 

function isLoggedIn() 
{ 
    if(isset($_SESSION['valid']) && $_SESSION['valid']) 
     return true; 
    return false; 
} 


session_start(); 
//if the user has not logged in 
if(!isLoggedIn()) 
{ 
    header('Location: ../index.php'); 

    die(); 
} 


?> 
<?php require_once('../Connections/PropSuite.php'); ?> 

<?php 

error_reporting(E_ALL & ~E_NOTICE); 
ini_set('display_errors', TRUE); 
ini_set('display_startup_errors', TRUE); 

if (!function_exists("GetSQLValueString")) { 
function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{ 
    if (PHP_VERSION < 6) { 
    $theValue = get_magic_quotes_gpc() ? stripslashes($theValue) : $theValue; 
    } 

    $theValue = function_exists("mysql_real_escape_string") ? mysql_real_escape_string($theValue) : mysql_escape_string($theValue); 

    switch ($theType) { 
    case "text": 
     $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL"; 
     break;  
    case "long": 
    case "int": 
     $theValue = ($theValue != "") ? intval($theValue) : "NULL"; 
     break; 
    case "double": 
     $theValue = ($theValue != "") ? doubleval($theValue) : "NULL"; 
     break; 
    case "date": 
     $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL"; 
     break; 
    case "defined": 
     $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue; 
     break; 
    } 
    return $theValue; 
} 
} 

$colname_user = "-1"; 
if (isset($_SESSION['username'])) { 
    $colname_user = $_SESSION['username']; 
} 
mysql_select_db($database_Takeaway, $Takeaway); 
$query_user = sprintf("SELECT type FROM admin_users WHERE username = %s", GetSQLValueString($colname_user, "text")); 
$user = mysql_query($query_user, $Takeaway) or die(mysql_error()); 
$row_user = mysql_fetch_assoc($user); 
$totalRows_user = mysql_num_rows($user); 






    // Username available. 


//form begins 
$user_type = $row_user['type']; 

    if ($user_type === 'admin-full') 
    { 
//retrieve our data from POST 
$name = $_POST['name']; 
$username = $_POST['username']; 
$email = $_POST['email']; 
$pass1 = $_POST['pass1']; 
$pass2 = $_POST['pass2']; 
if($pass1 != $pass2) 
    header('Location: register-admin.php?pw=notmatched'); 
if(strlen($username) > 30) 
    header('Location: register-admin.php?username=toolong'); 
if(strlen($name) > 40) 
    header('Location: register-admin.php?name=toolong'); 

$hash = hash('sha256', $pass1); 

//creates a 3 character sequence 
function createSalt() 
{ 
    $string = md5(uniqid(rand(), true)); 
    return substr($string, 0, 3); 
} 
$salt = createSalt(); 
$hash = hash('sha256', $salt . $hash); 


mysql_select_db($database_Takeaway, $Takeaway); 
//sanitize username 
$username = mysql_real_escape_string($username); 

$q = "SELECT id, username FROM admin_users WHERE username = '$username'"; 
$results = @mysql_query($q); 
if(mysql_num_rows($results) > 0) 
{ 
    // Username exists. 
header('Location: register-admin.php?username-taken'); 
} 
else 
{ 


$query = "INSERT INTO admin_users (type, email, name, username, password, salt) 
     VALUES ('admin-full', '$email', '$name', '$username' , '$hash' , '$salt');"; 
mysql_query($query); 
mysql_close(); 
header('Location: ../main?NewUserAdded'); 
} 

mysql_free_result($user); 
    } 
    else { 
?> 
You are not authorised to do that! 
<?php } ?> 

UPDATE

表單代碼是

<form name="register" action="register-admin1.php" method="post"> 
    <?php if (isset($_REQUEST["username-taken"])) { ?> 
     <p style="color: #F00">Username already exists! please try again</p> 
     <?php } ?> 
     <?php if (isset($_REQUEST["pw=notmatched"])) { ?> 
     <p style="color: #F00">Username already exists! please try again</p> 
     <?php } ?> 
    <p>Register New Admin User<br /> 
     (Note! Admin users are top level and will have access to everything!) 
     <br /> 
    </p> 
     <p>Name: 
     <input name="name" type="text" id="name" maxlength="30" /> 
     </p> 
     <p>Email: 
     <input name="email" type="text" id="email" maxlength="30" /> 
     </p> 
     <p>Username: 
     <input type="text" name="username" maxlength="30" /> 
     </p> 
     <p> 
     Password: 
      <input type="password" name="pass1" /> 
     </p> 
     <p>Password Again: 
     <input type="password" name="pass2" /> 
    </p> 
     <p> 
     <input type="submit" value="Register" /> 
     </p> 
    </form> 

Answer 1

將一個die();header('Location: register-admin.php?pw=notmatched');後，因爲腳本會繼續執行，否則並設置您有任何其他頭。

像這樣：

if($pass1 != $pass2) { 
    header('Location: register-admin.php?pw=notmatched'); 
    die(); 
} 
if(strlen($username) > 30) { 
    header('Location: register-admin.php?username=toolong'); 
    die(); 
} 
if(strlen($name) > 40) { 
    header('Location: register-admin.php?name=toolong'); 
    die(); 
} 

Answer 2

看來你期待的用戶名值是在會話點在哪裏要查詢的數據庫來獲取用戶信息。如果您只是發佈表單，我不明白用戶名會在會話中。你的條件

if ($user_type === 'admin-full') 

似乎將永遠不會計算爲true，因爲你還沒有拉出來的用戶名後陣列和評價它。

請注意，您還應該使用mysqli或PDO而不是mysql_*函數，因爲這些函數在PHP中不推薦使用。