這個簡單的Log4Net包裝可以改進嗎？

Question

我寫了一個簡單的log4net包裝。我想知道這個包裝代碼是否可以改進。

我有點擔心引入到每個日誌記錄功能（信息，警告等）的反射代碼來獲取調用函數名稱。由於這個原因，是否可能有任何可能的性能問題？

namespace Acqueon.Pacer.Core.Helpers 
{ 
    #region Imports 

    using System; 
    using System.Diagnostics; 
    using System.Reflection; 

    using log4net; 

    #endregion 

    /// <summary> 
    /// log4net Log helper 
    /// </summary> 
    public sealed class Logger 
    { 
     #region Constants and Fields 

     /// <summary> 
     /// Determines whether the DEBUG Mode is enabled. 
     /// </summary> 
     private readonly bool isDebugEnabled; 

     /// <summary> 
     /// The is error enabled. 
     /// </summary> 
     private readonly bool isErrorEnabled; 

     /// <summary> 
     /// Determines whether the FATAL Mode is enabled. 
     /// </summary> 
     private readonly bool isFatalEnabled; 

     /// <summary> 
     /// Determines whether the INFO Mode is enabled. 
     /// </summary> 
     private readonly bool isInfoEnabled; 

     /// <summary> 
     /// Determines whether the WARN Mode is enabled. 
     /// </summary> 
     private readonly bool isWarnEnabled; 

     /// <summary> 
     /// The logger object 
     /// </summary> 
     private readonly ILog log; 

     #endregion 

     #region Constructors and Destructors 

     /// <summary> 
     /// Initializes a new instance of the Logger class. 
     /// </summary> 
     public Logger() 
      : this(new StackTrace().GetFrame(1).GetMethod().DeclaringType) 
     { 
     } 

     /// <summary> 
     /// Initializes a new instance of the Logger class. 
     /// </summary> 
     /// <param name="type"> 
     /// The type of logger. 
     /// </param> 
     public Logger(Type type) 
     { 
      this.log = LogManager.GetLogger(type); 

      this.isDebugEnabled = this.log.IsDebugEnabled; 
      this.isErrorEnabled = this.log.IsErrorEnabled; 
      this.isInfoEnabled = this.log.IsInfoEnabled; 
      this.isFatalEnabled = this.log.IsFatalEnabled; 
      this.isWarnEnabled = this.log.IsWarnEnabled; 
     } 

     #endregion 

     #region Public Methods 

     /// <summary> 
     /// Logs the debug message. 
     /// </summary> 
     /// <param name="message"> 
     /// The message. 
     /// </param> 
     public void Debug(string message) 
     { 
      if (this.isDebugEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Debug(methodBase.Name + " : " + message); 
      } 
     } 

     /// <summary> 
     /// Logs the debug message and the exception. 
     /// </summary> 
     /// <param name="message"> 
     /// The message. 
     /// </param> 
     /// <param name="exception"> 
     /// The exception. 
     /// </param> 
     public void Debug(string message, Exception exception) 
     { 
      if (this.isDebugEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Debug(methodBase.Name + " : " + message, exception); 
      } 
     } 

     /// <summary> 
     /// Logs the error message. 
     /// </summary> 
     /// <param name="errorMessage"> 
     /// The error message. 
     /// </param> 
     public void Error(string errorMessage) 
     { 
      if (this.isErrorEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Error(methodBase.Name + " : " + errorMessage); 
      } 
     } 

     /// <summary> 
     /// Logs the error message and the exception. 
     /// </summary> 
     /// <param name="errorMessage"> 
     /// The error message. 
     /// </param> 
     /// <param name="exception"> 
     /// The exception. 
     /// </param> 
     public void Error(string errorMessage, Exception exception) 
     { 
      if (this.isErrorEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Error(methodBase.Name + " : " + errorMessage, exception); 
      } 
     } 

     /// <summary> 
     /// Logs the fatal error message. 
     /// </summary> 
     /// <param name="message"> 
     /// The message. 
     /// </param> 
     public void Fatal(string message) 
     { 
      if (this.isFatalEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Fatal(methodBase.Name + " : " + message); 
      } 
     } 

     /// <summary> 
     /// Logs the fatal error message and the exception. 
     /// </summary> 
     /// <param name="message"> 
     /// The message. 
     /// </param> 
     /// <param name="exception"> 
     /// The exception. 
     /// </param> 
     public void Fatal(string message, Exception exception) 
     { 
      if (this.isFatalEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Fatal(methodBase.Name + " : " + message, exception); 
      } 
     } 

     /// <summary> 
     /// Logs the info message. 
     /// </summary> 
     /// <param name="message"> 
     /// The message. 
     /// </param> 
     public void Info(string message) 
     { 
      if (this.isInfoEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Info(methodBase.Name + " : " + message); 
      } 
     } 

     /// <summary> 
     /// Logs the info message and the exception. 
     /// </summary> 
     /// <param name="message"> 
     /// The message. 
     /// </param> 
     /// <param name="exception"> 
     /// The exception. 
     /// </param> 
     public void Info(string message, Exception exception) 
     { 
      if (this.isInfoEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Info(methodBase.Name + " : " + message, exception); 
      } 
     } 

     /// <summary> 
     /// Logs the warning message. 
     /// </summary> 
     /// <param name="message"> 
     /// The message. 
     /// </param> 
     public void Warn(string message) 
     { 
      if (this.isWarnEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Warn(methodBase.Name + " : " + message); 
      } 
     } 

     /// <summary> 
     /// Logs the warning message and the exception. 
     /// </summary> 
     /// <param name="message"> 
     /// The message. 
     /// </param> 
     /// <param name="exception"> 
     /// The exception. 
     /// </param> 
     public void Warn(string message, Exception exception) 
     { 
      if (this.isWarnEnabled) 
      { 
       MethodBase methodBase = new StackTrace().GetFrame(1).GetMethod(); 
       this.log.Warn(methodBase.Name + " : " + message, exception); 
      } 
     } 

     #endregion 
    } 
} 

Answer 1

爲什麼你就不能使用這個：

以下的PatternLayout圖案提取位置信息：

％F用於輸出，其中發出日誌請求的文件名

％L用於輸出日誌請求爲 的行號

％M用於輸出方法發出日誌記錄請求的名稱

％C用於輸出發出 日誌記錄請求的呼叫者的標準類名稱。

請注意，在這兩種情況下，需要堆棧走路，這是昂貴的。

<appender name="DebugOut" 
     type="log4net.Appender.OutputDebugStringAppender"> 
<layout type="log4net.Layout.PatternLayout"> 
    <conversionPattern value="%-5p [%t] %C{1}.%M - %m%n" /> 
</layout> 

Answer 2

最終將會從反射代碼的性能損失，顯然這取決於你有多少日誌消息在整個應用程序日誌。

您也可以使用正確的轉換模式輸出行號，基本調用堆棧和方法信息。該功能默認情況下存在於log4net中 - 文檔警告您存在性能問題。

最後，我將在Exception上實現包裝類作爲擴展方法。