重構這個代碼，以提高可讀性

Question

請看看下面的代碼

def test 
    array = Array.new 
    array2 = Array.new 

    groups = [[424235, "goa", "italy"], [523436, "mumbai"], [342423, "africa", "goa"]] 
    type = ["goa", "mumbai"] 
    groups.each_with_index do |item,index| 

     if item.include?(type[0]) == true 
     array << index << array2 
     elsif item.include?(type[1]) == true 
       array2 << index 
     else 
     "nothing ;)" 
     end 

    end 
    print array.each_slice(2).map { |a, b| [a, b.first] } 
end 
combine 

#Output - [[0, 1], [2, 1]] 

見與代碼的問題？那是我使用了一堆if和else語句。如果type數組有多於2個條目會怎麼樣。我不能繼續寫if和elsif語句。那就是我需要你幫忙的地方。什麼是更好的結構代碼？循環？如果是這樣的話。

Answer 1

這是我的代碼。

def combinations(groups, types) 
    array = Array.new(types.size) { Array.new([]) } 
    groups.each_with_index do |item, index| 
    types.each_with_index { |type, i| array[i] << index if item.include? type } 
    end 

    flat = array.inject { |acc, i| acc.product i }.flatten 
    flat.each_slice(types.size).to_a 
end 

樣品測試用例

combinations([[424235, "goa", "italy"], [523436, "mumbai"], [342423, "africa", "goa"]], ["goa", "mumbai"]) 

輸出：[[0, 1], [2, 1]]

combinations([[424235, "goa", "italy"], [523436, "mumbai"], [342423, "africa", "goa"]], ["goa", "africa"]) 

輸出：[[0, 2], [2, 2]]

combinations([[424235, "goa", "italy"], [523436, "mumbai"], [342423, "africa", "goa"], [123, "india"]], ["goa", "mumbai", "india"]) 

輸出：[[0, 1, 3], [2, 1, 3]]

combinations([[424235, "goa", "italy"], [523436, "mumbai"], [342423, "mumbai", "goa"], [123, "india"]], ["goa", "mumbai", "india", "italy"]) 

輸出：[[0, 1, 3, 0], [0, 2, 3, 0], [2, 1, 3, 0], [2, 2, 3, 0]]

如果我理解正確的話您的問題，那麼這些應該是正確的。雖然我可能誤解了你。請告訴我如果我的問題不對，並且如果你能提供很好的測試用例。