2013-06-29 37 views
0

我開始使用PHP進行WordPress,並編寫了一些代碼在腳註中放置一些社交網絡圖標。我已經完成了這個工作,我只是簡單地調用存儲在數據庫中的社交網絡URL的內容,以及頁腳中是否有圖標/鏈接。但是對我來說看起來效率很低,這裏是代碼,沒有人知道如何使它更高效。使多個PHP語句更高效

 <?php 
     $social1 = of_get_option('fab_social_twitter_url'); 
     $social2 = of_get_option('fab_social_facebook_url'); 
     $social3 = of_get_option('fab_social_linkedin_url');    
     ?> 



     <!-- divs for right social network icons column --> 
     <div class="eight columns"> 
     <div class="social"> 
      <ul> 

      <?php 
       if(!empty($social1)) { 
      ?> 
       <li><a href="<?php echo of_get_option('fab_social_twitter_url'); ?>"><img src="<?php echo of_get_option('fab_social_twitter_icon'); ?>" alt="Follow us on Twitter"></a></li> 
      <?php 
      } 
      ?> 

      <?php 
       if(!empty($social2)) { 
      ?> 
       <li><a href="<?php echo of_get_option('fab_social_facebook_url'); ?>"><img src="<?php echo of_get_option('fab_social_facebook_icon'); ?>" alt="Follow us on Facebook"></a></li> 
      <?php 
      } 
      ?>    

      <?php 
       if(!empty($social3)) { 
      ?>     
       <li><a href="<?php echo of_get_option('fab_social_linkedin_url'); ?>"><img src="<?php echo of_get_option('fab_social_linkedin_icon'); ?>" alt="Follow us on Linkedin"></a></li> 
      <?php 
      } 
      ?>    

      </ul> 
     </div> 
     </div> 
+3

你只是*認爲*效率低下,或者你有證據表明效率低下? – delnan

回答

2

可能:

<!-- divs for right social network icons column --> 
    <div class="eight columns"> 
    <div class="social"> 
     <ul> 
     <?php 
      foreach (array("twitter","facebook","linkedin") as $option) 
       ($tmp=of_get_option('fab_social_'.$option.'_url')) && (print('<li><a href="'.$tmp.'"><img src="'.of_get_option('fab_social_'.$option.'_icon').'" alt="Follow us on '.ucfirst($option).'"></a></li>')); 
     ?> 
     </ul> 
    </div> 
    </div> 
1

從性能的角度來看,我不認爲有什麼在這裏進行優化,三個獨立的情況下單獨測試

0
<?php 
    $social1 = of_get_option('fab_social_twitter_url'); 
    $social2 = of_get_option('fab_social_facebook_url'); 
    $social3 = of_get_option('fab_social_linkedin_url'); 

    $icon1 = of_get_option('fab_social_twitter_icon'); 
    $icon2 = of_get_option('fab_social_facebook_icon'); 
    $icon3 = of_get_option('fab_social_linkedin_icon');   
    ?> 



    <!-- divs for right social network icons column --> 
    <div class="eight columns"> 
    <div class="social"> 
     <ul> 

     <?php if(!empty($social1)) { ?> 
      <li> 
       <a href="<?php echo $social1; ?>"> 
        <img src="<?php echo $icon1; ?>" alt="Follow us on Twitter"> 
       </a> 
      </li> 
     <?php } ?> 

     <?php if(!empty($social2)) { ?> 
      <li> 
       <a href="<?php echo $social2; ?>"> 
        <img src="<?php echo $icon2; ?>" alt="Follow us on Facebook"> 
       </a> 
      </li> 
     <?php } ?> 

     <?php if(!empty($social3)) { ?> 
      <li> 
       <a href="<?php echo $social3; ?>"> 
        <img src="<?php echo $icon3; ?>" alt="Follow us on Linkedin"> 
       </a> 
      </li> 
     <?php } ?> 

     </ul> 
    </div> 
    </div>