簡單的平均計算器c + +不能正常工作

Question

嗨，大家好我是新來的C++，但有一些與java的良好體驗。

我想做一個簡單的程序，需要5個整數（作爲評分）。丟棄最大和最小的分數，並且必須從剩餘的中間3分計算平均值。

我認爲這將是相當簡單的，但由於某種原因，我的程序總是給我一個比它應該稍大的答案。

我也應該說，答案可以是一個實數，而輸入必須是整數。

下面是我到目前爲止，這是非常完整的，但有一些隱藏的男生錯誤的地方，我幾個小時都沒有找到。

我知道有可能是其他更有效的方法來做到這一點，但這是我能想到的最好的，因爲我只是剛開始C++。

任何幫助將不勝感激！

#include <iostream> 
using namespace std; 

int getSmallest(int first, int second, int third, int fourth, int fifth); 

int getLargest(int first, int second, int third, int fourth, int fifth); 

double calculateAverage(int largest, int smallest, int sum); 

int main() 
{ 
    int first, second, third, fourth, fifth; 
    int smallest, largest, sum; 
    //double ave; 

    //read input of 5 scores from judges 
    cin >> first; 
    cin >> second; 
    cin >> third; 
    cin >> fourth; 
    cin >> fifth; 

    smallest = getSmallest (first, second, third, fourth, fifth); 
    largest = getLargest (first, second, third, fourth, fifth); 
    sum = (first + second + third + fourth + fifth); 
    //ave = calculateAverage(largest, smallest, sum); 

    //cout << ave << endl; 

    cout << "The average is " << (double)calculateAverage(largest, smallest, sum) << endl; 

    return 0; 

} 

int getSmallest(int first, int second, int third, int fourth, int fifth) 
{ 
    int smallest = 0; 

    if (first <= smallest) 
    { 
     smallest = first; 
    } 
    if (second <= smallest) 
    { 
     smallest = second; 
    } 
    if (third <= smallest) 
    { 
     smallest = third; 
    } 
    if (fourth <= smallest) 
    { 
     smallest = fourth; 
    } 
    if (fifth <= smallest) 
    { 
     smallest = fifth; 
    } 

    return smallest; 
} 

int getLargest(int first, int second, int third, int fourth, int fifth) 
{ 
    int largest = 0; 

    if (first >= largest) 
    { 
     largest = first; 
    } 
    if (second >= largest) 
    { 
     largest = second; 
    } 
    if (third >= largest) 
    { 
     largest = third; 
    } 
    if (fourth >= largest) 
    { 
     largest = fourth; 
    } 
    if (fifth >= largest) 
    { 
     largest = fifth; 
    } 

    return largest; 
} 

double calculateAverage(int largest, int smallest, int sum) 
{ 
    return (((double)sum) - ((double)largest + (double)smallest))/3.0; 
} 

Answer 1

在getSmallest程序，你必須設置

int smallest = INT_MAX; 

或smallest將是0不管你輸入。

（包括<climits>爲INT_MAX可用）

編輯：它的工作原理，但效率不高。你可以保存一個測試（在這種情況下沒有必要INT_MAX），因爲第一個條件將永遠是正確的：

int getSmallest(int first, int second, int third, int fourth, int fifth) 
{ 
    int smallest = first; 

    if (second <= smallest) 
    { 
     smallest = second; 
    } 

相同的優化也適用於getLargest

int getLargest(int first, int second, int third, int fourth, int fifth) 
{ 
    int largest = first; 

    if (second >= largest) 
    { 
     largest = second; 
    }