0
我正在使用IoC容器（Unity）來註冊接口並解析/實例化對象。IoC設計 - 服務內部的動態代理服務的參考服務定位器
它工作正常，所有具有依賴接口的類都被注入到構造函數中，但是我遇到了一個設計問題。
我有一個CronJob服務，它在特定時間調用已註冊的委託，它也由服務定位器實例化。
由於作業可以註冊，我從實例化的類內引用服務定位器Unity容器，我這樣做，因爲我不知道在編譯時什麼對象將被傳遞到構造函數，因爲可以動態註冊作業。
雖然我對IoC和統一是新的，但據我瞭解，從服務內部引用靜態服務定位器是不好的，所有依賴關係都應該在構造函數中傳遞 - 所以我會很欣賞其他方式的想法，可以完成，還是可以在這種情況下引用服務定位器？
感謝，
克里斯
代碼如下：使用Unity
服務定位器
// ServiceManager provides service location facilities, logging facilities, and database access via IUnitOfWork interface
public class ServiceManager
{
private static readonly UnityContainer m_ServicesContainer = new UnityContainer();
private static readonly ServiceManager m_Manager = new ServiceManager();
public static ServiceManager Instance { get { return m_Manager; } }
private ILogger Logger { get { return Resolve<ILogger>(); } }
public T Resolve<T>()
{
return m_ServicesContainer.Resolve<T>();
}
private ServiceManager()
{
// register the unit of work class first!!
RegisterType<IUnitOfWork, UnitOfWork>();
// always register the logger (without logging)
RegisterType<ILogger, NLogForEntityFrameworkLogger>(true);
// always register the settings manager (without logging)
RegisterType<ISettingsService, SettingsService>();
RegisterType<IPluginManagerService, PluginManagerService>(true);
RegisterType<ICronJobService, CronJobService>(true);
RegisterType<IReminderGeneratorService, ReminderGeneratorService>();
RegisterType<IInvoiceService, InvoiceService>();
}
public void RegisterType<TFrom, TTo>(bool isSingleton = false)
{
if (isSingleton == false)
m_ServicesContainer.RegisterType(typeof(TFrom), typeof(TTo));
else
m_ServicesContainer.RegisterType(typeof(TFrom), typeof(TTo), new ContainerControlledLifetimeManager());
}
}
的cronjob類
public static class CronJobDelegates
{
public static void SyncRecords(BusinessUnit businessUnit)
{
ISynchronisationService syncService = ServiceManager.Instance.Resolve<ISynchronisationService>();
syncService.Sync(businessUnit);
}
}
class CronJobService : ServiceBaseWithUnitOfWork, ICronJobService
{
public CronJobService(IUnitOfWork unitOfWork, ILogger logger, ISettingsService settings)
: base(unitOfWork, logger)
{
m_Settings = settings;
RegisterCronJob("SyncAccountRecords", CronJobDelegates.SyncRecords,"*1****");
}
ISettingsService m_Settings;
public class RegisteredCronJob
{
public RegisteredCronJob(string jobName, EventJobDelegate job)
{
JobName = jobName;
Job = job;
}
public string JobName { get; private set; }
public EventJobDelegate Job { get; private set; }
}
static object Lock = new object();
Dictionary<string, EventJobDelegate> CronJobs = new Dictionary<string, EventJobDelegate>();
public void RegisterCronJob(string jobName, EventJobDelegate jobCallback, string jobSetting)
{
lock(Lock)
{
if(CronJobs.ContainsKey(jobName))
{
LogMessage("Job '" + jobName + "' already registered", LogLevel.Warn);
// warning job already registered
}
else
{
CronJob cronJobRecord = UnitOfWork.CronJobRepository.GetByID(jobName);
if (cronJobRecord == null)
{
CronJob newCronJob = new CronJob()
{
JobName = jobName,
JobSetting = jobSetting
};
UnitOfWork.CronJobRepository.Insert(newCronJob);
}
else
jobSetting = cronJobRecord.JobSetting;
LogMessage("Job '" + jobName + "' registered using settings: " + jobSetting + ". Next run due on UTC " + NCrontab.CrontabSchedule.Parse(jobSetting).GetNextOccurrence(DateTime.UtcNow), LogLevel.Info);
CronJobs.Add(jobName, jobCallback);
UnitOfWork.Save();
}
}
}
public void ProcessEvents()
{
foreach(BusinessUnit businessUnit in UnitOfWork.BusinessUnitRepository.Get())
{
foreach (CronJob cronJob in UnitOfWork.CronJobRepository.Get())
{
lock(Lock)
{
NCrontab.CrontabSchedule schedule = NCrontab.CrontabSchedule.Parse(cronJob.JobSetting);
if (schedule.GetNextOccurrence(cronJob.LastRan) > DateTime.UtcNow.AddHours(businessUnit.GmtOffset))
{
EventJobDelegate jobDelegate;
if (CronJobs.TryGetValue(cronJob.JobName, out jobDelegate) == true)
{
jobDelegate(businessUnit);
cronJob.LastRan = DateTime.UtcNow;
UnitOfWork.CronJobRepository.Update(cronJob);
LogMessage("Job '" + cronJob.JobName + "' ran, next schedule on " + schedule.GetNextOccurrence(cronJob.LastRan));
}
}
}
}
}
UnitOfWork.Save();
}
}