Rspec：在控制器中的存根方法

Question

我可以知道如何在控制器創建方法中存根方法嗎？我需要寫這個規範，但我得到了這些錯誤。我需要檢查控制器中的create方法，然後才能在模型中創建新的公司記錄之前執行validate_fbid方法。

錯誤：

1) Companies new company create with valid information#validate_fbid should have correct parameters and return value 
Failure/Error: CompaniesController.create.should_receive(:validates_fbid).with(company) 
NoMethodError: 
    undefined method `create' for CompaniesController:Class 
# ./spec/requests/companies_spec.rb:38:in `block (5 levels) in <top (required)>' 

    2) Companies new company create with valid information#validate_fbid should fbid validation passed 
Failure/Error: CompaniesController.create.stub(:validates_fbid).and_return('companyid') 
NoMethodError: 
    undefined method `create' for CompaniesController:Class 
# ./spec/requests/companies_spec.rb:43:in `block (5 levels) in <top (required)>' 

CompaniesController

def create 
company = Company.new(params[:company]) 
verifyfbid = validate_fbid(company) 

if verifyfbid != false 
    if company.fbid.downcase == verifyfbid.downcase 
     if company.save 
      @message = "New company created." 
      redirect_to root_path 
     else 
      @message = "Company create attempt failed. Please try again." 
      render 'new' 
     end 
    else 
     @message = "Company create attempt failed. Invalid facebook id." 
     render 'new' 
    end 
else 
    @message = "Company create attempt failed. No such facebook id." 
    render 'new'    
    end    
end 

    private 
    def validate_fbid(company) 
    uri = URI("http://graph.facebook.com/" + company.fbid) 
    data = Net::HTTP.get(uri) 
    username = JSON.parse(data)['username']  
    if username.nil? 
    return false 
    else 
    "#{username}" 
    end 
end 

請求/ companies_spec.rb

context "#validate_fbid" do    
     #validate fbid 
     let(:company){ Company.new(name:'Example Company', url: 'www.company.com', fbid: 'companyid', desc: 'Company desc')} 

     it "should have correct parameters and return value" do 
      CompaniesController.create.should_receive(:validates_fbid).with(company) 
           .and_return('companyid') 
     end 

     it "should fbid validation passed" do    
      CompaniesController.create.stub(:validates_fbid).and_return('companyid') 
      company.fbid.should_not be_nil 
      company.fbid.should == 'companyid' 
      company.save 
      expect { click_button submit }.to change(Company, :count).by(1) 
     end            
    end  

Answer 1

你不想存根的方法，當它的主題你測試用例

context "#validate_fbid" do 
    #test the function here 
    #don't stub 
end 

當你測試控制器創建操作，您可以存根「validate_fbid」

describe "post create" do 
    ... 
    CompaniesController.any_instance.stub(:validates_fbid).and_return('companyid') 
    ... 
end 

希望它能幫助。

Answer 2

當代碼很難測試時，通常是因爲它很複雜。

你應該這樣重構這個代碼：

• 移動驗證邏輯到一具有企業驗證的在Facebook上
• 單一的責任，這將讓獨立的Web層的驗證功能新的「服務類」和多容易測試
• 服務類化妝規範，這將隔離測試代碼（無控制器）
• 清理邏輯控制器 - 你不不想有邏輯的控制器（經驗法則：嵌套最大的一個級別）內
• 規格的控制器會以及

容易控制器代碼可以是這個樣子：

def create 
    company = Company.new(params[:company]) 
    verified = FbCompanyVerifier.new.verify(company) 

    if verified and company.save 
    # success logic 
    else 
    # fail logic 
    end 
end 

Answer 3

如果要測試控制器，您可以直接訪問控制器：

controller.stub(:message) { 'this is the value to return' } 

Answer 4

下面是Rspec的3推薦的語法（3.3）：

• allow_any_instance_of(CompaniesController).to receive(:validates_fbid).and_return("companyid")

或

• expect_any_instance_of(CompaniesController).to receive(:validates_fbid).and_return("companyid")

源：https://relishapp.com/rspec/rspec-mocks/docs/working-with-legacy-code/any-instance