PostSharp和Common.Logging Logger聲明

Question

我正在使用OnMethodBoundryAspect創建簡單的日誌記錄和執行時間方面。我想爲每種方法創建一個記錄器。但是，如果Logger未聲明爲靜態成員，則不起作用。如果聲明爲靜態，則不可能爲每個方法創建一個記錄器。

這裏是我的方面：

[Serializable] 
public class MonitorAttribute : OnMethodBoundaryAspect 
{ 
    [NonSerialized] 
    private Stopwatch _stopwatch; 

    private string _methodName; 
    private ILog _log; 

    public MonitorAttribute() 
    { 
    } 

    /// <summary> 
    /// overrides the method name in the logs 
    /// </summary> 
    /// <param name="method"></param> 
    public MonitorAttribute(string method) 
    { 
     _methodName = method; 
    } 

    #region Overrides 

    public override void CompileTimeInitialize(MethodBase method, AspectInfo aspectInfo) 
    { 
     if (string.IsNullOrEmpty(_methodName)) 
      _methodName = method.Name; 

     _log = LogManager.GetLogger(_methodName); 
    } 

    public override void OnEntry(MethodExecutionArgs args) 
    { 
     _stopwatch = Stopwatch.StartNew(); 
     _log.InfoFormat("Method {0} called", _methodName); 
    } 

    public override void OnExit(MethodExecutionArgs args) 
    { 
     _stopwatch.Stop(); 
     _log.InfoFormat("Method {0} exited successfully. execution time {1} milliseconds", _methodName, _stopwatch.ElapsedMilliseconds); 
    } 

    public override void OnSuccess(MethodExecutionArgs args) 
    { 
     _stopwatch.Stop(); 
     _log.InfoFormat("Method {0} executed successfully. execution time {1} milliseconds", _methodName, _stopwatch.ElapsedMilliseconds); 
    } 

    #endregion 
} 

Answer 1

正確的地方初始化記錄器_log的實例將是RuntimeInitialize方法。在您當前的示例中，僅在編譯期間創建記錄器。

我也建議初始化_stopwatch的每個OnEntry的新實例不是線程安全的，可能會導致不正確的結果。

您可以使用靜態秒錶和MethodExecutionArgs.MethodExecutionTag屬性將當前時間存儲在OnEntry中。此後，此值將傳遞給您的OnSuccess和OnExit方法。

所以修改後的例子可能是這樣的：

[Serializable] 
public class MonitorAttribute : OnMethodBoundaryAspect 
{ 
    private static Stopwatch _stopwatch = Stopwatch.StartNew(); 

    [NonSerialized] private ILog _log; 

    private string _methodName; 

    public MonitorAttribute() 
    { 
    } 

    /// <summary> 
    /// overrides the method name in the logs 
    /// </summary> 
    /// <param name="method"></param> 
    public MonitorAttribute(string method) 
    { 
     _methodName = method; 
    } 

    #region Overrides 

    public override void CompileTimeInitialize(MethodBase method, AspectInfo aspectInfo) 
    { 
     if (string.IsNullOrEmpty(_methodName)) 
      _methodName = method.Name; 
    } 

    public override void RuntimeInitialize(MethodBase method) 
    { 
     _log = LogManager.GetLogger(_methodName); 
    } 

    public override void OnEntry(MethodExecutionArgs args) 
    { 
     _log.InfoFormat("Method {0} called", _methodName); 
     args.MethodExecutionTag = _stopwatch.ElapsedMilliseconds; 
    } 

    public override void OnExit(MethodExecutionArgs args) 
    { 
     long stopwatchStart = (long) args.MethodExecutionTag; 
     _log.InfoFormat("Method {0} exited successfully. execution time {1} milliseconds", _methodName, 
      _stopwatch.ElapsedMilliseconds - stopwatchStart); 
    } 

    public override void OnSuccess(MethodExecutionArgs args) 
    { 
     long stopwatchStart = (long) args.MethodExecutionTag; 
     _log.InfoFormat("Method {0} executed successfully. execution time {1} milliseconds", _methodName, 
      _stopwatch.ElapsedMilliseconds - stopwatchStart); 
    } 

    #endregion 
}