Quantstrat多種貨幣。 Blotter :: UpdateAcct中可能存在的Bug

Question

一般信息：

R-版本：3.1.0

吸墨紙： 0.8.19

問題描述：

我想實現一個quantstrat帳戶它使用多個不同貨幣的portofolios。

因此，這裏是我的基本設置：

• 1帳戶EUR
• 1組合在於是爲了USD

這個工作我必須設置的匯率，這是我基於從雅虎檢索的數據。然後，我應該運行我的基本策略，並通過updateAcct函數在最後一步自動完成轉換。

現在這裏是擦...我認爲updateAcct函數有一個錯誤。

mycode的：

initDate="1990-01-01" 
from="2007-01-01" 
to="2012-12-31" 
options(width=70) 

options("getSymbols.warning4.0"=FALSE) 
currency(c('USD','EUR')) 
exchange_rate("USDEUR", tick_size = 0.01) 
USDEUR <- Cl(getSymbols("EUR=X",src="yahoo", auto.assign = FALSE)) 
Sys.setenv(TZ="UTC") 
#not sure why this might work 
.blotter <- new.env() 
.strategy <- new.env() 

symbols <- c("^IXIC" #Nasdaq 
      ) 
if(!"XLB" %in% ls()) { 
    suppressMessages(getSymbols(symbols, from=from, to=to, src="yahoo", adjust=TRUE)) 
    } 

#need this to remove index call symbol (yahoo.) from string. I.e. get ^IXIC, but named IXIC 
symbols<-gsub("\\^", "", symbols) 

stock(symbols, currency="USD", multiplier=1) 

#trade sizing and initial equity settings 
tradeSize <- 10000 
initEq <- tradeSize*length(symbols) 
strategy.st <- portfolio.st <- account.st <- "TradeNasdaq100" 

#clear old strategies etc. 
suppressWarnings(try(rm.strat(strategy.st), silent=TRUE)) 

#initialize portfolio and account 
initPortf(portfolio.st, symbols=symbols, initDate=initDate, currency='USD') 
initAcct(account.st, portfolios=portfolio.st, initDate=initDate, currency='EUR',initEq=initEq) 
initOrders(portfolio.st, initDate=initDate) 
strategy(strategy.st, store=TRUE) 

然後我用一些指標，信號，規則等....

#apply strategy 
t1 <- Sys.time() 
out <- applyStrategy(strategy=strategy.st,portfolios=portfolio.st) 
t2 <- Sys.time() 
print(t2-t1) 
#set up analytics 
updatePortf(portfolio.st) 
dateRange <- time(getPortfolio(portfolio.st)$summary)[-1] 
updateAcct(account.st,dateRange) 

一切正常，直到代碼到達最後一行。

最後一行會給出錯誤信息：Error in isTRUE(invert) : object 'invert' not found

可能的錯誤： 所以我決定檢查出updateAcct功能在這裏試用了一下調試......我敢肯定，有是代碼中的錯誤。第63行的if子句查詢isTRUE（反轉），但僅當反轉實際爲真時才創建反轉（請參閱其他子句第46行）。但是invert沒有初始化，因此如果它實際上是false，代碼將會失敗。

這裏的源代碼記事簿（原）

function (name = "default", Dates = NULL) 
{ 
    Account <- getAccount(name) 
    if (!is.null(attr(Account, "currency"))) { 
     a.ccy.str <- attr(Account, "currency") 
    } 
    Portfolios = names(Account$portfolios) 
    if (is.null(Dates)) 
     Dates <- unique(do.call(c, c(lapply(Portfolios, function(x) index(.getPortfolio(x)$summary)), 
      use.names = FALSE, recursive = FALSE)))[-1] 
    if (!length(Dates)) 
     return(name) 
    if (last(index(Account$summary)) > .parseISO8601(Dates)$first.time) { 
     whichi <- first(Account$summary[paste(.parseISO8601(Dates)$first.time, 
      "::", sep = ""), which.i = TRUE]) 
     if (!is.null(whichi)) 
      whichi = whichi - 1 
     if (whichi < 1) 
      whichi = 1 
     Account$summary = Account$summary[1:whichi, ] 
    } 
    for (pname in Portfolios) { 
     Portfolio = .getPortfolio(pname) 
     if (!is.null(attr(Portfolio, "currency"))) { 
      p.ccy.str <- attr(Portfolio, "currency") 
     } 
     psummary = Portfolio$summary[Dates] 
     if (a.ccy.str != p.ccy.str) { 
      CcyMult <- NA 
      port_currency <- try(getInstrument(p.ccy.str), silent = TRUE) 
      if (inherits(port_currency, "try-error") | !is.instrument(port_currency)) { 
       warning("Currency", p.ccy.str, " not found, using currency multiplier of 1") 
       CcyMult <- 1 
      } 
      else { 
       FXrate.str <- paste(p.ccy.str, a.ccy.str, sep = "") 
       FXrate <- try(get(FXrate.str), silent = TRUE) 
       if (inherits(FXrate, "try-error")) { 
        FXrate.str <- paste(a.ccy.str, p.ccy.str, sep = "") 
        FXrate <- try(get(FXrate.str), silent = TRUE) 
        if (inherits(FXrate, "try-error")) { 
        warning("Exchange Rate", FXrate.str, " not found for symbol,',Symbol,' using currency multiplier of 1") 
        CcyMult <- 1 
        } 
        else { 
        invert = TRUE 
        } 
       } 
      } 
      if (is.na(CcyMult) && !is.na(FXrate)) { 
       if (inherits(FXrate, "xts")) { 
        CcyMult <- FXrate[Dates] 
        CcyMult <- na.locf(merge(CcyMult, index(psummary))) 
        CcyMult <- drop(CcyMult[index(psummary)]) 
       } 
       else { 
        CcyMult <- as.numeric(FXrate) 
       } 
      } 
      else { 
       CcyMult <- 1 
      } 
      if (isTRUE(invert)) { 
       CcyMult <- 1/CcyMult 
      } 
      psummary <- psummary * CcyMult 
     } 
     Account$portfolios[[pname]] = rbind(Account$portfolios[[pname]], 
      psummary) 
    } 
    summary = NULL 
    table = .getByPortf(Account, "Net.Trading.PL", Dates) 
    obsLength = length(index(table)) 
    obsDates = index(table) 
    if (obsLength > 1) 
     on = periodicity(table)$units 
    else on = "none" 
    Attributes = c("Additions", "Withdrawals", "Realized.PL", 
     "Unrealized.PL", "Interest", "Gross.Trading.PL", "Txn.Fees", 
     "Net.Trading.PL", "Advisory.Fees", "Net.Performance", 
     "End.Eq") 
    for (Attribute in Attributes) { 
     switch(Attribute, Realized.PL = , Unrealized.PL = , Gross.Trading.PL = , 
      Txn.Fees = , Net.Trading.PL = { 
       table = .getByPortf(Account, Attribute, Dates) 
       result = xts(rowSums(table, na.rm = TRUE), order.by = index(table)) 
      }, Additions = { 
       result = if (on == "none") as.xts(sum(Account$Additions[paste("::", 
        obsDates, sep = "")]), order.by = index(table)) else { 
        if (length(Account$Additions[obsDates]) > 0) period.apply(Account$Additions[obsDates], 
        endpoints(Account$Additions[obsDates], on = on), 
        sum) else xts(rep(0, obsLength), order.by = obsDates) 
       } 
      }, Withdrawals = { 
       result = if (on == "none") as.xts(sum(Account$Withdrawals[paste("::", 
        obsDates, sep = "")]), order.by = index(table)) else { 
        if (length(Account$Additions[obsDates]) > 0) period.apply(Account$Withdrawals[obsDates], 
        endpoints(Account$Withdrawals[obsDates], 
         on = periodicity(table)$units), sum) else xts(rep(0, 
        obsLength), order.by = obsDates) 
       } 
      }, Interest = { 
       result = if (on == "none") as.xts(sum(Account$Interest[paste("::", 
        obsDates, sep = "")]), , order.by = index(table)) else { 
        if (length(Account$Additions[obsDates]) > 0) period.apply(Account$Interest[obsDates], 
        endpoints(Account$Interest[obsDates], on = periodicity(table)$units), 
        sum) else xts(rep(0, obsLength), order.by = obsDates) 
       } 
      }, Advisory.Fees = , Net.Performance = , End.Eq = { 
       result = xts(rep(0, obsLength), order.by = obsDates) 
      }) 
     colnames(result) = Attribute 
     if (is.null(summary)) { 
      summary = result 
     } 
     else { 
      summary = cbind(summary, result) 
     } 
    } 
    summary[is.na(summary)] <- 0 
    Account$summary <- rbind(Account$summary, summary) 
    assign(paste("account", name, sep = "."), Account, envir = .blotter) 
    return(name) 
} 

這裏是我認爲它應該像（摘錄行28-50）...

if (a.ccy.str != p.ccy.str) { 
    CcyMult <- NA 
    port_currency <- try(getInstrument(p.ccy.str), silent = TRUE) 
    if (inherits(port_currency, "try-error") | !is.instrument(port_currency)) { 
    warning("Currency", p.ccy.str, " not found, using currency multiplier of 1") 
    CcyMult <- 1 
    } 
    else { 
    FXrate.str <- paste(p.ccy.str, a.ccy.str, sep = "") 
    FXrate <- try(get(FXrate.str), silent = TRUE) 
    invert=FALSE #THIS IS THE LINE NEEDED FOR FIXING 
    if (inherits(FXrate, "try-error")) { 
     FXrate.str <- paste(a.ccy.str, p.ccy.str, sep = "") 
     FXrate <- try(get(FXrate.str), silent = TRUE) 
     if (inherits(FXrate, "try-error")) { 
     warning("Exchange Rate", FXrate.str, " not found for symbol,',Symbol,' using currency multiplier of 1") 
     CcyMult <- 1 
     } 
     else { 
     invert = TRUE 
     } 
    } 
    } 

TL ; DR

我認爲在流水賬中存在一個錯誤：當貨幣兌換不需要反轉匯率時發生updateAcct ...

問題： 我是對的，這是一個錯誤？或者我錯過了什麼？

PS：

我通常會提交這是一個錯誤，但A）我不知道如何向筆者B中的錯誤）我仍然quantstrat，總結和公司，我認爲一個新手別人也應該檢查這一點（作者也經常在這裏閒逛）...

Answer 1

感謝您的可重複的例子。爲了將來的參考，最好提供一個比20-30行代碼差的代碼。我花了一段時間才注意到你剛剛添加了一行。

> svn diff blotter/R/updateAcct.R 
Index: blotter/R/updateAcct.R 
=================================================================== 
--- blotter/R/updateAcct.R (revision 1681) 
+++ blotter/R/updateAcct.R (working copy) 
@@ -51,6 +51,7 @@ 
       FXrate.str<-paste(p.ccy.str,a.ccy.str,sep='') # currency quote convention is EURUSD which reads as "USD per EUR" 
       FXrate<-try(get(FXrate.str), silent=TRUE) 
       #TODO FIXME: this uses convention to sort out the rate, we should check $currency and $counter_currency and make sure directionality is correct 
+    invert=FALSE 
       if(inherits(FXrate,"try-error")){ 
        FXrate.str<-paste(a.ccy.str,p.ccy.str,sep='') 
        FXrate<-try(get(FXrate.str), silent=TRUE) 

固定在revision 1682。感謝報告！