2016-07-28 54 views
3

概述

我的自定義errorHandler中間件沒有捕獲到swagger-tools請求驗證程序錯誤。相反,swagger工具HTML錯誤被髮送回客戶端。我怎樣才能讓我的errorHandler中間件抓住swagger工具驗證錯誤並相應地響應客戶端?Swagger工具錯誤處理程序中間件沒有捕獲錯誤

我的預測

我很無奈,很不幸。無論我在哪裏放置app.use(errorHandler)指令,swagger工具的html錯誤都會返回給客戶端,並且我的errorHandler函數從不會捕獲錯誤。

也許我忽略了一些對我的設置公開不正確的東西。下面是我的app.js文件,在我的app.js下面是返回給客戶端的[不需要的] swagger-tools HTML錯誤響應。同樣,儘管下面的代碼只在兩個地方顯示,但我試圖將app.use(errorHandler)逐字地(比喻性地)放在每個地方。

app.js

"use strict"; 

var swaggerTools = require("swagger-tools"); 
var compression = require("compression"); 
var app = require("express")(); 
var logger = require("./config/logger"); 
var projectConfig = require("./config/projectConfig"); 
var debug = require("debug")("app-js"); // run this to enable debug logging DEBUG=app-js node app.js 

// swaggerRouter configuration 
var options = { 
    controllers: './api/controllers', 
    useStubs: false 
}; 

// The Swagger document (require it, build it programmatically, fetch it from a URL, ...) 
var swaggerDoc = require('./api/swagger/swagger.json'); 

// compress all requests except those which have Cache-Control header with the no-transform directive 
app.use(compression()); 

// for testing 
module.exports = app; 

// global error handler 
function errorHandler(err, req, res, next, statusCode) { 
    logger.error(err); 
    debug(err); 
    if (res.headersSent) { 
     return next(err); 
    } else { 
     res.status(statusCode || 500).json(projectConfig.genericErrorResponse(statusCode || 500, err.message || err || "something blew up and the err object was undefined")); 
    } 
} 

// handles timed out requests 
function haltOnTimedout(req, res, next) { 
    if (!req.timedout) { 
     next(); 
    } else { 
     debug("\nrequest timed out!\n"); 
     next("the request timed out", null, null, null, 504); 
    } 
} 

// Initialize the Swagger middleware 
swaggerTools.initializeMiddleware(swaggerDoc, function (middleware) { 
    "use strict" 

    // Interpret Swagger resources and attach metadata to request - must be first in swagger-tools middleware chain 
    app.use(middleware.swaggerMetadata()); 

    app.use(function (req, res, next) { 
     res.header("Access-Control-Allow-Origin", "*"); // CORS should be parametrized by configuration 
     res.header("Access-Control-Allow-Headers", "Origin, X-Requested-With, Content-Type, Accept"); 
     next(); 
    }); 

    // Validate Swagger requests 
    // app.use(middleware.swaggerValidator()); 

    app.use(middleware.swaggerValidator({ 
     validateResponse: false 
    })); 

    app.use(haltOnTimedout); 
    app.use(errorHandler); 

    // Route validated requests to appropriate controller 
    app.use(middleware.swaggerRouter(options)); 
}); 

app.use(haltOnTimedout); 
app.use(errorHandler); 

app.listen(projectConfig.port || process.env.PORT || 9000) 
    .on("connection", function (socket) { 
     debug("\na new cxn was made by a client.\n"); 
     socket.setTimeout(projectConfig.expressTimeout || 120000); 
    }) 

招搖工具HTML錯誤返回到客戶端

Error: Parameter (copy) failed schema validation 
<br> &nbsp; &nbsp;at throwErrorWithCode (/Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/swagger-tools/lib/validators.js:121:13) 
<br> &nbsp; &nbsp;at Object.module.exports.validateAgainstSchema (/Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/swagger-tools/lib/validators.js:176:7) 
<br> &nbsp; &nbsp;at /Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/swagger-tools/middleware/swagger-validator.js:143:22 
<br> &nbsp; &nbsp;at /Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/async/lib/async.js:356:13 
<br> &nbsp; &nbsp;at async.forEachOf.async.eachOf (/Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/async/lib/async.js:233:13) 
<br> &nbsp; &nbsp;at _asyncMap (/Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/async/lib/async.js:355:9) 
<br> &nbsp; &nbsp;at Object.map (/Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/async/lib/async.js:337:20) 
<br> &nbsp; &nbsp;at validateValue (/Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/swagger-tools/middleware/swagger-validator.js:136:11) 
<br> &nbsp; &nbsp;at /Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/swagger-tools/middleware/swagger-validator.js:343:21 
<br> &nbsp; &nbsp;at /Users/cuv/Documents/dev/dev-project/dev-simple/node_modules/async/lib/async.js:356:13 

我是運行的是什麼版本?

節點:

node --version 
v6.2.2 

最新的招搖工具版本,並表示:

"swagger-tools": "^0.10.1", 
"express": "^4.12.3" 

接近

任何幫助和/或洞察如何讓我的ErrorHandler中間件來捕捉和從而重寫swagger-tools html錯誤將非常非常有用。我也在apigee社區論壇上發佈了我的問題,因爲它是apigee-127項目的一部分。 https://community.apigee.com/questions/29267/swagger-tools-error-handler-middleware-not-catchin.html

謝謝!

回答

4

我看到兩個問題。

起初:錯誤處理程序必須有4個參數,所以statusCode將被忽略。

errorHandler(err, req, res, next) // correct definition 

第二位的是

next("the request timed out", null, null, null, 504); 

錯誤處理的第一個參數必須是錯誤的對象不是字符串,那麼正確的代碼會

next(new Error("the request timed out")); // other args passed by closure 

有許多變種是怎麼過的StatusCode。

// 1. Bad way: Pass string with delimiter 
next(new Error("the request timed out;404")); 
... 
// In error handler 
var args = err.message.split() // => args[0] = the request timed out, args[1] = 404 

// 2. Check message error text 
If (err.message == 'the request timed out') 
    statusCode = 404; 

// 3. Best way is use custom error 

更多關於自定義錯誤here

+0

讓你提到的固定問題前兩個變化!我正在增強我的錯誤處理機制,以便更符合您在鏈接中引用的內容。謝謝艾康! –