必須聲明標量變量「@query」動態tsql存儲過程

Question

我讀過的地方，不可能從動態查詢創建存儲過程。

我有一些錯誤，我沒有聲明標量變量。

這裏是我的TSQL動態報告這是工作：

DECLARE 
@cols AS NVARCHAR(MAX), 
@selcols AS NVARCHAR(MAX), 
@query AS NVARCHAR(MAX), 
@startdate datetime, 
@enddate datetime, 
@paramdef nvarchar(max) 

SET @startdate = '2013-02-01' 
SET @enddate = '2013-05-10'; 
SET @paramdef = '@startdate datetime, @enddate datetime'; 


SELECT 
@selcols = STUFF((SELECT ','+'ISNULL(' + QUOTENAME(convert(varchar(10), [Date], 120)) + ', 0) AS ' + QUOTENAME(convert(varchar(10), [Date], 120)) 
       FROM AdeccoView 
       --where datein > @startdate 
       -- and datein <= @enddate 
       GROUP BY [Date] 
       ORDER BY [Date] 
       FOR XML PATH(''), TYPE).value('.', 'NVARCHAR(MAX)'), 1, 1, '') 


    SELECT 
@cols = STUFF((SELECT ',' + QUOTENAME(convert(varchar(10), [Date], 120)) 
       FROM AdeccoView 
       --where datein > @startdate 
       -- and datein <= @enddate 
       GROUP BY [Date] 
       ORDER BY [Date] 
       FOR XML PATH(''), TYPE).value('.', 'NVARCHAR(MAX)'), 1, 1, '') 

SET @query = N'SELECT CreatedBy,Name, Surname,EventTypeID,Event, '+ @selcols + ',Total 
    from 
    (
     select av.EventTypeID,av.CreatedBy,emp.Name,emp.Surname,Event, 
      convert(varchar(10), [Date], 120) [Date], 
      row_number() over(PARTITION BY [date],av.EventTypeID,av.CreatedBy order BY av.EventTypeID,av.CreatedBy) m, 
      count(*) over(partition by av.CreatedBy,av.EventTypeId) Total 
     from AdeccoView av 
     left join EventType et on et.EventTypeID = av.EventTypeID 
     left join Employee emp on av.CreatedBy = emp.EmployeeD 

    ) x 
    pivot 
    (
     max(m) 
     for [Date] in ('+@cols+') 
    ) p ' 

exec sp_executesql @query, @paramdef, @startdate = @startdate, @enddate =@enddate; 

而現在，

我希望它通過存儲過程或視圖（也許是更容易後來在實體框架6實現， asp.net）。所以，我的存儲過程是這樣的：

CREATE PROCEDURE GetEmployees 
(@startDateInput datetime = NULL, @endDateInput datetime = NULL) 
AS 
SET NOCOUNT ON; 

DECLARE 
@cols AS NVARCHAR(MAX), 
@selcols AS NVARCHAR(MAX), 
@query AS NVARCHAR(MAX), 
@startdate datetime, 
@enddate datetime, 
@paramdef nvarchar(max) 

SET @startdate = @startDateInput 
SET @enddate = @endDateInput 
SET @paramdef = '@startdate datetime, @enddate datetime'; 


SELECT 
@selcols = STUFF((SELECT ','+'ISNULL(' + QUOTENAME(convert(varchar(10), [Date], 120)) + ', 0) AS ' + QUOTENAME(convert(varchar(10), [Date], 120)) 
       FROM AdeccoView 
       --where datein > @startdate 
       -- and datein <= @enddate 
       GROUP BY [Date] 
       ORDER BY [Date] 
       FOR XML PATH(''), TYPE).value('.', 'NVARCHAR(MAX)'), 1, 1, '') 


SELECT 
@cols = STUFF((SELECT ',' + QUOTENAME(convert(varchar(10), [Date], 120)) 
       FROM AdeccoView 
       --where datein > @startdate 
       -- and datein <= @enddate 
       GROUP BY [Date] 
       ORDER BY [Date] 
       FOR XML PATH(''), TYPE).value('.', 'NVARCHAR(MAX)'), 1, 1, '') 

SET @query = N'SELECT CreatedBy,Name, Surname,EventTypeID,Event, '+ @selcols + ',Total 
    from 
    (
     select av.EventTypeID,av.CreatedBy,emp.Name,emp.Surname,Event, 
      convert(varchar(10), [Date], 120) [Date], 
      row_number() over(PARTITION BY [date],av.EventTypeID,av.CreatedBy order BY av.EventTypeID,av.CreatedBy) m, 
      count(*) over(partition by av.CreatedBy,av.EventTypeId) Total 
     from AdeccoView av 
     left join EventType et on et.EventTypeID = av.EventTypeID 
     left join Employee emp on av.CreatedBy = emp.EmployeeD 

    ) x 
    pivot 
    (
     max(m) 
     for [Date] in ('+@cols+') 
    ) p ' 
    GO 
exec sp_executesql @query, @paramdef, @startdate = @startDateInput, @enddate =@EndDateInput; 

編輯：

這是我更新的代碼BEGIN和END，刪除GO語句

CREATE PROCEDURE GetEmployees 
(@startDateInput datetime = NULL, @endDateInput datetime = NULL) 
AS 
SET NOCOUNT ON; 
BEGIN 
DECLARE 
@cols AS NVARCHAR(MAX), 
@selcols AS NVARCHAR(MAX), 
@query AS NVARCHAR(MAX), 
@startdate datetime, 
@enddate datetime, 
@paramdef nvarchar(max) 

SET @startdate = @startDateInput 
SET @enddate = @endDateInput 
SET @paramdef = '@startdate datetime, @enddate datetime'; 


SELECT 
@selcols = STUFF((SELECT ','+'ISNULL(' + QUOTENAME(convert(varchar(10), [Date], 120)) + ', 0) AS ' + QUOTENAME(convert(varchar(10), [Date], 120)) 
       FROM AdeccoView 
       --where datein > @startdate 
       -- and datein <= @enddate 
       GROUP BY [Date] 
       ORDER BY [Date] 
       FOR XML PATH(''), TYPE).value('.', 'NVARCHAR(MAX)'), 1, 1, '') 


SELECT 
@cols = STUFF((SELECT ',' + QUOTENAME(convert(varchar(10), [Date], 120)) 
       FROM AdeccoView 
       --where datein > @startdate 
       -- and datein <= @enddate 
       GROUP BY [Date] 
       ORDER BY [Date] 
       FOR XML PATH(''), TYPE).value('.', 'NVARCHAR(MAX)'), 1, 1, '') 

SET @query = N'SELECT CreatedBy,Name, Surname,EventTypeID,Event, '+ @selcols + ',Total 
    from 
    (
     select av.EventTypeID,av.CreatedBy,emp.Name,emp.Surname,Event, 
      convert(varchar(10), [Date], 120) [Date], 
      row_number() over(PARTITION BY [date],av.EventTypeID,av.CreatedBy order BY av.EventTypeID,av.CreatedBy) m, 
      count(*) over(partition by av.CreatedBy,av.EventTypeId) Total 
     from AdeccoView av 
     left join EventType et on et.EventTypeID = av.EventTypeID 
     left join Employee emp on av.CreatedBy = emp.EmployeeD 

    ) x 
    pivot 
    (
     max(m) 
     for [Date] in ('+@cols+') 
    ) p ' 
END 

exec sp_executesql @query, @paramdef, @startdate = @startDateInput, @enddate =@EndDateInput; 

Answer 1

的GO前sp_executesql結束存儲過程聲明。因此存儲過程中聲明的變量不可用。換句話說，代碼定義了存儲過程。然後，它試圖運行：

exec sp_executesql @query, @paramdef, @startdate = @startDateInput, @enddate =@EndDateInput; 

注意奇怪的是，沒有一個變量的定義，因爲他們是本地的存儲過程。

您不僅應該刪除GO，而且還要使用BEGIN和END來定義存儲過程的主體。