更好的代碼建議？

Question

有人可以讓我的代碼更好/更容易嗎？我認爲現在編碼很糟糕。

我想打電話給一個INSERT MYSQLI命令功能如下：

DatabaseHandler::__i('TABLENAME', array('username' => 'foobar', 'password' => 'world')); 

我使用的這個現在，但它不工作，我認爲這是一個更好的機會。

public function __i($table, $arr) { $c=$this->connection; 
    foreach ($arr as $name => $val): 
     $param1.=$name . ","; 
     $param2.="?,"; 
    endforeach; 

    $PARAM1 = substr_replace($param1, '', -1); 
    $PARAM2 = substr_replace($param2, '', -1); 

    $query = 'INSERT INTO '.$table.' ('.$PARAM1.') VALUES ('.$PARAM2.')'; 

    foreach ($arr as $name => $val): 
    if (is_int($val)) : 
     $param = 'i'; 
     endif; 

     if (is_string($val)) : 
     $param = 's'; 
     endif; 

     if (is_double($val)) : 
     $param = 'd'; 
     endif; 
     $binds.=$param; 
     $values.="'".$arr[$name]."',"; 

    endforeach; 

    $values = substr_replace($values, '', -1); 

    if ($s = $c->prepare($query)): 

     $args = $binds + $values; 
     call_user_func_array(array($s, 'bind_param'), array($binds, $values)); 
     $s->execute(); 
     $s->close(); 
    endif; 

} 

Answer 1

很難說有什麼不工作，你應該找出自己，但我會寫這樣的事：

<?php 

/** 
* Prepares and executes an 'INSERT' query 
* 
* @param string $table 
* @param array $arr 
*/ 
public function __i($table, $arr) { 

    $c = $this -> connection; 

    foreach ($arr as $name => $val) { 
     $param1 .= $name . ","; 
     $param2 .= "?,"; 
    } 

    $PARAM1 = substr_replace($param1, '', -1); 
    $PARAM2 = substr_replace($param2, '', -1); 

    $query = 'INSERT INTO ' . $table . ' (' . $PARAM1 . ') VALUES (' . $PARAM2 . ')'; 

    foreach ($arr as $name => $val) { 

     switch (gettype($val)) { 
      case 'integer': $param = 'i'; break; 
      case 'string': $param = 's'; break; 
      case 'double': $param = 'd'; break; 
     } 

     $binds .= $param; 
     $values .= "'" . $arr[$name] . "',"; 

    } 

    $values = substr_replace($values, '', -1); 

    if ($s = $c -> prepare($query)) { 

     $args = $binds + $values; 
     call_user_func_array(array($s, 'bind_param'), array($binds, $values)); 
     $s -> execute(); 
     $s -> close(); 
    } 

} 

?>