木偶在需求中定義兩個變量，但一個變量不起作用

Question

我在我定義的類型remote_file中定義了一些變量。

當我在class cdnlog::base實例化這個類型，如果我評論了符合require_dir，我在木偶客戶得到一些錯誤信息：

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Invalid relationship: File[cdnlog-release] { require => , }, because , doesn't seem to be in the correct format. Resource references should be formatted as: Classname['title'] or Modulename::Classname['title'] (take careful note of the capitalization).

Warning: Not using cache on failed catalog

Error: Could not retrieve catalog; skipping run

我的清單：

define remote_file($remote_location=undef, $path=undef, $mode='0644', $require_dir=undef){ 
    exec{"retrieve_${title}": 
    command => "/usr/bin/wget -q ${remote_location} -O ${path}", 
    creates => $path, 
    } 
    $require_exec="Exec[retrieve_${title}]" 
    if $require_dir { 
    $require_file="File[$require_dir]" 
    } 
    elsif $require_dir == undef { 
    $require_file="," 
    } 
    file{$title: 
    path => $path, 
    mode => $mode, 
    require => [$require_exec, $require_file], 
    } 
} 
class cdnlog::base{ 
    tag 'cdnlog' 

    file {'/etc': 
    ensure  => directory, 
    recurse  => true, 
    } 
    file {'/etc/rc.d/init.d': 
    ensure  => directory, 
    recurse  => true, 
    } 
    file {'/etc/cdnlog.d': 
    ensure  => directory, 
    recurse  => true, 
    } 

########################################### 
########################################### 
########################################### 
    remote_file {'cdnlog-release': 
    path     => '/etc/cdnlog.d/cdnlog-release', 
    remote_location  => "${collectd_server}/tarball/cdnlog-release", 
    require_dir   => '/etc/cdnlog.d', 
    } 
    remote_file {'cdnlog.conf': 
    path     => '/etc/cdnlog.conf', 
    remote_location  => "${collectd_server}/tarball/cdnlog.conf", 
    require_dir   => '/etc', 

    } 
} 

感謝您的幫助

Answer 1

變量替換後的有效資源爲：

file{'cdnlog-release': 
    path => '/etc/cdnlog.d/cdnlog-release', 
    mode => '0644', 
    require => [Exec['retrieve_cdnlog-release], ","], 
    } 

這是無效的。 你應該嘗試使用

$require_exec=Exec["retrieve_${title}"] 
    if $require_dir { 
    $requirearray=[$require_exec ,File["$require_dir"]] 
    } 
    elsif $require_dir == undef { 
    $requirearray=$require_exec 
    } 
    file{$title: 
    path => $path, 
    mode => $mode, 
    require => $requirearray, 
    } 

行情應該放在括號內，也

Answer 2

添加重構勞爾的偉大答案，留給後人。

file { $title: 
    path => $path, 
    mode => $mode, 
} 
if $require_dir { 
    File[$title] { require => [ $require_exec , File["$require_dir"] ] 
} 
elsif $require_dir == undef { 
    File[$title] { require => $require_exec } 
} 

它可以讓您免於處理太多不必要的變量。