寫得更好看，更詳細的代碼

Question

我得到了下面的代碼片段，它的工作原理和做我需要做的。唯一的問題是我認爲它有點「冗長」，可以做一些優化。如有可能，有人可以幫助我減少重複性。大部分的代碼非常相似......

非常感謝

<?php 

// condition = Less Than; More Than; Between 
// noofweeks = this is the number of weeks chosen by the user 

function fmsSupplements($condition, $conditionWeeks, $noofweeks, $weekno, $weekStartno,  $weekEndno, $basicprice, $supplementAmnt, $supplementType) { 

if ($condition== "Between") { 
// I need to get the start and end values as the data in this parameter should look like 1-17 
$betweenArray = explode('-',$conditionWeeks); 
$startWeek = $betweenArray[0]; 
$endWeek = $betweenArray[1]; 
} 


if(($condition == "Less Than") && ($noofweeks < $conditionWeeks) && ($supplementType == 'Subtract') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice - $supplementAmnt; } 

elseif(($condition == "Less Than") && ($noofweeks < $conditionWeeks) && ($supplementType == 'Add') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice + $supplementAmnt; } 

elseif(($condition == "More Than") && ($noofweeks > $conditionWeeks) && ($supplementType == 'Subtract') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice - $supplementAmnt; } 

elseif(($condition == "More Than") && ($noofweeks > $conditionWeeks) && ($supplementType == 'Add') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice + $supplementAmnt; }  

elseif(($condition == "Between") && ($noofweeks >= $startWeek && $noofweeks <= $endWeek) && ($supplementType == 'Add') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice + $supplementAmnt; } 

elseif(($condition == "Between") && ($noofweeks >= $startWeek && $noofweeks <= $endWeek) && ($supplementType == 'Substract') && ($weekno >= $weekStartno && $weekno <= $weekEndno)) { return $basicprice - $supplementAmnt; } 

//if no conditions match, just return the unaltered basic price back 

else { return $basicprice ;} 

;} ?> 

Answer 1

這IFS的一個列表可以寫成一個嵌套如果。

最重要的變化：

1. ($weekno >= $weekStartno && $weekno <= $weekEndno)是所有 條件的一部分，所以它是在外部如果。
2. 如果使用或 （||），將與給定條件字符串匹配的三個變化條件 放入1中。
3. 內在如果也單數。 Add導致 增加。 Subtract在減法。

所有歸結爲儘可能少的重複條件，雖然你應該記住，結構仍應該清楚。在某些情況下，這可能會更容易。

<?php 

// condition = Less Than; More Than; Between 
// noofweeks = this is the number of weeks chosen by the user 

function fmsSupplements($condition, $conditionWeeks, $noofweeks, $weekno, $weekStartno, $weekEndno, $basicprice, $supplementAmnt, $supplementType) { 
    if ($condition == "Between") { 
    // I need to get the start and end values as the data in this parameter should look like 1-17 
    $betweenArray = explode('-',$conditionWeeks); 
    $startWeek = $betweenArray[0]; 
    $endWeek = $betweenArray[1]; 
    } 

    if ($weekno >= $weekStartno && $weekno <= $weekEndno) 
    { 
    if (($condition == 'Less Than' && $noofweeks < $conditionWeeks) || 
     ($condition == 'More Than' && $noofweeks > $conditionWeeks) || 
     ($condition == 'Between' && $noofweeks >= $startWeek && $noofweeks <= $endWeek)) 
    { 
     // You can use a 'switch' as well, instead of if...elseif. 
     if ($supplementType == 'Subtract') { 
     return $basicprice - $supplementAmnt; 
     } elseif ($supplementType == 'Add' { 
     return $basicprice + $supplementAmnt; 
     } 
    } 
    } 
    return $basicprice; 
} ?> 

在不同的設置中，我把中間結果在單獨的變量，我認爲 使得它更具有可讀性。我在這裏加了一點更多的評論，解釋了決定：

function fmsSupplements($condition, $conditionWeeks, $noofweeks, $weekno, $weekStartno, $weekEndno, $basicprice, $supplementAmnt, $supplementType) { 

    // Create two 'helper' booleans to make the if condition easier. 
    $weekInRange = ($weekno >= $weekStartno && $weekno <= $weekEndno); 
    $noOfWeeksInRange = 
     ($condition == 'Less Than' && $noofweeks < $conditionWeeks) || 
     ($condition == 'More Than' && $noofweeks > $conditionWeeks); 

    // Alternatively, you can break the single line above up in multiple 
    // lines, which makes debugging easier: 
    //$noOfWeeksInRange = ($condition == 'Less Than' && $noofweeks < $conditionWeeks); 
    //$noOfWeeksInRange |= ($condition == 'More Than' && $noofweeks > $conditionWeeks); 

    if ($condition == "Between") { 
    // I need to get the start and end values as the data in this parameter should look like 1-17 
    $betweenArray = explode('-',$conditionWeeks); 
    $startWeek = $betweenArray[0]; 
    $endWeek = $betweenArray[1]; 
    // Overwrite this variable with the condition that goes with 'Between'. 
    // We're already in that if, so we don't need to check 'Condition' again.. 
    // You could use betweenArray[0] and [1] in the condition below, but using 
    // the variables $startWeek and $endWeek does make it more readable. 
    $noOfWeeksInRange = ($noofweeks >= $startWeek && $noofweeks <= $endWeek); 
    } 

    // And not this 'if' is even more readable. 
    if ($weeksInRange && $noOfWeeksInRange) 
    { 
     // You can use a 'switch' as well, instead of if...elseif. 
     if ($supplementType == 'Subtract') { 
     return $basicprice - $supplementAmnt; 
     } elseif ($supplementType == 'Add' { 
     return $basicprice + $supplementAmnt; 
     } 
    } 
    return $basicprice; 
} ?>