C字數直方圖應用程序返回無輸出

Question

我試圖通過創建一個水平方向的直方圖來測量用戶輸入中不同長度的單詞的頻率來解決K練習1-13。這裏是我的代碼：

#include <stdio.h> 

main(){ 

int a, b, c, d;         //array_position, word_length, getchar(), word_count 
int y[10];          //array representing word lengths from 1-10 letters 

b = 0;           //word_length initializes with a zero value 
a = 1;           //array_position initializes with a value of one (no words contain zero characters) 


for(y[a] = 0; (c = getchar()) != EOF;){   //current array position initializes with a zero value, and c initializes as the current input character 
    if(c != ' ' && c != '\n' && c != '\t')  //if c is anything other than a blank, newline or tab 
     ++b;          //increment the word_length by one 
    else          //otherwise 
     ++a;         //increment the array_position by one 
     b = 0;         //and reset the word_length to zero 
} 

a = 1;           //reset the array_position to one 

do{ 
    if(y[a] > 0){        //if current array_position holds a value greater than 0 
     printf("%i",a);       //print the name of the array_position (1,2,3...) 
     for(d = 0; d < y[a]; ++d){    //reset the word_length--if the word_length is less than the value contained in the current array position, increment the word length by one 
      putchar('-');      //print a dash and re-evaluate the condition 
     } 
     if(d == y[a]){       //when the word_length is equal to the value contained in the current array position 
      putchar('-');      //print a final dash 
      putchar('\n');      //and a newline 
     } 
    } 
    ++a;          //increment the array position by one 
}while(a > 11);         //repeat until the current array position is 11 
} 

的代碼是爲了產生一個非常簡單的圖表會是這個樣子，分揀長度的話，從1-10個字符：

1--- 
2---------- 
3----- 
4-- 

等。它也會忽略任何不是由輸入中的一個或多個單詞表示的長度。但是，上面顯示的代碼返回否輸出根本沒有，我一直在處理這個問題三天。

我無法看到，這阻止了我的代碼產生所需的輸出？

Answer 1

在這個循環中

a = 1;           //reset the array_position to one 
do{ 
    if(y[a] > 0){        //if current array_position holds a value greater than 0 
     printf("%i",a);       //print the name of the array_position (1,2,3...) 
     for(d = 0; d < y[a]; ++d){    //reset the word_length--if the word_length is less than the value contained in the current array position, increment the word length by one 
      putchar('-');      //print a dash and re-evaluate the condition 
     } 
     if(d == y[a]){       //when the word_length is equal to the value contained in the current array position 
      putchar('-');      //print a final dash 
      putchar('\n');      //and a newline 
     } 
    } 
    ++a;          //increment the array position by one 
}while(a > 11); 

你需要檢查while (a < 11)代替while (a > 11)

而且，（由@WeatherVane指出）：

if(c != ' ' && c != '\n' && c != '\t')  //if c is anything other than a blank, newline or tab 
    ++b;          //increment the word_length by one 
else          //otherwise 
    ++a;         //increment the array_position by one 
    b = 0; 

看起來可疑，你忘了第二塊周圍的大括號？

if(c != ' ' && c != '\n' && c != '\t')  //if c is anything other than a blank, newline or tab 
    ++b;          //increment the word_length by one 
else {          //otherwise 
    ++a;         //increment the array_position by one 
    b = 0; 
} 

Answer 2

兩個主要問題：

首先，正如前面提到的，你do..while迴路應檢查a < 11而不是a > 11。

第二個問題是在你的第一個for循環：

for(y[a] = 0; (c = getchar()) != EOF;){  
    if(c != ' ' && c != '\n' && c != '\t') 
     ++b;         
    else          
     ++a;         
     b = 0;        
} 

除了圍繞else部分丟失的括號，你永遠只是位置1，當你第一次進入分配什麼的y元素循環。

您需要將數組元素初始化爲0，那麼你就需要增加y[b]而不是a：

for (d=0;d<10;d++) { 
    y[d] = 0; 
} 
while ((c = getchar()) != EOF) { 
    if(c != ' ' && c != '\n' && c != '\t') { 
     ++b;         
    } else { 
     ++y[b]; 
     b = 0;  
    }       
}