我可以簡化這個VB.net代碼嗎，所以我不必重複這麼多？

Question

我正在創建一個調度算法。我的代碼變得很長。任何人都可以建議我怎樣才能讓我的代碼更短，因爲我必須在下面多次重複相同的事情，而外部的其他位置是4或5，我必須重複更多：

下面是我的部分示例代碼：

ElseIf Val(jobs_txt.Text) = 3 Then 
      If (a < b And b < c) Then 
       awt1_lbl.Text = Val(0) 
       awt2_lbl.Text = a 
       awt3_lbl.Text = a + b 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (a < c And c < b) Then 
       awt1_lbl.Text = Val(0) 
       awt2_lbl.Text = a + b 
       awt3_lbl.Text = a 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (b < a And a < c) Then 
       awt1_lbl.Text = a 
       awt2_lbl.Text = Val(0) 
       awt3_lbl.Text = a + b 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (b < c And c < a) Then 
       awt1_lbl.Text = a + b 
       awt2_lbl.Text = Val(0) 
       awt3_lbl.Text = a 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (c < a And a < b) Then 
       awt1_lbl.Text = a 
       awt2_lbl.Text = a + b 
       awt3_lbl.Text = Val(0) 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      ElseIf (c < b And b < a) Then 
       awt1_lbl.Text = a + b 
       awt2_lbl.Text = a 
       awt3_lbl.Text = Val(0) 
       y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
       awt_ans.Text = y 
      End If 

Answer 1

是的，有幾件事情，你可以做：

• 的y計算是在任何情況下是相同的，所以您不必重複。
• 最後ElseIf永遠是真實的，所以只需使用一個Else
• 使用Val(0)會造成大量的隱式轉換的，它實際上將最終被CStr(Val(Cstr(0)))，所以只需使用"0"。

代碼：

ElseIf Val(jobs_txt.Text) = 3 Then 
    If (a < b And b < c) Then 
    awt1_lbl.Text = "0" 
    awt2_lbl.Text = a 
    awt3_lbl.Text = a + b 
    ElseIf (a < c And c < b) Then 
    awt1_lbl.Text = "0" 
    awt2_lbl.Text = a + b 
    awt3_lbl.Text = a 
    ElseIf (b < a And a < c) Then 
    awt1_lbl.Text = a 
    awt2_lbl.Text = "0" 
    awt3_lbl.Text = a + b 
    ElseIf (b < c And c < a) Then 
    awt1_lbl.Text = a + b 
    awt2_lbl.Text = "0" 
    awt3_lbl.Text = a 
    ElseIf (c < a And a < b) Then 
    awt1_lbl.Text = a 
    awt2_lbl.Text = a + b 
    awt3_lbl.Text = "0" 
    Else 
    awt1_lbl.Text = a + b 
    awt2_lbl.Text = a 
    awt3_lbl.Text = "0" 
    End If 
    y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
    awt_ans.Text = y 

其實，如果值沒有被轉換爲字符串，然後返回到數字，你可以簡單地計算y這樣的：

y = (a * 2 + b)/3 

Answer 2

首先，看起來你可以移動最後兩行

y = (Val(awt1_lbl.Text) + Val(awt2_lbl.Text) + Val(awt3_lbl.Text))/3 
awt_ans.Text = y 

以外的if-then-else，因爲他們在所有六種情況下做同樣的事情。

接下來，因爲它看起來像你的代碼分配瓦爾（0）與最小的關鍵，a+b在中間值的項目，a到最大的一個，你可以把a，b和c在鍵陣列，awt1_lbl，awt2_lb，和awt3_lbl入值的陣列，並且對它們進行排序，例如：

Dim keys() As String = { a, b, c } 
Dim labels() As LabelType = { awt1_lbl, awt2_lb, awt3_lbl } // put real label type there 
Array.Sort(keys, labels) 
labels(0).Text = Val(0) 
labels(1).Text = a+b 
labels(2).Text = a 

Answer 3

除了其他的答案，這：

If (a < b And b < c) Then 

應該是一樣的：

If (a < b < c) Then 

爲您節省幾個大字！

編輯：MetaKnight是對的，這是無效的語法。但編譯器不抱怨，我不知道它做了什麼。

Answer 4

你應該做一個類的話，那麼它更易於閱讀，再使用維護和擴展：

Dim awt = New AWT(a, b, c) 
awt1_lbl.Text = awt.GetAWT1().ToString 
awt2_lbl.Text = awt.GetAWT2().ToString 
awt3_lbl.Text = awt.GetAWT3().ToString 
awt_ans.Text = awt.GetY().ToString 

這裏是一個可能的實現，我將它Option Strict，以便它可以很容易地被翻譯到C＃並且也不太容易出錯。

Public Class AWT 
    Public Property A As Int32 
    Public Property B As Int32 
    Public Property C As Int32 

    Public Sub New(a As Int32, b As Int32, c As Int32) 
     Me.A = a 
     Me.B = b 
     Me.C = c 
    End Sub 

    Public Function GetY() As Int32 
     Return GetAWT1() + GetAWT2() + GetAWT3() 
    End Function 

    Public Function GetAWT1() As Int32 
     If (A < B AndAlso B < C) OrElse (A < C AndAlso C < B) Then 
      Return 0 
     ElseIf (B < A AndAlso A < C) OrElse (C < A AndAlso A < B) Then 
      Return A 
     Else 
      Return A + B 
     End If 
    End Function 

    Public Function GetAWT2() As Int32 
     If (A < B AndAlso B < C) OrElse (C < B AndAlso B < A) Then 
      Return A 
     ElseIf (A < C AndAlso C < B) OrElse (C < A AndAlso A < B) Then 
      Return A + B 
     Else 
      Return 0 
     End If 
    End Function 

    Public Function GetAWT3() As Int32 
     If (A < B AndAlso B < C) OrElse (B < A AndAlso A < C) Then 
      Return A + B 
     ElseIf (A < C AndAlso C < B) OrElse (B < C AndAlso C < A) Then 
      Return A 
     Else 
      Return 0 
     End If 
    End Function 

End Class