如何在Rails視圖模板中擺脫這個討厭的查詢？

Question

Yuck。它讓我失望。

在我的控制器：

@assessor = Assessor.find(params[:id]) 
@assessor.answers.build if @assessor.answers.empty? 

筆者認爲：

= simple_form_for @assessor do |f| 
    - @assessor.candidates.each do |candidate| 
     - @assessor.assessment_competencies.each do |competency|      

      - if @assessor.answers.all?{|a| a.new_record?} 
       - competency.behaviors.each do |behavior| 
        = f.fields_for :answers do |f| 
         - @assessor.standard_answer_choices.each do |choice| 
          = f.input :assessor_id, :as => :hidden, :input_html => {:value => @assessor.id} 
          = f.input :candidate_id, :as => :hidden, :input_html => {:value => candidate.id} 
          = f.input :behavior_id, :as => :hidden, :input_html => {:value => behavior.id} 
          = f.input :competency_id, :as => :hidden, :input_html => {:value => competency.id} 
          = f.association :answer_choice, :collection => [choice], :as => :radio 

      - else 
       - competency.behaviors.each do |behavior| 
        - answer = Answer.find_or_create_by_behavior_id_and_assessor_id_and_candidate_id(behavior.id, @assessor.id, candidate.id) 
        = f.fields_for :answers, answer do |f| 
         = f.input :assessor_id, :as => :hidden, :input_html => {:value => @assessor.id} 
         = f.input :candidate_id, :as => :hidden, :input_html => {:value => candidate.id} 
         = f.input :behavior_id, :as => :hidden, :input_html => {:value => behavior.id} 
         = f.input :competency_id, :as => :hidden, :input_html => {:value => competency.id} 
         = f.association :answer_choice, :collection => [choice], :as => :radio 

Answer 1

OOF，這是一個粗糙的一個。

至少，你可以抽出反覆fields_for塊伸到一個幫手：

module AssessorsHelper 
    def answers_fields f, candidate, behavior, competency, answer=nil 
    assessor = f.object 

    f.fields_for :answers, answer do |f| 
     f.hidden_field :assessor_id, :value => assessor.id 
     f.hidden_field :candidate_id, :value => candidate.id 
     f.hidden_field :behavior_id, :value => behavior.id 
     f.hidden_field :competency_id, :value => competency.id 
     f.association :answer_choice, :collection => [choice], :as => :radio 
    end 
    end 
end 

這會降低你的看法到這一點：

= simple_form_for @assessor do |f| 
    - @assessor.candidates.each do |candidate| 
    - @assessor.assessment_competencies.each do |competency|      

     - if @assessor.answers.all?{|a| a.new_record?} 
     - competency.behaviors.each do |behavior| 
      = answers_fields f, candidate, behavior, competency 

     - else 
     - competency.behaviors.each do |behavior| 
      - answer = @assessor.answers.find_or_create_by_behavior_id_and_candidate_id behavior, candidate 

      = answers_fields f, candidate, behavior, competency, answer 

如果你想你可以打破它成爲每個內部循環的幫手，但你明白了。