計算錯誤

Question

仍然工作在這種愚蠢的時間程序....在計算中，似乎分鐘再予我的新問題是不被加總，我不知道爲什麼...任何INOUT將不勝感激一如既往:)

public class Time { 

    public int Minutes, Hours, TotalMin; 
    private String correctedMinutes ; 
    public String valid, TimeofDay; 
    public String error, noerror; 


    //----------------------------------------------------------------- 
    // Sets up the time by defining its minutes and hours 
    //----------------------------------------------------------------- 

public Time() { 
    this.Hours = 0; 
    this.Minutes = 0;} 

public Time(int hour, int minute, String timeofday) { 
    this.Hours = hour; 
    this.Minutes = minute; 
    this.TimeofDay = timeofday;} 


public String testTimeofDay (String timeofday) 

{ 
    if (TimeofDay.equals ("AM")) {TimeofDay="AM"; 
     return "";} 

    else if (TimeofDay.equals("PM")) {TimeofDay="PM"; 
     return "";} 

     else {TimeofDay="AM"; 
     return "Invalid Entry: AM/PM";} 
    } 

public String testHoursMinutes(int hours, int minutes) 

{ 
    if (Minutes>59|| Minutes<0||Hours>23 || Hours<0) 
     {Minutes=0; 
     Hours=0; 
     TimeofDay="AM"; 
     return "Invalid Entry: Incorrect Value";} 

      else {Hours=hours; 
      Minutes=minutes; 
      return "";} 



} 


public int addMinutes (int hours, int minutes, int elapsedMin) 
    { 
     if (elapsedMin<0) 
      TotalMin=minutes; 

      else { 
      TotalMin=elapsedMin+Minutes;} 

      return TotalMin;} 

public String ConvertMintoHour (int hours, int minutes){   
     while (TotalMin>60) 
      {TotalMin=TotalMin-60; 
      Hours=Hours+1; 
      if (Hours==13) 
      { Hours=0; 

      Minutes=TotalMin; 
      }} 
return(Hours+ " " +Minutes); 




    } 
public String toString() 
     { 
      String correctedMinutes = String.format("%02d", Minutes); 
      return (Hours+ ":" + correctedMinutes + TimeofDay);  } 





} 

這裏是測試代碼：

import java.util.Scanner; 


public class TimeTest { 

    public static void main(String[] args) { 
     // TODO Auto-generated method stub 


int minutes, hours, elapsedMin; 
String timeofday, startTime; 

Scanner scan=new Scanner (System.in); 

System.out.println("Please enter starting hour (1-12):"); 
hours=scan.nextInt(); 
System.out.println("Please enter starting minute (0-59):"); 
minutes=scan.nextInt(); 
System.out.println("Please enter AM or PM:"); 
timeofday=scan.next(); 


Time classtime = new Time (hours, minutes, timeofday); 

System.out.println(classtime.testTimeofDay(timeofday)); 
System.out.println(classtime.testHoursMinutes (hours, minutes)); 
System.out.println(classtime.toString()); 


System.out.print("The class begins at "); 
System.out.println (classtime.toString()); 

startTime=classtime.toString(); 

System.out.println("Enter a time in minutes representing the class duration:"); 
elapsedMin=scan.nextInt(); 

classtime.addMinutes (hours, minutes, elapsedMin); 
System.out.println ("Class End Time:" + classtime.toString()); 


System.out.print(elapsedMin + " minutes after "+ startTime + " is "); 
System.out.println (classtime.toString()); 





System.out.print("The class ends at "); 
System.out.println (classtime.toString()); 


System.out.print("The class ends at "); 

System.out.print("MILITARY"); 
}} 

Answer 1

在方法String ConvertMintoHour (int hours, int minutes)。改變你的條件從

while (TotalMin>60) 

要

while (TotalMin>59) 

Answer 2

你有一些問題，但讓我們開始與addMinutes方法...

public int addMinutes(int hours, int minutes, int elapsedMin) { 
    if (elapsedMin < 0) { 
     TotalMin = minutes; 
    } else { 
     TotalMin = elapsedMin + Minutes; 
    } 

    return TotalMin; 
} 

基本上hours和minutes從不，沒有道理，應該丟棄。

你加elapsedMin到TotalMin，但它永遠不會用於生產輸出。

相反，你應該應用值回Hours和Minutes變量，例如...

public int addMinutes(int elapsedMin) { 

    int time = (Hours * 60) + Minutes; 
    time += elapsedMin; 

    Hours = time/60; 
    time = time % 60; 
    Minutes = time; 

    return time; 

} 

這個概念也可以應用到你的ConvertMintoHour方法）

一個簡單的解決方案將把時間的內部概念作爲自午夜以來的分鐘數來管理。

這將讓你簡單的加法或者減法，從你的「時間」類分鐘。當你準備好，你可以使用上面的算法來生成你需要生成輸出小時和分鐘......恕我直言

我敢肯定有人已經指出了這一點給你，但你應該採取時間通過Code Conventions for the Java Programming Language閱讀，這將有助於使你的代碼更易於讀取，其他開發商;）

Answer 3

方法ConvertMintoHour可以簡單地寫爲：

public String ConvertMintoHour() { 
     int noOfHrs = TotalMin/60; 
     Hours = (Hours + noOfHrs) % 13; 
     Minutes = TotalMin % 60; 
     return Hours + " " + Minutes; 
}