有關SQL IN功能

Question

我已經寫在程序爲：

create proc proc_sample 

@emp_id as nvarchar(500) 
as 
begin 
declare @sql as varchar(500) 

set @sql=' 
select tdate,emp_id, 
    max(convert(varchar(40),DateDiff(minute,cast(tdate + ' ' +intime as datetime), 
    Cast(isnull(tdate_out,tdate) + ' ' +outtime as datetime))%(24*60)/60)+ 'hrs'+ 
    convert(varchar(40),DateDiff(minute,cast(tdate + ' ' +intime as datetime), 
    Cast(isnull(tdate_out,tdate) + ' ' +outtime as datetime))%60)+ 'min') 
    as [Worked Hour],max(intime),max(outtime),max(inremarks) 
from tbl_emp_attn_log 
where emp_id in ('+@emp_id+')and tdate 
    between '2010-1-01 00:00:00' and '2011-04-09 00:00:00' 
group by tdate,emp_id order by emp_id,tdate' 
end 

但它顯示了以下錯誤：

Msg 170, Level 15, State 1, Procedure proc_sample, Line 10 
Line 10: Incorrect syntax near ' +intime as datetime), Cast(isnull(tdate_out,tdate)+'. 

，當我試圖解決這個問題，我不能讓我的願望的結果。所以任何一個在那裏解決這個

Answer 1

要避免使用動態SQL，因而寬鬆一些的存儲過程的力量，你可以像我們

CREATE FUNCTION dbo.Split(@String varchar(8000), @Delimiter char(1))  
returns @temptable TABLE (items varchar(8000))  
as  
begin  
    declare @idx int  
    declare @slice varchar(8000)  

    select @idx = 1  
     if len(@String)<1 or @String is null return  

    while @idx!= 0  
    begin  
     set @idx = charindex(@Delimiter,@String)  
     if @idx!=0  
      set @slice = left(@String,@idx - 1)  
     else  
      set @slice = @String  

     if(len(@slice)>0) 
      insert into @temptable(Items) values(@slice)  

     set @String = right(@String,len(@String) - @idx)  
     if len(@String) = 0 break  
    end 
return  
end 

一個函數，那麼你可以在你想在你使用IN子句像一個逗號分隔列表中的值發送。然後在你的where子句中，你可以做

WHERE emp_id in (SELECT CONVERT(int, items) FROM dbo.Split(@emp_id, ',')) ... 

這樣你就不必做動態SQL，查詢優化器可以做得更好。

Answer 2

最有可能它是報價問題。 嘗試用這樣的雙引號替換所有單引號。

編輯： - 您正在嘗試使用alias在CAST功能不允許的。

錯誤

cast(tdate + ' ' +intime as datetime) 

正確

cast(tdate as datetime) 

修改後的查詢

create proc proc_sample 

@emp_id as nvarchar(500) 
as 
begin 
declare @sql as varchar(500) 

set @sql=' 
select tdate,emp_id, 
    max(convert(varchar(40),DateDiff(minute,cast(tdate as datetime), 
    Cast(isnull(tdate_out,tdate) as datetime))%(24*60)/60)+ ''hrs''+ 
    convert(varchar(40),DateDiff(minute,cast(tdate as datetime), 
    Cast(isnull(tdate_out,tdate) as datetime))%60)+ ''min'') 
    as [Worked Hour],max(intime),max(outtime),max(inremarks) 
from tbl_emp_attn_log 
where emp_id in ('+@emp_id+')and tdate 
    between ''2010-1-01 00:00:00'' and ''2011-04-09 00:00:00'' 
group by tdate,emp_id order by emp_id,tdate' 
end